unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: Jakub Turski <yacoob@gmail.com>, 7348@debbugs.gnu.org
Subject: bug#7348: 23.2.50; Emacs crashes on fast window resize with scrollbars on under OSX
Date: Mon, 08 Nov 2010 11:07:04 +0100	[thread overview]
Message-ID: <4CD7CBC8.9010103@gmx.at> (raw)
In-Reply-To: <wleiawwpxl.wl%mituharu@math.s.chiba-u.ac.jp>

 > The call to do_pending_window_change at line 11397 in xdisp.c
 > (emacs-23 branch) seems to change selected_window because of the
 > following call chain, but the variable `w' in redisplay_internal still
 > points to the old selected window.
 >
 >   redisplay_internal
 >     -> do_pending_window_change
 >       -> change_frame_size
 >         -> change_frame_size_1
 >           -> set_window_height
 >             -> size_window
 >               -> delete_window (/* Delete WINDOW if it's too small.  */)

That's bad.  So basing redisplay_internal entirely on

   struct window *w = XWINDOW (selected_window);

is inherently broken.  But simply reassigning

    w = XWINDOW (selected_window);

after every do_pending_window_change call is hairy since it changes the
selected window under our feet, so any things done for the window that
was selected before the call would probably have to be redone for the
now selected window.  OTOH going back to retry after every call that
might have changed the selected window could get us into an infinite
loop.  (BTW, do we really need up all three do_pending_window_change
calls in redisplay_internal?)

martin





  reply	other threads:[~2010-11-08 10:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 21:20 bug#7348: 23.2.50; Emacs crashes on fast window resize with scrollbars on under OSX Jakub Turski
2010-11-07  3:18 ` YAMAMOTO Mitsuharu
2010-11-07 10:34   ` martin rudalics
2010-11-08  1:43     ` YAMAMOTO Mitsuharu
2010-11-08 10:07       ` martin rudalics [this message]
2010-11-08 19:24         ` Eli Zaretskii
2010-11-09  7:43           ` martin rudalics
2010-11-09 16:57             ` Eli Zaretskii
2010-11-09 17:52               ` martin rudalics
2010-11-09 18:49                 ` Eli Zaretskii
2010-11-10  7:18                   ` martin rudalics
2011-02-07 17:26                     ` Jakub Turski
2011-02-08  4:57                       ` Eli Zaretskii
2011-02-08  7:23                         ` Jan Djärv
2010-11-07 11:22   ` Jan Djärv
2010-11-07 19:05     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD7CBC8.9010103@gmx.at \
    --to=rudalics@gmx.at \
    --cc=7348@debbugs.gnu.org \
    --cc=mituharu@math.s.chiba-u.ac.jp \
    --cc=yacoob@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).