From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#63840: 29.0.91; c-ts-mode fails to fontify common C extension Date: Mon, 26 Jun 2023 22:54:16 -0700 Message-ID: <4CB53EB5-CFBE-40F4-A303-353B3D891FA5@gmail.com> References: <87fs7anjwq.fsf.ref@yahoo.com> <87fs7anjwq.fsf@yahoo.com> <835y86auxi.fsf@gnu.org> <692BAB16-A7DD-4080-871A-FB541329CCFC@gmail.com> <873532jq2a.fsf@yahoo.com> <83zg51tgjd.fsf@gnu.org> <868C5538-F021-4EF8-9730-0828FC9BD801@gmail.com> <834jn7uddh.fsf@gnu.org> <6871B1D5-9B52-47C0-BB6F-5C41655CD33B@gmail.com> <835y7j8lpk.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40818"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 63840@debbugs.gnu.org, Theodor Thornhill To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 27 07:55:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qE1fe-000APQ-23 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Jun 2023 07:55:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qE1fN-0000CA-O9; Tue, 27 Jun 2023 01:55:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qE1fL-0000Bm-CZ for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 01:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qE1fL-0007gS-31 for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 01:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qE1fK-0005JB-IC for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 01:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2023 05:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63840 X-GNU-PR-Package: emacs Original-Received: via spool by 63840-submit@debbugs.gnu.org id=B63840.168784527820365 (code B ref 63840); Tue, 27 Jun 2023 05:55:02 +0000 Original-Received: (at 63840) by debbugs.gnu.org; 27 Jun 2023 05:54:38 +0000 Original-Received: from localhost ([127.0.0.1]:47435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE1ev-0005IP-PX for submit@debbugs.gnu.org; Tue, 27 Jun 2023 01:54:38 -0400 Original-Received: from mail-pf1-f170.google.com ([209.85.210.170]:59490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE1et-0005I9-7W for 63840@debbugs.gnu.org; Tue, 27 Jun 2023 01:54:37 -0400 Original-Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-666ecf9a081so3796211b3a.2 for <63840@debbugs.gnu.org>; Mon, 26 Jun 2023 22:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687845269; x=1690437269; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MAxCYprVO0YBScKpX9EZp5HDDYttf6MkHSdCvXUcHeM=; b=c8kxDILZy9oTrtvG06qxS4Ow1GXZiDFNDmz0lltnOiKdgu9UFJw+IPsB5hrI037Qjl 8W/XdNXfQdFqIWkesUS89EYpiQu83oyvmQL/DwMm9ee6AM9zgScBU+VRxaOALcB9gunG 0Qid19VFVsjuvbYtIkf0N01CNTSkoqJdy6I7gMrepNpxYywdlI2/K30Oxl/ErsozjfLa b/HgDa8+aFfu9NoSG8TncEIRbRLsggCh9A+FyQQ6+7s6MtjCNj+JkvI0riPn73elv+F9 wLwN74bg/WYJQ+RTicAVC4ihETkKTyvzFLmgs1rqG3x79UqNoRZccBaztzz1KnJME/SO rmjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687845269; x=1690437269; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MAxCYprVO0YBScKpX9EZp5HDDYttf6MkHSdCvXUcHeM=; b=QrqVnhn1oUWYoPM48nFOVuh3tQijANcHh+MCH7vxkJX2vJqaEkS0MJQ+uKhF43i6Lv vKI4QhwZ3IJ6/DEE0AMb689ZLlYvye+p1mk6/z/g3z2TE+QmMvI89nKwY2F5ZegdvREn RXZmvHLrTSPMejbCuoaNWSgyBKTMHplpog2i6dPqOswIglr9fo070K16pwh9W0vrRB1g cCWMwR6iH73OdQ9vN4xjxHBrp5so/1q0/QNmktnPhijabcgGQOy3C/ax6a4TiWbYFaDe 5FWE2H7VJ24vvRsM05bay3bnAc7od9H/T7sJ1p11a1RhbbAQcGxa8jOpcda02g2jR9Ra BaOg== X-Gm-Message-State: AC+VfDxHGyakAY6jVT762WpAIQ+ZFsADUXjXGZYSBE2ur+z7oyR3nhu0 pHVFamJ04RRjf0IvEGD2H10= X-Google-Smtp-Source: ACHHUZ49bXSE5xzUTLgfLs1wLxWZCen7FW9eTmVzpHBuClLL0bP9/NqyE0FQd24rMcGFZl0599Jm7w== X-Received: by 2002:a05:6a20:7f84:b0:112:1e0d:14ae with SMTP id d4-20020a056a207f8400b001121e0d14aemr39658078pzj.7.1687845268799; Mon, 26 Jun 2023 22:54:28 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a9-20020aa780c9000000b0064d45eea573sm4626960pfn.41.2023.06.26.22.54.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jun 2023 22:54:28 -0700 (PDT) In-Reply-To: <835y7j8lpk.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.600.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264122 Archived-At: > On Jun 19, 2023, at 9:23 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sun, 18 Jun 2023 23:43:51 -0700 >> Cc: Theodor Thornhill , >> Po Lu , >> 63840@debbugs.gnu.org >>=20 >>> On Jun 15, 2023, at 11:31 PM, Eli Zaretskii wrote: >>>=20 >>>> From: Yuan Fu >>>> Date: Thu, 15 Jun 2023 22:05:33 -0700 >>>> Cc: Theodor Thornhill , >>>> Po Lu , >>>> 63840@debbugs.gnu.org >>>>=20 >>>>> Ping! Any progress with this? >>>>=20 >>>> The best option is to ask tree-sitter-c to recognize $. I see a PR = for it but the author closed it shortly after posting, not sure what was = going on[1]. >>>=20 >>> Any hope of re-opening it, or at least asking why it was closed >>> without fixing? >>=20 >> I asked on GitHub. >>=20 >>>=20 >>>> Fixing it ourselves involves checking every identifier during = fontification. Is that something we want to do? >>>=20 >>> How would that work? Can you describe how could this be = implemented? >>> It is hard to decide whether it's something we want to do without >>> knowing the implications. >>=20 >> I was going to write a demo implementation, but that actually would = change quite some lines. So let me just describe it for now. In = c-ts-mode--font-lock-settings, I would replace all the different types = of faces used for all the identifiers to a function. (If you search for = identifier in c-ts-mode--font-lock-settings, there are quite a few of = them.) This function would obviously receive the beg and end of the = identifier tree-sitter detects, and it would check if there are $ right = before or after the given range, if there is, it would extend the range = fontified. >>=20 >> For example, for a code like abc$de, tree-sitter might consider abc = as an identifier, and $ de to be error. The function I mentioned would = look at abc=E2=80=99s beg and end, and see that c is immediately = followed by a $, so it would extend the fontification range to include = abc$de. >=20 > Thanks. This sounds like a lot of hair, so let's first see how the > developers of the tree-sitter-c grammar respond. Cool. (Not surprisingly) I didn=E2=80=99t get any reply on GitHub as for = now. It would be nice if tree-sitter-c (and other grammars) can have a = separate maintainer other than tree-sitter=E2=80=99s author. He seems to = be heavily overloaded right now (tree-sitter, a dozen grammars, Zed = editor). Yuan