bug#6956: 24.0.50; pasting mouse selection in other session pastes only first word

[David De La Harpe Golden <david@harpegolden.net>]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

On 05/09/10 02:53, Chong Yidong wrote:

> We don't need to explain what mouse-drag-copy-region does twice.
> Just add a separate paragraph saying
>
>    If `mouse-drag-copy-region' is non-nil, this command also saves the
>    region to the kill ring, replacing the previous kill if it was also
>    made with `mouse-save-then-kill'.
>

^^^ Strictly that's not true, it also replaces kills made by mouse-drag 
i.e. an already active region (otherwise you would drag select a region 
with mouse-1, then mouse-3 extend, and you'd get two kill ring entries).

Here's one with revised doc phrasing.

...I haven't tried making shift-selection respect 
"mouse"-"drag"-copy-region as yet, but that should be straightforward 
given similarity to the "select-active-regions => 'only" code path. 
(It's not like I'm personally going to use mouse-drag-copy-region => t 
in any case....)

The customization name would then be kind of misleading, but, well, it 
has company.   Effectively, mouse-drag-copy-region would "really" be 
something like the (hypothetical) "clipboard-active-regions => 'only" in 
end effect, though probably implemented by hitting the kill ring and 
thus (maybe) the os clipboard as a side effect, so maybe
"killring-active-regions => 'only" would be more accurate.








[-- Attachment #2: mouse-save-then-kill-save-on-mdcr_r2.diff --]
[-- Type: text/x-patch, Size: 2288 bytes --]

=== modified file 'lisp/mouse.el'
--- lisp/mouse.el	2010-08-29 16:17:13 +0000
+++ lisp/mouse.el	2010-09-05 14:07:38 +0000
@@ -43,7 +43,10 @@
   :group 'mouse)
 
 (defcustom mouse-drag-copy-region nil
-  "If non-nil, mouse drag copies region to kill-ring."
+  "If non-nil, copy to kill-ring upon mouse adjustments of the region.
+
+This affects `mouse-save-then-kill' (\\[mouse-save-then-kill]) in
+addition to mouse drags."
   :type 'boolean
   :version "24.1"
   :group 'mouse)
@@ -1348,8 +1351,13 @@
 have selected whole words or lines, move point or mark to the
 word or line boundary closest to CLICK instead.
 
+If `mouse-drag-copy-region' is non-nil, this command also saves the
+new region to the kill ring (replacing the previous kill if the
+previous region was just saved to the kill ring).
+
 If this command is called a second consecutive time with the same
-CLICK position, kill the region."
+CLICK position, kill the region (or delete it
+if `mouse-drag-copy-region' is non-nil)"
   (interactive "e")
   (mouse-minibuffer-check click)
   (let* ((posn     (event-start click))
@@ -1371,7 +1379,11 @@
      ((and (eq last-command 'mouse-save-then-kill)
 	   (eq click-pt mouse-save-then-kill-posn)
 	   (eq window (selected-window)))
-      (kill-region (mark t) (point))
+      (if mouse-drag-copy-region
+          ;; region already saved the previous click,
+          ;; don't make a duplicate entry, just delete
+          (delete-region (mark t) (point))
+        (kill-region (mark t) (point)))
       (setq mouse-selection-click-count 0)
       (setq mouse-save-then-kill-posn nil))
 
@@ -1394,6 +1406,9 @@
 	  (goto-char (nth 1 range)))
 	(setq deactivate-mark nil)
 	(mouse-set-region-1)
+        (when mouse-drag-copy-region
+          ;; presumably region already copied to kill-ring once, so replace.
+          (kill-new (filter-buffer-substring (mark t) (point)) t))
 	;; Arrange for a repeated mouse-3 to kill the region.
 	(setq mouse-save-then-kill-posn click-pt)))
 
@@ -1405,6 +1420,8 @@
 	(if before-scroll (goto-char before-scroll)))
       (exchange-point-and-mark)
       (mouse-set-region-1)
+      (when mouse-drag-copy-region
+        (kill-new (filter-buffer-substring (mark t) (point))))
       (setq mouse-save-then-kill-posn click-pt)))))
 
 \f