> On Feb 6, 2023, at 7:31 PM, Eli Zaretskii wrote: > >> From: Yuan Fu >> Date: Mon, 6 Feb 2023 19:00:30 -0800 >> Cc: Mickey Petersen , >> 61235@debbugs.gnu.org >> >>> Yuan, any reason not to extend treesit-node-check instead? >> >> I did extend treesit-node-check in the patch. But I also added a function treesit-parser-live-p, which makes the same check but directly on a parser. It just made sense to me that if we let treesit-node-check check the nodes’ parser’s status, we’d also add a function to allow directly checking the status of a parser. > > That additional function would signal an error in the case discussed > here, so I'm not sure we should add it in that shape, or at all. Why > isn't treesit-node-check enough? Oops, it shouldn’t have. The updated patch fixes that. Treesit-node-check is enough, it just made more sense implentattion-wise, to implement that function that checks a parser, and let treesit-node-check use that function to check the node’s parser. We can choose to not expose that function, and only expose this feature through treesit-node-check, if you prefer so. Yuan