bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments

["Mattias Engdegård" <mattias.engdegard@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

5 juni 2024 kl. 19.48 skrev Eli Zaretskii <eliz@gnu.org>:

> Thanks, I'd like to see the changes before making up my mind about
> that.  The problem is definitely not serious, so the fix should be
> safe enough to qualify.

Sorry, meant to attach the patch.


[-- Attachment #2: 0001-Format-string-warnings-for-more-functions-bug-71379.patch --]
[-- Type: application/octet-stream, Size: 1098 bytes --]

From 6f758e82a37a6b62abc71459c8878de7217834ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= <mattiase@acm.org>
Date: Wed, 5 Jun 2024 18:28:59 +0200
Subject: [PATCH] Format string warnings for more functions (bug#71379)

* lisp/emacs-lisp/bytecomp.el (byte-compile-format-like):
Add message-box, message-or-box, warn and user-error.
---
 lisp/emacs-lisp/bytecomp.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 03cfbe6f4c9..d59e89bd7de 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1643,7 +1643,8 @@ byte-compile-format-warn
          nargs (if (= nargs 1) "" "s")
          nfields (if (= nfields 1) "" "s"))))))
 
-(dolist (elt '(format message format-message error))
+(dolist (elt '( format message format-message message-box message-or-box
+                warn error user-error))
   (put elt 'byte-compile-format-like t))
 
 ;; Warn if the function or macro is being redefined with a different
-- 
2.32.0 (Apple Git-132)