unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Christoph <cschol2112@googlemail.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 6602@debbugs.gnu.org
Subject: bug#6602: [PATCH] make dist target for Windows
Date: Sat, 24 Jul 2010 20:04:57 -0600	[thread overview]
Message-ID: <4C4B9BC9.2070007@gmail.com> (raw)
In-Reply-To: <AANLkTinwg6zjVwBWb-C0Mnw9_z+YQoPaS4F=TLQrLqF5@mail.gmail.com>

On 7/24/2010 7:01 PM, Juanma Barranquero wrote:

> I noticed, but it was always possible to make a branch emacs-VERSION
> and build the dist from here.
> I suppose this change is for better, but it makes more difficult to
> create a dist with a root directory named other than emacs-VERSION
> (for my own use, for example, I call them just VERSION, ie., 23.1,
> 23.2, 24.0.50, etc.). It'd be nice to have a way to customize this,
> but don't lose time over it; "unzip&  rename dir" is just a command
> away :-)

True. I didn't think of that. This is just the most common use case, I 
guess. My main intention behind this was to provide an easy and 
consistent way of producing snapshot and release distributions. 
Theoretically, you can edit the value of TMP_DIST_DIR in the Makefile to 
change the directory, too.

> It is highly unlikely for the user to have a directory
> nt/emacs-VERSION, but you overwrite it and then remove it, so it'd be
> nice to check and refuse to do anything if it already exists.

Actually, the mkdir command fails and the process stops with an error, 
if the directory already exists. I tested this before I added the 
DEL_TREE command.

>> There is also a minor bugfix: README.W32 was not copied to the install
>> directory when using `make install'.
>
> In fact, there's still a minor issue: README.W32 gets copied to
> INSTALL_DIR and not removed. For example, I do all installations
> in-place, and after make dist I end with a README.W32 at the root of
> my trunk branch. (I've added exclusions to .(bzr|git)ignore, so it's
> not much of an issue, but still...).

Perhaps it should be added to `distclean'?

Christoph





  reply	other threads:[~2010-07-25  2:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-10 14:00 bug#6602: [PATCH] make dist target for Windows Christoph
2010-07-22  9:19 ` Juanma Barranquero
2010-07-22  9:20   ` Juanma Barranquero
2010-07-22 10:01   ` Juanma Barranquero
2010-07-23  1:14     ` Christoph
2010-07-23  1:22       ` Juanma Barranquero
2010-07-24  3:18         ` Christoph
2010-07-24 13:28           ` Juanma Barranquero
2010-07-24 13:31             ` Juanma Barranquero
2010-07-24 22:19             ` Christoph
2010-07-25  1:01               ` Juanma Barranquero
2010-07-25  2:04                 ` Christoph [this message]
2010-07-25  2:55                   ` Juanma Barranquero
2010-07-25  3:18                     ` Christoph
2010-07-25  3:58                       ` Juanma Barranquero
2010-07-25  4:44                         ` Christoph
2010-07-25 12:30                       ` Sean Sieger
2010-07-25 14:09                         ` Christoph
2010-07-25 17:36                           ` Sean Sieger
2010-07-27 22:25                           ` Sean Sieger
2010-07-27 23:04                             ` Juanma Barranquero
2010-07-27 23:32                               ` Christoph
2010-07-28  1:31                               ` Sean Sieger
2010-07-27 23:25                             ` Christoph
2010-07-28  1:33                               ` Sean Sieger
2010-07-27  1:48                         ` Christoph
2010-07-27 21:08                           ` Sean Sieger
2010-07-27 22:59                             ` Juanma Barranquero
2010-07-28  1:34                               ` Sean Sieger
2010-07-27 23:08                             ` Christoph
2010-07-28  1:38                               ` Sean Sieger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4B9BC9.2070007@gmail.com \
    --to=cschol2112@googlemail.com \
    --cc=6602@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).