unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: Dan Nicolaescu <dann@gnu.org>
Cc: "6715@debbugs.gnu.org" <6715@debbugs.gnu.org>
Subject: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c
Date: Sat, 24 Jul 2010 08:22:40 -0400	[thread overview]
Message-ID: <4C4ADB10.4030204@cornell.edu> (raw)
In-Reply-To: <yxqaaphtqbr.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

On 7/24/2010 1:13 AM, Dan Nicolaescu wrote:
> BTW, it would be good if you could look at configure.in and see if the
> line:
>
>    cygwin) LINKER="\$(CC)" ;;
>
> [Just trying to remove special cases from the build system to simplify it...]

There's no need for cygwin to be a special case here.  Fixing this also 
makes the cygwin case irrelevant in the code that sets LIB_GCC a little 
further down in configure.in.  Please apply the attached patch.

Thanks.

Ken

[-- Attachment #2: cygwin_cleanup.patch --]
[-- Type: text/plain, Size: 868 bytes --]

--- configure.in.orig	2010-07-23 21:46:35.000000000 -0400
+++ configure.in	2010-07-24 07:54:29.328125000 -0400
@@ -3326,9 +3326,7 @@
 ORDINARY_LINK=
 case "$opsys" in
   ## gnu: GNU needs its own crt0.
-  aix4-2|darwin|gnu|usg5-4|irix6-5|sol2*|unixware) ORDINARY_LINK=yes ;;
-
-  cygwin) LINKER="\$(CC)" ;;
+  aix4-2|cygwin|darwin|gnu|usg5-4|irix6-5|sol2*|unixware) ORDINARY_LINK=yes ;;
 
   ## On post 1.3 releases of NetBSD, gcc -nostdlib also clears the
   ## library search parth, i.e. it won't search /usr/lib for libc and
@@ -3381,8 +3379,7 @@
 if test "x$GCC" = "xyes" && test "x$ORDINARY_LINK" != "xyes"; then
 
   case "$opsys" in
-    ## cygwin: don't link against static libgcc.
-    cygwin|freebsd|netbsd|openbsd) LIB_GCC= ;;
+    freebsd|netbsd|openbsd) LIB_GCC= ;;
 
     gnu-*)
       ## armin76@gentoo.org reported that the lgcc_s flag is necessary to

  reply	other threads:[~2010-07-24 12:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 22:44 bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c Ken Brown
2010-07-24  1:23 ` Chong Yidong
2010-07-24  5:13 ` Dan Nicolaescu
2010-07-24 12:22   ` Ken Brown [this message]
2010-07-24 18:48     ` Ken Brown
2010-07-24 20:26       ` Eli Zaretskii
2010-07-24 21:33         ` Ken Brown
2010-07-24 21:34       ` Dan Nicolaescu
2010-07-25 14:38         ` Ken Brown
2010-07-25 20:39           ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4ADB10.4030204@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=6715@debbugs.gnu.org \
    --cc=dann@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).