bug#6594: 23.2; xterm-mouse-mode bug

bug#6594: 23.2; xterm-mouse-mode bug

[Ilya Tatar]

--text follows this line--
This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug.  If you can, give
a recipe starting from `emacs -Q':



Hello,


I started emacs with "emacs -Q -nw" in xterm

% xterm -version
XTerm(257)

- if I click on a character on column 0-94, everything works as 
expected: the point moves to that location.

- if I click on a character on column 95, I get an error:
xterm-mouse-event: Wrong type argument: wholenump, -29

- if I click on a character on column >95, I get the Help menu (same as 
if I clicked on "Help" menu, or pressed "M-` h")


Thanks,
-Ilya




If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
     `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/pkg/gnu/share/emacs/23.2/etc/DEBUG.


In GNU Emacs 23.2.1 (sparc-sun-solaris2.8, GTK+ Version 2.10.13)
  of 2010-05-08 on pkg-build
configured using `configure  '--prefix=/pkg/gnu' 
'--x-includes=/pkg/gnome/include:/usr/X11/include:/usr/openwin/include:/usr/dt/include:/pkg/X11/include' 
'--x-libraries=/pkg/gnome/lib:/usr/X11/lib:/usr/openwin/lib:/usr/dt/lib:/pkg/X11/lib' 
'--with-x' '--with-x-toolkit=gtk' 
'--with-pkg-config-prog=/usr/bin/pkg-config' '--with-xpm' '--with-jpeg' 
'--with-tiff' '--with-gif' '--with-png' 'CC=gcc' 'CFLAGS= -O3 
-mcpu=ultrasparc' 'LDFLAGS=-L/pkg/local/lib -R/pkg/local/lib 
-L/pkg/gnu/lib -R/pkg/gnu/lib' 'CPPFLAGS=-I/pkg/local/include 
-I/pkg/local/include/libpng -I/pkg/gnu/include''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: C
   value of $XMODIFIERS: nil
   locale-coding-system: nil
   default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
   xterm-mouse-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t

Recent input:
ESC [ > 0 ; 2 5 7 ; 0 c ESC ] 1 1 ; r g b : f f f f
/ f f f f / f f f f ESC \ M-x x t - m o u TAB RET C-u
9 5 - ESC [ M SPC ~ & ESC [ M # ~ & ESC [ M SPC C-d
& ESC [ M # C-d & ESC [ M SPC C-M-@ & ESC [ M # C-M-@
& C-g M-x r e p o TAB r t TAB RET

Recent messages:
("emacs")
For information about GNU Emacs and the GNU system, type C-h C-a.
Xterm-Mouse mode enabled
xterm-mouse-event: Wrong type argument: wholenump, -29 [2 times]
Quit
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message sendmail regexp-opt ecomplete rfc822 mml
mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse
rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util
netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock
sha1 hex-util hashcash mail-utils emacsbug help-mode easymenu view tmm
electric cus-start cus-load xt-mouse tooltip ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev loaddefs button minibuffer faces cus-face files
text-properties overlay md5 base64 format env code-pages mule custom
widget hashtable-print-readable backquote make-network-process
font-render-setting gtk x-toolkit x multi-tty emacs)

bug#6594: 23.2; xterm-mouse-mode bug

[Jan Djärv]

Ah, the character representation changed with introduction of Unicode.
I checked in a fix in the emacs-23 branch.

	Jan D.


Ilya Tatar skrev 2010-07-09 19.09:
> --text follows this line--
> This bug report will be sent to the Free Software Foundation,
> not to your local site managers!
> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.
>
> Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
> and to the gnu.emacs.bug news group.
>
> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug. If you can, give
> a recipe starting from `emacs -Q':
>
>
>
> Hello,
>
>
> I started emacs with "emacs -Q -nw" in xterm
>
> % xterm -version
> XTerm(257)
>
> - if I click on a character on column 0-94, everything works as expected: the
> point moves to that location.
>
> - if I click on a character on column 95, I get an error:
> xterm-mouse-event: Wrong type argument: wholenump, -29
>
> - if I click on a character on column >95, I get the Help menu (same as if I
> clicked on "Help" menu, or pressed "M-` h")
>
>
> Thanks,
> -Ilya
>
>
>
>
> If Emacs crashed, and you have the Emacs process in the gdb debugger,
> please include the output from the following gdb commands:
> `bt full' and `xbacktrace'.
> For information about debugging Emacs, please read the file
> /pkg/gnu/share/emacs/23.2/etc/DEBUG.
>
>
> In GNU Emacs 23.2.1 (sparc-sun-solaris2.8, GTK+ Version 2.10.13)
> of 2010-05-08 on pkg-build
> configured using `configure '--prefix=/pkg/gnu'
> '--x-includes=/pkg/gnome/include:/usr/X11/include:/usr/openwin/include:/usr/dt/include:/pkg/X11/include'
> '--x-libraries=/pkg/gnome/lib:/usr/X11/lib:/usr/openwin/lib:/usr/dt/lib:/pkg/X11/lib'
> '--with-x' '--with-x-toolkit=gtk' '--with-pkg-config-prog=/usr/bin/pkg-config'
> '--with-xpm' '--with-jpeg' '--with-tiff' '--with-gif' '--with-png' 'CC=gcc'
> 'CFLAGS= -O3 -mcpu=ultrasparc' 'LDFLAGS=-L/pkg/local/lib -R/pkg/local/lib
> -L/pkg/gnu/lib -R/pkg/gnu/lib' 'CPPFLAGS=-I/pkg/local/include
> -I/pkg/local/include/libpng -I/pkg/gnu/include''
>
> Important settings:
> value of $LC_ALL: nil
> value of $LC_COLLATE: nil
> value of $LC_CTYPE: nil
> value of $LC_MESSAGES: nil
> value of $LC_MONETARY: nil
> value of $LC_NUMERIC: nil
> value of $LC_TIME: nil
> value of $LANG: C
> value of $XMODIFIERS: nil
> locale-coding-system: nil
> default enable-multibyte-characters: t
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
> xterm-mouse-mode: t
> tooltip-mode: t
> mouse-wheel-mode: t
> tool-bar-mode: t
> menu-bar-mode: t
> file-name-shadow-mode: t
> global-font-lock-mode: t
> font-lock-mode: t
> auto-encryption-mode: t
> auto-compression-mode: t
> line-number-mode: t
> transient-mark-mode: t
>
> Recent input:
> ESC [ > 0 ; 2 5 7 ; 0 c ESC ] 1 1 ; r g b : f f f f
> / f f f f / f f f f ESC \ M-x x t - m o u TAB RET C-u
> 9 5 - ESC [ M SPC ~ & ESC [ M # ~ & ESC [ M SPC C-d
> & ESC [ M # C-d & ESC [ M SPC C-M-@ & ESC [ M # C-M-@
> & C-g M-x r e p o TAB r t TAB RET
>
> Recent messages:
> ("emacs")
> For information about GNU Emacs and the GNU system, type C-h C-a.
> Xterm-Mouse mode enabled
> xterm-mouse-event: Wrong type argument: wholenump, -29 [2 times]
> Quit
> Making completion list...
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr message sendmail regexp-opt ecomplete rfc822 mml
> mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse
> rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util
> netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock
> sha1 hex-util hashcash mail-utils emacsbug help-mode easymenu view tmm
> electric cus-start cus-load xt-mouse tooltip ediff-hook vc-hooks
> lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset
> image fringe lisp-mode register page menu-bar rfn-eshadow timer select
> scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core
> frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
> tai-viet lao korean japanese hebrew greek romanian slovak czech european
> ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
> simple abbrev loaddefs button minibuffer faces cus-face files
> text-properties overlay md5 base64 format env code-pages mule custom
> widget hashtable-print-readable backquote make-network-process
> font-render-setting gtk x-toolkit x multi-tty emacs)
>
>

bug#6594: (no subject)

[Ilya Tatar]

Thank you Jan.
I just tried it with
GNU Emacs 23.3.1 (i386-pc-solaris2.10, GTK+ Version 2.10.13) of 2011-04-21
and still see the problem. Should it have been fixed in version 23.3?

I am still using
% xterm -version
XTerm(257)


Started emacs with:
emacs -Q -nw

And ran
M-x xterm-mouse-mode

The behavior is the same as I described previously.

Thank you,
-Ilya

bug#6594: (no subject)

[Jan Djärv]

Hello.

The bug is fixed for me with a stock 23.3 from ftp.gnu.org, tried with xterm 
251 and 261.  I suspect you are loading the wrong xt-mouse.el(c).  Try this
from inside Emacs:

C-h f xterm-mouse-event-read <return>
Click on the xt-mouse.el link.
You should see:

;; read xterm sequences above ascii 127 (#x7f)
(defun xterm-mouse-event-read ()
   (let ((c (read-char)))
     (if (> c #x3FFF80)
         (+ 128 (- c #x3FFF80))
       c)))

If you do and still see the error, ypu have to debug it as I can't reproduce 
it.  Read the Elisp manual (C-h i m elisp <return> m debugging <return>) about 
edebug on how to to that.  Note the values of c that fails for you.

	Jan D.


Ilya Tatar skrev 2011-04-24 03.59:
> Thank you Jan.
> I just tried it with
> GNU Emacs 23.3.1 (i386-pc-solaris2.10, GTK+ Version 2.10.13) of 2011-04-21
> and still see the problem. Should it have been fixed in version 23.3?
>
> I am still using
> % xterm -version
> XTerm(257)
>
>
> Started emacs with:
> emacs -Q -nw
>
> And ran
> M-x xterm-mouse-mode
>
> The behavior is the same as I described previously.
>
> Thank you,
> -Ilya
>
>

bug#6594: xterm-mouse-mode bug still appears in 23.3.1

[Langton, Asher]

I'm still seeing this bug in Emacs 23.3.1 running in iTerm2 (OS X), xterm,
and gnome-terminal. The versions I'm using are:

GNU Emacs 23.3.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)
GNU Emacs 23.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.10.4)

I ran edebug in each of the terminal emulators mentioned above and tried
to capture the value of c after these mouse events. When I clicked in the
right-portion of a large frame, the value was usually:
27 (#o33, #x1b, ?\C-\[)
or
32 (#o40, #x20, ? )


Once, the result was:
101 (#o145, #x65, ?e)

(I did this many times to try to be sure that I was actually looking at
the correct mouse event.)

Is there anything else I can do to help isolate this bug?


Thanks,
Asher

bug#6594: <no subject>

[Langton, Asher]

Running through this in the debugger didn't seem very informative, so I
just put a print statement in xterm-mouse-event that displayed the values
of type, x, and y. For some arbitrary clicks, here was the output (all in
pairs; mouse-1 and down-mouse-1, I assume):

In xterm-mouse-event with 0,130023656,46
In xterm-mouse-event with 3,130023656,46
In xterm-mouse-event with 0,37,35
In xterm-mouse-event with 3,37,35
In xterm-mouse-event with 0,12,33
In xterm-mouse-event with 3,12,33
In xterm-mouse-event with 0,130023730,17
In xterm-mouse-event with 3,130023730,17
In xterm-mouse-event with 0,15,29
In xterm-mouse-event with 3,15,29
In xterm-mouse-event with 0,130023699,29
In xterm-mouse-event with 3,130023699,29
In xterm-mouse-event with 0,26,29
In xterm-mouse-event with 3,26,29
In xterm-mouse-event with 0,52,28
In xterm-mouse-event with 3,52,28
In xterm-mouse-event with 0,82,28
In xterm-mouse-event with 3,82,28
In xterm-mouse-event with 0,94,28
In xterm-mouse-event with 3,94,28
In xterm-mouse-event with 0,130023651,28
In xterm-mouse-event with 3,130023651,28
In xterm-mouse-event with 0,1,29
In xterm-mouse-event with 3,1,29


As you might imagine, the very large x-values correspond to clicks beyond
column 94.

-Asher

bug#6594: <no subject>

[Andreas Schwab]

"Langton, Asher" <langton2@llnl.gov> writes:

> Running through this in the debugger didn't seem very informative, so I
> just put a print statement in xterm-mouse-event that displayed the values
> of type, x, and y. For some arbitrary clicks, here was the output (all in
> pairs; mouse-1 and down-mouse-1, I assume):
>
> In xterm-mouse-event with 0,130023656,46

What does your xterm emit?  What is your keyboard-coding-system?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#6594: <no subject>

[Langton, Asher]

On 7/27/11 1:30 PM, Andreas Schwab wrote:
>"Langton, Asher" <langton2@llnl.gov> writes:
>
>> Running through this in the debugger didn't seem very informative, so I
>> just put a print statement in xterm-mouse-event that displayed the
>>values
>> of type, x, and y. For some arbitrary clicks, here was the output (all
>>in
>> pairs; mouse-1 and down-mouse-1, I assume):
>>
>> In xterm-mouse-event with 0,130023656,46
>
>What does your xterm emit?

I'm not sure what that means. Are you referring to the character encoding?

> What is your keyboard-coding-system?

nil

bug#6594: <no subject>

[Andreas Schwab]

"Langton, Asher" <langton2@llnl.gov> writes:

> On 7/27/11 1:30 PM, Andreas Schwab wrote:
>>"Langton, Asher" <langton2@llnl.gov> writes:
>>
>>> Running through this in the debugger didn't seem very informative, so I
>>> just put a print statement in xterm-mouse-event that displayed the
>>>values
>>> of type, x, and y. For some arbitrary clicks, here was the output (all
>>>in
>>> pairs; mouse-1 and down-mouse-1, I assume):
>>>
>>> In xterm-mouse-event with 0,130023656,46
>>
>>What does your xterm emit?
>
> I'm not sure what that means.

Whatever characters it emits.  See C-h l.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#6594: <no subject>

[Langton, Asher]

On 7/27/11 11:58 PM, Andreas Schwab wrote:
>Whatever characters it emits.  See C-h l.

I launched emacs -nw (in a gnome-terminal), clicked on the far right, and
then typed C-h l. This was the output:

ESC [ > 1 ; 1 4 0 0 ; 0 c ESC [ M SPC M-[ % ESC [ M
# M-[ % C-h l

In an xterm, clicking and holding mouse-1 in the right portion of the
window caused sequences like this to be displayed in the mini-buffer:


ESC [ M SPC M-l +-
ESC [ M SPC M-u >-


In an iTerm on MacOSX, I got similar results (output prefixed by 'ESC [ M
SPC M-'). Is that what you're looking for?

bug#6594: <no subject>

[Langton, Asher]

I looked at this a little more, and on my systems the value of c jumps to
0x8000000 around the 94th column. I don't know much about the internals of
emacs nor what the valid character values are here, but this works for me
on both Linux and OSX:

;; read xterm sequences above ascii 127 (#x7f)
(defun xterm-mouse-event-read ()
  (let ((c (read-char)))
    (cond ((and (> c #x3FFF80) (< c #x3FFFFF))
           (+ 128 (- c #x3FFF80)))
          ((>= c #x8000000)
           (+ 128 (- c #x8000000)))
          (t c))))





-Asher

bug#6594: 23.2; xterm-mouse-mode bug

[Langton, Asher]

[Apologies if this is a duplicate; my previous two replies to this bug
report never showed up.]

I put a print statement in xterm-mouse-event that displayed the values of
type, x, and y. For some arbitrary clicks, here was the output (all in
pairs; mouse-1 and down-mouse-1, I assume):

In xterm-mouse-event with 0,130023656,46
In xterm-mouse-event with 3,130023656,46
In xterm-mouse-event with 0,37,35
In xterm-mouse-event with 3,37,35
In xterm-mouse-event with 0,12,33
In xterm-mouse-event with 3,12,33
In xterm-mouse-event with 0,130023730,17
In xterm-mouse-event with 3,130023730,17

It appears that the value of x jumps to 0x8000000 around the 94th column.
I don't know much about the internals of emacs nor what the valid
character values are here, but this fix works for me on both Linux and OSX:

--- xt-mouse.el	2011-07-25 20:41:03.000000000 -0700
+++ xt-mouse_modified.el	2011-07-25 20:40:39.000000000 -0700
@@ -122,9 +122,11 @@
 ;; read xterm sequences above ascii 127 (#x7f)
 (defun xterm-mouse-event-read ()
   (let ((c (read-char)))
-    (if (> c #x3FFF80)
-        (+ 128 (- c #x3FFF80))
-      c)))
+    (cond ((and (> c #x3FFF80) (< c #x3FFFFF))
+           (+ 128 (- c #x3FFF80)))
+          ((>= c #x8000000)
+           (+ 128 (- c #x8000000)))
+          (t c))))



-Asher

bug#6594: 23.2; xterm-mouse-mode bug

[Asher Langton]

[Apologies if this is a duplicate; I tried both 6594@debbugs.gnu.org
and the bug-gnu-emacs list yesterday, but neither seems to have
worked.]

I put a print statement in xterm-mouse-event that displayed the values of
type, x, and y. For some arbitrary clicks, here was the output (all in
pairs; mouse-1 and down-mouse-1, I assume):

In xterm-mouse-event with 0,130023656,46
In xterm-mouse-event with 3,130023656,46
In xterm-mouse-event with 0,37,35
In xterm-mouse-event with 3,37,35
In xterm-mouse-event with 0,12,33
In xterm-mouse-event with 3,12,33
In xterm-mouse-event with 0,130023730,17
In xterm-mouse-event with 3,130023730,17

It appears that the value of x jumps to 0x8000000 around the 94th column.
I don't know much about the internals of emacs nor what the valid
character values are here, but this fix works for me on both Linux and OSX:

--- xt-mouse.el	2011-07-25 20:41:03.000000000 -0700
+++ xt-mouse_modified.el	2011-07-25 20:40:39.000000000 -0700
@@ -122,9 +122,11 @@
;; read xterm sequences above ascii 127 (#x7f)
(defun xterm-mouse-event-read ()
   (let ((c (read-char)))
-    (if (> c #x3FFF80)
-        (+ 128 (- c #x3FFF80))
-      c)))
+    (cond ((and (> c #x3FFF80) (< c #x3FFFFF))
+           (+ 128 (- c #x3FFF80)))
+          ((>= c #x8000000)
+           (+ 128 (- c #x8000000)))
+          (t c))))



-Asher

bug#6594: 23.2; xterm-mouse-mode bug

[Andreas Schwab]

This is now fixed.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#6594: Auto Reply: bug#6594: closed (Re: bug#6594: 23.2; xterm-mouse-mode bug)

[ilya.tatar]

This is an auto-replied message. I am on vacation until 08/01