bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[Jan D.]

[-- Attachment #1: Type: text/plain, Size: 3674 bytes --]

  This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug.  If you can, give
a recipe starting from `emacs -Q':

% emacs -Q -fn -adobe-courier-medium-r-normal--18-180-75-75-m-110-iso10646-1

(or monospace-18 if you have Xft).

Notice that the fringe close to scroll bar is much wider than the other
fringe (see screenshot).  This appears to depend on the font size, as
for smaller fonts, the effect is not that noticable.
For example, with Gtk+ and lucid, monospace-19 shows this rather well,
but for monospace-20, there is little difference.  But for monospace-20
the fringes are much smaller than for monospace-20.  Why?

Seen on lucid, Motif/Lesstif, and Gtk+ Emacs builds.

     Jan D.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
     `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/usr/local/share/emacs/24.0.50/etc/DEBUG.


In GNU Emacs 24.0.50.2 (x86_64-unknown-linux-gnu, GNU/LessTif Version 2.1 
Release 0.95.2)
  of 2010-07-09 on f13virt.localdomain
Windowing system distributor `Fedora Project', version 11.0.10800000
configured using `configure  '--with-x-toolkit=motif''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: C
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: sv_SE.utf8
   value of $XMODIFIERS: @im=none
   locale-coding-system: utf-8-unix
   default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> C-x k <return>
<down-mouse-1> <mouse-1> x x x x x <help-echo> <help-echo>
<escape> x r e p o r t - e m a c s - b u g <return
 >

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark set

Load-path shadows:
/home/jhd/src/emacs/trunk/leim/leim-list hides 
/home/jhd/src/emacs/obj-motif/leim/leim-list

Features:
(shadow sort gnus-util mail-extr message sendmail regexp-opt rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils
gmm-utils mailheader emacsbug tooltip ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev loaddefs button minibuffer faces cus-face files text-properties
overlay md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
dynamic-setting system-font-setting font-render-setting motif x-toolkit
x multi-tty emacs)


[-- Attachment #2: left.png --]
[-- Type: image/png, Size: 691 bytes --]

[-- Attachment #3: right.png --]
[-- Type: image/png, Size: 814 bytes --]

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[Jan Djärv]

FWIW, I see that the 23-branch has some fringe patches that trunk hasn't.  But 
the same problem is in the 23-branch.

	Jan D.

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[Stephen Berman]

On Fri, 09 Jul 2010 13:49:28 +0200 "Jan D." <jhdgoo@gmail.com> wrote:

> Notice that the fringe close to scroll bar is much wider than the other
> fringe (see screenshot).  This appears to depend on the font size, as
> for smaller fonts, the effect is not that noticable.
> For example, with Gtk+ and lucid, monospace-19 shows this rather well,
> but for monospace-20, there is little difference.  But for monospace-20
> the fringes are much smaller than for monospace-20.  Why?

Hasn't it been like that since this change?

2007-07-27  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>

	* w32term.c (w32_draw_fringe_bitmap): Extend fringe background to
	scroll bar gap.
	(x_scroll_bar_create): Set bar->fringe_extended_p.
	(w32_set_vertical_scroll_bar): Put leftmost/rightmost scroll bars
	on frame edge.  Check fringe background extension.  Don't clear
	extended fringe background area.

	* w32term.h (struct scroll_bar): New member fringe_extended_p.
	(w32_fill_area): Enclose multiple statements with do ... while (0).

	* xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
	Extend fringe background to scroll bar gap.
	(x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS]:
	Set bar->fringe_extended_p.
	(XTset_vertical_scroll_bar) [USE_TOOLKIT_SCROLL_BARS]:
	Put leftmost/rightmost scroll bars on frame edge.  Check fringe
	background extension.  Don't clear extended fringe background area.

	* xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS]:
	New member fringe_extended_p.

Steve Berman

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[YAMAMOTO Mitsuharu]

>>>>> On Fri, 09 Jul 2010 20:49:31 +0200, Stephen Berman <stephen.berman@gmx.net> said:

> On Fri, 09 Jul 2010 13:49:28 +0200 "Jan D." <jhdgoo@gmail.com>
> wrote:
>> Notice that the fringe close to scroll bar is much wider than the
>> other fringe (see screenshot).  This appears to depend on the font
>> size, as for smaller fonts, the effect is not that noticable.  For
>> example, with Gtk+ and lucid, monospace-19 shows this rather well,
>> but for monospace-20, there is little difference.  But for
>> monospace-20 the fringes are much smaller than for monospace-20.
>> Why?

> Hasn't it been like that since this change?

> 2007-07-27 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>

Exactly.  For more info, see the thread starting from 
http://lists.gnu.org/archive/html/emacs-devel/2007-03/msg00295.html

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[Jan Djärv]

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]



YAMAMOTO Mitsuharu skrev 2010-07-10 02.42:
>>>>>> On Fri, 09 Jul 2010 20:49:31 +0200, Stephen Berman<stephen.berman@gmx.net>  said:
>
>> On Fri, 09 Jul 2010 13:49:28 +0200 "Jan D."<jhdgoo@gmail.com>
>> wrote:
>>> Notice that the fringe close to scroll bar is much wider than the
>>> other fringe (see screenshot).  This appears to depend on the font
>>> size, as for smaller fonts, the effect is not that noticable.  For
>>> example, with Gtk+ and lucid, monospace-19 shows this rather well,
>>> but for monospace-20, there is little difference.  But for
>>> monospace-20 the fringes are much smaller than for monospace-20.
>>> Why?
>
>> Hasn't it been like that since this change?
>
>> 2007-07-27 YAMAMOTO Mitsuharu<mituharu@math.s.chiba-u.ac.jp>
>
> Exactly.  For more info, see the thread starting from
> http://lists.gnu.org/archive/html/emacs-devel/2007-03/msg00295.html
>

There is something off with the calculations for the frame size then.  Check 
attached screen shots.  The right fringe is not visible.

The frame size calculation uses f->scroll_bar_actual_width which in this case 
is 16.  But the finge padding must be 14 pixels (font width is 15, so I assume 
padding to 30 is done).

In what frame parameter or struct frame member is this padding seen if not in 
scroll_bar_actual_width?

Please don't suggest using columns * font width, it would just make the 
restriction of integral font width harder to remove.

	Jan D.



[-- Attachment #2: left2.png --]
[-- Type: image/png, Size: 4020 bytes --]

[-- Attachment #3: right2.png --]
[-- Type: image/png, Size: 4670 bytes --]

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[YAMAMOTO Mitsuharu]

>>>>> On Sat, 10 Jul 2010 11:03:08 +0200, Jan Djärv <jan.h.d@swipnet.se> said:

>>> Hasn't it been like that since this change?
>> 
>>> 2007-07-27 YAMAMOTO Mitsuharu<mituharu@math.s.chiba-u.ac.jp>
>> 
>> Exactly.  For more info, see the thread starting from
>> http://lists.gnu.org/archive/html/emacs-devel/2007-03/msg00295.html
>> 

> There is something off with the calculations for the frame size
> then.  Check attached screen shots.  The right fringe is not
> visible.

The change I made in 2007-07-27 has nothing to do with the calculation
of fringe width, the position of fringes, or frame size calculation.
It just fills the gap between a fringe and a scroll bar with the
fringe background color when appropriate.  The gap is still a part of
scroll bar area painted by the same color with the adjacent fringe
background.  So if something is wrong with frame size calculation,
then that should have happened without my change.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[Jan Djärv]

YAMAMOTO Mitsuharu skrev 2010-07-11 05.48:
>>>>>> On Sat, 10 Jul 2010 11:03:08 +0200, Jan Djärv<jan.h.d@swipnet.se>  said:
>
>>>> Hasn't it been like that since this change?
>>>
>>>> 2007-07-27 YAMAMOTO Mitsuharu<mituharu@math.s.chiba-u.ac.jp>
>>>
>>> Exactly.  For more info, see the thread starting from
>>> http://lists.gnu.org/archive/html/emacs-devel/2007-03/msg00295.html
>>>
>
>> There is something off with the calculations for the frame size
>> then.  Check attached screen shots.  The right fringe is not
>> visible.
>
> The change I made in 2007-07-27 has nothing to do with the calculation
> of fringe width, the position of fringes, or frame size calculation.
> It just fills the gap between a fringe and a scroll bar with the
> fringe background color when appropriate.  The gap is still a part of
> scroll bar area painted by the same color with the adjacent fringe
> background.  So if something is wrong with frame size calculation,
> then that should have happened without my change.

That is true.  I see your patch uses WINDOW_CONFIG_SCROLL_BAR_WIDTH, and there 
is a corresponding FRAME_CONFIG_SCROLL_BAR_WIDTH, but that is never set.

However, I think that scroll bars at the frame level (i.e. left or right edge 
of the frame) don't need any padding.  It is only on other window scroll bars
that padding is needed, to keep integral column width.

I'll try something based on that.

	Jan D.

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[YAMAMOTO Mitsuharu]

>>>>> On Sun, 11 Jul 2010 10:15:54 +0200, Jan Djärv <jan.h.d@swipnet.se> said:

> However, I think that scroll bars at the frame level (i.e. left or
> right edge of the frame) don't need any padding.  It is only on
> other window scroll bars that padding is needed, to keep integral
> column width.

Even for a leftmost/rightmost scroll bar, some adjustment is necessary
if its width/position is configured differently from what the frame
parameter specifies (scroll bar width/position can be specified per
frame, per buffer, and per window).  Perhaps the current fringe
background extension code can be reused for such cases.

> I'll try something based on that.

Good luck!

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#6592: 24.0.50; Fringe at scroll bar side is wider (sometimes).

[Jan Djärv]

Simple fix checked in.  Complete solution (remove scroll bar width 
restriction) is a longer undertaking.

	Jan D.