bug#6499: 23.1; Emacs gets stuck waiting for menu input

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Marius Kjeldahl]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

When clicking the menu-bar (enabled by default on Ubuntu Lucid) to the
right of any menu choices (typically to activate the window), emacs
will remain "stuck" not allowing any more input until you actually
activate one of the menus.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
     `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.0)
  of 2010-03-29 on yellow, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.10706000
configured using `configure  '--build=x86_64-linux-gnu' 
'--host=x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' 
'--libexecdir=/usr/lib' '--localstatedir=/var/lib' 
'--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' 
'--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' 
'--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 
'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 
'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: en_US.utf8
   value of $XMODIFIERS: nil
   locale-coding-system: utf-8-unix
   default-enable-multibyte-characters: t

Major mode: Haml

Minor modes in effect:
   recentf-mode: t
   show-paren-mode: t
   display-time-mode: t
   global-hl-line-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   global-auto-composition-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   column-number-mode: t
   line-number-mode: t
   transient-mark-mode: t

Recent input:
<left> <left> <left> <left> <left> <left> <left> <left>
/ j q u i a p p / M-d M-d <right> <right> <right> M-d
J Q A u e <backspace> <backspace> <backspace> u e r
y U I C-k SPC A p p C-x C-s C-x C-f j q <tab> u <tab>
a <tab> j q <tab> c s <tab> <return> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <up> <up> <up> <up> C-a C-SPC
<down> M-w C-y <up> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <M-backspace>
f i r e f o x C-x C-s <M-backspace> m o z i l l a C-x
C-s C-a C-SPC <down> M-w C-y <up> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <M-backspace> <backspace> C-x C-s C-x C-s <up>
<up> <up> <up> <up> C-a C-SPC <down> M-w C-y C-y <up>
<up> <right> <right> <right> <right> <right> <right>
<right> <right> <M-backspace> C-d m o z <down> <right>
<right> <right> <right> <M-backspace> <backspace> C-x
C-s <down> <down> <down> <down> <right> <right> <right>
<right> M-d <down> <left> C-x C-s C-x 3 <help-echo>
<help-echo> <help-echo> <help-echo> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <up> <up> <up> <up> <up> <up> <up> <down> <down>
<down> C-x b <return> <up> <up> <up> <up> <down> <down>
<down> <down> M-x r e p o r t - e m a c s - b u g
<return>

Recent messages:
Mark set
Saving file /home/marius/p/stockapp/wwwroot/jquiapp/jquiapp.css...
Wrote /home/marius/p/stockapp/wwwroot/jquiapp/jquiapp.css
(No changes need to be saved)
Mark set [3 times]
Saving file /home/marius/p/stockapp/wwwroot/jquiapp/jquiapp.css...
Wrote /home/marius/p/stockapp/wwwroot/jquiapp/jquiapp.css
Saving file /home/marius/p/stockapp/wwwroot/jquiapp/jquiapp.css...
Wrote /home/marius/p/stockapp/wwwroot/jquiapp/jquiapp.css
/usr/bin/mail is not an executable.  Setting mail-interactive to t.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Glenn Morris]

Marius Kjeldahl wrote:

> When clicking the menu-bar (enabled by default on Ubuntu Lucid) to the
> right of any menu choices (typically to activate the window), emacs
> will remain "stuck" not allowing any more input until you actually
> activate one of the menus.
[...]
> In GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.0)
>  of 2010-03-29 on yellow, modified by Debian

Problems with menus in 23.1 with recent GTK versions are likely to be
duplicates of

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4122

Please try Emacs 23.2, where this should be fixed.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Jan Djärv]

Marius Kjeldahl skrev 2010-06-23 10.17:
>
>
> When clicking the menu-bar (enabled by default on Ubuntu Lucid) to the
> right of any menu choices (typically to activate the window), emacs
> will remain "stuck" not allowing any more input until you actually
> activate one of the menus.
>

This bug does not exist in Emacs 23.2.  Can you upgrade to that version?

	Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Tobias Bading]

Hi Jan,

nope, no cigar. I tried your patch against trunk r100684 and it indeed 
solves the reported bug, but it causes even worse problems for me (GNU 
Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) on 
Ubuntu Lucid). Now clicking on an item in the menu bar will pop up the 
menu properly only every n-th try. The other times the menu closes as 
soon as I release the mouse button :-(.

Regards,
Tobias

PS: Please don't ask me to check with a newer trunk revision, unless 
someone can confirm that at least a simple click works again in the head 
revision without setting the mark. At least double clicks work again, I 
guess that's a start... ;-)


On 03.07.2010 11:49, Jan Djärv wrote:
> (Please don't remove the ddebugs.gnu.org address).
>
> I don't know why I didn't see this before, I must have done something else.
> It is present in 23.2 also.
>
> I've made a fix in the emacs-23 branch (to be released as 23.3), it
> should propagate to the trunk after a while.
>
> Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Tobias Bading]

Hi,

could someone please reopen bug #6499? IMHO this hasn't been fixed yet. 
I just tried trunk r100830 and Jan's patch from the emacs-23 branch has 
made it into the trunk, causing the following side-effect:
A menu does not stay open when you click on a menu bar item, instead it 
vanishes as soon as you release the mouse button. This happens most of 
the time, sometimes the menu stays open. Depending on how you move your 
mouse while the button is down, you can even manage to reproduce the 
original bug.

Thanks,
Tobias

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Sven Joachim]

reopen 6499 
thanks

On 2010-07-16 12:05 +0200, Tobias Bading wrote:

> Hi,
>
> could someone please reopen bug #6499? IMHO this hasn't been fixed
> yet. I just tried trunk r100830 and Jan's patch from the emacs-23
> branch has made it into the trunk, causing the following side-effect:
> A menu does not stay open when you click on a menu bar item, instead
> it vanishes as soon as you release the mouse button.

This is indeed very annoying.  I'm reopening the bug as the cure seems
worse than the disease.

Sven

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Jan Djärv]

Tobias Bading skrev 2010-07-16 12.05:
> Hi,
>
> could someone please reopen bug #6499? IMHO this hasn't been fixed yet. I just
> tried trunk r100830 and Jan's patch from the emacs-23 branch has made it into
> the trunk, causing the following side-effect:

The patch is not in trunk, 100830 fixed 6645.  It is not in trunk 100831 either.

Please learn to use bzr log.  It tells you which bugs have been fixed.

	Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Jan Djärv]

Sven Joachim skrev 2010-07-16 12.50:
> reopen 6499
>
> This is indeed very annoying.  I'm reopening the bug as the cure seems
> worse than the disease.
>

Don't do this unless you are absolutley sure the bug fix is in, which in this 
case it isn't.  This is the trunk.  If you can't stand breakage, sometimes for 
several weeks, use a stable release.  This is getting silly.

	Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Tobias Bading]

On 16.07.2010 14:48, Jan Djärv wrote:
 > Tobias Bading skrev 2010-07-16 12.05:
 >> Hi,
 >>
 >> could someone please reopen bug #6499? IMHO this hasn't been fixed
 >> yet. I just
 >> tried trunk r100830 and Jan's patch from the emacs-23 branch has made
 >> it into
 >> the trunk, causing the following side-effect:
 >
 > The patch is not in trunk, 100830 fixed 6645. It is not in trunk 100831
 > either.
 >
 > Please learn to use bzr log. It tells you which bugs have been fixed.
 >
 > Jan D.

Dear Jan,

granted, I'm more of a Subversion user than a Bazaar user, but I think 
I'm very much able to interpret what bzr is telling me. Maybe my 
sentence "I just tried trunk r100830 and Jan's patch from the emacs-23 
branch has made it into the trunk" wasn't clear. I did NOT apply
r100830 to an older revision of the trunk, I compiled the trunk as it 
is/was in r100830. If my interpretation of "bzr log --include-merges 
src/xmenu.c" as well as an annotate operation on src/xmenu.c in Emacs is 
correct, your patch IS in the trunk. It got there through Chong Yidong's 
merge in r100770.

Regards,
Tobias

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Tobias Bading]

On 16.07.2010 14:50, Jan Djärv wrote:
> Sven Joachim skrev 2010-07-16 12.50:
>> reopen 6499
>>
>> This is indeed very annoying. I'm reopening the bug as the cure seems
>> worse than the disease.
>>
>
> Don't do this unless you are absolutley sure the bug fix is in, which in
> this case it isn't. This is the trunk. If you can't stand breakage,
> sometimes for several weeks, use a stable release. This is getting silly.
>
> Jan D.

Jan,

I don't know what policy the Emacs developers have agreed upon regarding 
the trunk, but all projects I've been working for so far probably would 
not accept a "If you can't stand breakage, sometimes for several weeks, 
use a stable release." attitude. Usually, extensive work is done on 
branches, especially if it stands a good chance of breaking stuff. But 
maybe the Emacs devs have agreed upon another policy...

Anyway, your patch causes more problems for me than it solves. That 
might be a problem of my specific Ubuntu configuration, GTK version or 
whatever. Would you at least be so kind to comment on that? Since you 
closed the bug again, you seem to be damn sure that your bug is fine and 
has no negative side-effects whatsoever.

Regards,
Tobias

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Jan Djärv]

Tobias Bading skrev 2010-07-16 15.22:

> Dear Jan,
>
> granted, I'm more of a Subversion user than a Bazaar user, but I think I'm
> very much able to interpret what bzr is telling me. Maybe my sentence "I just
> tried trunk r100830 and Jan's patch from the emacs-23 branch has made it into
> the trunk" wasn't clear. I did NOT apply
> r100830 to an older revision of the trunk, I compiled the trunk as it is/was
> in r100830. If my interpretation of "bzr log --include-merges src/xmenu.c" as
> well as an annotate operation on src/xmenu.c in Emacs is correct, your patch
> IS in the trunk. It got there through Chong Yidong's merge in r100770.

The current patch wasn't even written when that merge was done.  That is the 
old patch that had problems.

	Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Jan Djärv]

Tobias Bading skrev 2010-07-16 15.33:

> Anyway, your patch causes more problems for me than it solves. That might be a
> problem of my specific Ubuntu configuration, GTK version or whatever. Would
> you at least be so kind to comment on that? Since you closed the bug again,
> you seem to be damn sure that your bug is fine and has no negative
> side-effects whatsoever.

I'm 100% sure you are mistaken about the patch being in trunk yet.

	Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Jan Djärv]

FWIW, this is the change log to look out for:

2010-07-14  Jan Djärv  <jan.h.d@swipnet.se>

         * xterm.h (x_menubar_window_to_frame): Second parameter is XEvent*.

         * xterm.c (handle_one_xevent): Pass event to x_menubar_window_to_frame.

         * xmenu.c (x_activate_menubar): Revert previous fix for Bug#6499,
         i.e. don't put back ButtonRelease (Bug#6608).

         * xfns.c (x_menubar_window_to_frame): Take XEvent as second parameter
         instead of Window.  Call xg_event_is_for_menubar when
         USE_GTK (Bug#6499).

         * gtkutil.h (xg_event_is_for_menubar): Declare.

         * gtkutil.c (xg_event_is_for_menubar): New function (Bug#6499).



	Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Sven Joachim]

On 2010-07-16 14:50 +0200, Jan Djärv wrote:

> Sven Joachim skrev 2010-07-16 12.50:
>> reopen 6499
>>
>> This is indeed very annoying.  I'm reopening the bug as the cure seems
>> worse than the disease.
>>
>
> Don't do this unless you are absolutley sure the bug fix is in, which
> in this case it isn't.  This is the trunk.  If you can't stand
> breakage, sometimes for several weeks, use a stable release.  This is
> getting silly.

Actually I'm using the emacs-23 branch rather than the trunk, but was
not up to date, so I missed the fix for bug #6608.  Sorry for the noise.

Regards,
        Sven

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Chong Yidong]

Jan Djärv <jan.h.d@swipnet.se> writes:

> 2010-07-14  Jan Djärv  <jan.h.d@swipnet.se>
>
> * xterm.h (x_menubar_window_to_frame): Second parameter is XEvent*.
>
> * xterm.c (handle_one_xevent): Pass event to x_menubar_window_to_frame.
>
> * xmenu.c (x_activate_menubar): Revert previous fix for Bug#6499,
> i.e. don't put back ButtonRelease (Bug#6608).
>
> * xfns.c (x_menubar_window_to_frame): Take XEvent as second parameter
> instead of Window.  Call xg_event_is_for_menubar when
> USE_GTK (Bug#6499).
>
> * gtkutil.h (xg_event_is_for_menubar): Declare.
>
> * gtkutil.c (xg_event_is_for_menubar): New function (Bug#6499).

There is a problem with this change:

1. emacs -Q
2. Click (mouse-1) on any part of the buffer.
   If necessary, do this a couple more times

The result is that the tool-bar grabs focus.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Jan Djärv]

Chong Yidong skrev 2010-07-17 06.07:

>
> There is a problem with this change:
>
> 1. emacs -Q
> 2. Click (mouse-1) on any part of the buffer.
>     If necessary, do this a couple more times
>
> The result is that the tool-bar grabs focus.

Fixed now, in emacs-23 branch.  Expect trunk to be broken until this gets merged.

BTW, I see ChangeLog entries in trunk is not in date order, is this to be 
expected now?

	Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Eli Zaretskii]

> Date: Sat, 17 Jul 2010 12:02:26 +0200
> From: Jan Djärv <jan.h.d@swipnet.se>
> Cc: Tobias Bading <tbading@web.de>, Sven Joachim <svenjoac@gmx.de>,
> 	Marius Kjeldahl <marius@kjeldahl.net>, 6499@debbugs.gnu.org
> 
> BTW, I see ChangeLog entries in trunk is not in date order, is this to be 
> expected now?

I think the merged log entries should be rewritten to have all their
dates be the date of the merge.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Chong Yidong]

Jan Djärv <jan.h.d@swipnet.se> writes:

> Fixed now, in emacs-23 branch.  Expect trunk to be broken until this
> gets merged.

Thanks for the fast response.  I've merged your fix into the trunk
(since it is interfering with testing on the selection changes).

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Jan Djärv]

Chong Yidong skrev 2010-07-17 16.46:
> Jan Djärv<jan.h.d@swipnet.se>  writes:
>
>> Fixed now, in emacs-23 branch.  Expect trunk to be broken until this
>> gets merged.
>
> Thanks for the fast response.  I've merged your fix into the trunk
> (since it is interfering with testing on the selection changes).

Nice, I will fix up the Gtk3 stuff ASAP.

	Jan D.

bug#6499: 23.1; Emacs gets stuck waiting for menu input

[Stefan Monnier]

>> BTW, I see ChangeLog entries in trunk is not in date order, is this to be 
>> expected now?
> I think the merged log entries should be rewritten to have all their
> dates be the date of the merge.

Indeed, tho it's easy to forget and/or miss some.


        Stefan