unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Lynn Winebarger <owinebar@gmail.com>
Cc: 5938-done@debbugs.gnu.org
Subject: bug#5938: Unnecessary fail when XGetVisualInfo returns multiple records
Date: Mon, 12 Apr 2010 21:01:10 +0200	[thread overview]
Message-ID: <4BC36DF6.3020305@swipnet.se> (raw)
In-Reply-To: <o2v3759e04c1004120754md70b3321vd703dadb0592cfa0@mail.gmail.com>

Lynn Winebarger skrev:
> Package: emacs
> Version: 23.1.50; 23.1.1; 22.2.1
> 
> When invoking emacs on a remote session using Xephyr, it responds
> emacs: Can't get proper X visual info
> In version 22 there is a newline after the message, in version 23
> there is no newline.
> 
> I've traced the problem to the function select_visual in the file xfns.c.  If
> the resource database does not specify a preference, it attempts to use
> the default visual by getting a screen number and visual id from the supplied
> dpyinfo structure.
> 
> For some reason Xephyr returns multiple records corresponding to the
> same visual id.
> This shows up in xpdyinfo as well, output at the end of this email.
> The default id is 0x21,
> and there are two identical entries for it.  Every other visual id has
> a single record.

It sounds like a bug to return two identical visuals, I haven't seen that widh 
Xephyr.  But in any case, Emacs should not abort.  On the whole, the whole 
checking of visual is kind of redundant anyway, DefaultVisualOfScreen shall 
always exist.

Fix checked in.

	Jan D.







      reply	other threads:[~2010-04-12 19:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-12 14:54 bug#5938: Unnecessary fail when XGetVisualInfo returns multiple records Lynn Winebarger
2010-04-12 19:01 ` Jan Djärv [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC36DF6.3020305@swipnet.se \
    --to=jan.h.d@swipnet.se \
    --cc=5938-done@debbugs.gnu.org \
    --cc=owinebar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).