unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Colascione <dan.colascione@gmail.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 5586@debbugs.gnu.org, Paul Pogonyshev <pogonyshev@gmx.net>
Subject: bug#5586: 23.1.92.1; Electric indentation and hungry backspace deletion in JavaScript mode (js-mode)
Date: Sun, 28 Mar 2010 16:58:49 -0400	[thread overview]
Message-ID: <4BAFC309.70701@gmail.com> (raw)
In-Reply-To: <87aatsuqbu.fsf@stupidchicken.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/28/10 4:46 PM, Chong Yidong wrote:
> I am still not happy about the way it's implemented in either mode---I
> think Emacs needs some kind of centralized mechanism for this---but that
> is a longer-term project.  

The chief difficulty I see is that in some modes, indentation isn't
idempotent: if you ran indent-line-function from some generic electric
code, it might change the indentation of the current line in unwanted
ways. (Imagine python-mode, where indent-line-function cycles through
feasible indentation levels for a given line.)

At best, modes would have to opt-in, and if each mode needs some glue
anyway, why not just let each mode handle electric characters itself?

> In the meantime, I've restored the deleted
> code in the branch.

Thanks.

> One difference, however, is that espresso-mode did electric punctuation
> for `+-.'.  I didn't restore this yet, since CC mode does not do
> electric punctuation for these characters.  Is there any reason we need
> to do this specially for Javascript?

There's no particular reason, no. The cc-mode set of electric characters
is probably fine.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)

iEYEARECAAYFAkuvwwkACgkQ17c2LVA10VtXIACgmgSYoR4WMmxkOF4l7QoEATYQ
b8oAoNwNRjoQvMSkmd6gWIyNy/8IZBnW
=8XTU
-----END PGP SIGNATURE-----






  reply	other threads:[~2010-03-28 20:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 22:31 bug#5586: 23.1.92.1; Electric indentation and hungry backspace deletion in JavaScript mode (js-mode) Paul Pogonyshev
2010-03-26  5:03 ` Daniel Colascione
2010-03-28 20:46 ` Chong Yidong
2010-03-28 20:58   ` Daniel Colascione [this message]
2010-03-28 22:37     ` Lennart Borgman
2010-03-29  1:49     ` Stefan Monnier
2010-03-28 20:59   ` Daniel Colascione
2017-08-07  0:25 ` bug#5586: is this bug still valid? Tom Tromey
2022-01-31 17:08   ` bug#5586: 23.1.92.1; Electric indentation and hungry backspace deletion in JavaScript mode (js-mode) Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BAFC309.70701@gmail.com \
    --to=dan.colascione@gmail.com \
    --cc=5586@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=pogonyshev@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).