From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#69709: `sort` interface improvement and universal ordering predicate Date: Sat, 23 Mar 2024 15:58:52 +0100 Message-ID: <4B7ACA81-DEB9-4878-BE0B-88A302AF7081@gmail.com> References: <86zfv6uqjn.fsf@gnu.org> <4391448A-C7AF-4D7F-8866-C0313956D52D@gmail.com> <8366111E-97C4-4839-AA1E-A577C81A6035@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20847"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69709@debbugs.gnu.org, Gerd =?UTF-8?Q?M=C3=B6llmann?= , Eli Zaretskii , Stefan Monnier To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 23 16:00:43 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ro2rS-0005Be-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Mar 2024 16:00:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ro2rA-00061A-QQ; Sat, 23 Mar 2024 11:00:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ro2r7-00060N-6h for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2024 11:00:22 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ro2r6-0006m2-KK for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2024 11:00:20 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ro2rl-0004Mz-Pf for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2024 11:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Mar 2024 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69709 X-GNU-PR-Package: emacs Original-Received: via spool by 69709-submit@debbugs.gnu.org id=B69709.171120604514963 (code B ref 69709); Sat, 23 Mar 2024 15:01:01 +0000 Original-Received: (at 69709) by debbugs.gnu.org; 23 Mar 2024 15:00:45 +0000 Original-Received: from localhost ([127.0.0.1]:34226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ro2rU-0003sF-PJ for submit@debbugs.gnu.org; Sat, 23 Mar 2024 11:00:45 -0400 Original-Received: from mail-lf1-f45.google.com ([209.85.167.45]:44462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ro2rR-0003ZP-TY for 69709@debbugs.gnu.org; Sat, 23 Mar 2024 11:00:43 -0400 Original-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-512e4f4e463so3355260e87.1 for <69709@debbugs.gnu.org>; Sat, 23 Mar 2024 08:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711205935; x=1711810735; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=pn3d64fHXjug0/4/epV6s8CH4TLSzwP8CE+GPPOOLIE=; b=D29zd/vpd4PD6ytJI45ociyBP2dv2lJ7QNsP0G/DcQtvoyQmvtxW0PZI5uZ7jEvVq4 qPx59fbxZnMmrAqlTKGoDnwxO+DRSE95NOjyOVU62mAIAGkPPnKzwgWrllKtBYWtLXcK wrQqMr54WGoO0PMbs/mFni/XPlWsPVYQsJnY5vVA4XmYoH3Aai6WaK7bL/NTv1mOKRt8 DDqfmjy+bOkbjyuDCBOeWUxQ0nCgNRN8T/qIu6r8gbj5lUoF2z7h/IhqlWDNZoMaIPG+ hR3xAln+ENgEPcUUBkkzYO5kU1ivN/kAipRUGluCnsExzG4u0liWKksYswOyj8c7OCGZ 6qGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711205935; x=1711810735; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pn3d64fHXjug0/4/epV6s8CH4TLSzwP8CE+GPPOOLIE=; b=FiMPAt4wHqaemQtfq9aZJMqAuTJl4kBMBctcGIRSGQzCbECWYlZIP7tPbhB76Y8e+b PyCnggrB2TKE438hhDm8SmFDT2oNbmkD3MtiK2LcIwbxPD+0LCWUqxWPrFCDa6qV+ZAY 4KUbG5DlIJGH7f/v6yqK+wwogIaBi6zwY1UJE4Ix3CYCkhqY/L5y7EpaOa8G8I/6gDFr uGtfAQ5y4SnfIwTA9tNmKPJi212bZlxU0nOh8xIQzjOqlCkjmKkBNZls13JvoikCEF4C 8Ejh7URVtjkE83QCTg4OwDCC/TAVIsc4RVhsLFIN+zpq/7bttrdgkKVMYkAEEI7ELkwW qxUw== X-Forwarded-Encrypted: i=1; AJvYcCXuhvzmDS5/gNLD6YV9xcZSHCb3CeuijLVsLXRdwU71CQJwfGZu8u1yGxJkfcMQdBgTVfB4xhNzA3xbDHBVEOZJk0KjocE= X-Gm-Message-State: AOJu0YwaT+kew5Fo5Na8ktfaetAg1zMHz1ClyZEGryZJlbCbLz6yjN9l DwCl9BMdGa8fO9aZbTbV6+KKdXmrfHCt+JGXqwtRzGJPrpTHAR7b X-Google-Smtp-Source: AGHT+IEPVbfh2M+6VftrWYDYgWsSyxWg1B1Wyw9qDkDRJcWMWb2nEyrBj1kHZbVEIriulgI/qzq+mA== X-Received: by 2002:a05:6512:3126:b0:513:bc63:3451 with SMTP id p6-20020a056512312600b00513bc633451mr1557544lfd.43.1711205934288; Sat, 23 Mar 2024 07:58:54 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z8-20020ac25de8000000b005158c44d8cesm316280lfq.70.2024.03.23.07.58.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2024 07:58:53 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281986 Archived-At: 22 mars 2024 kl. 21.55 skrev Dmitry Gutov : > :in-place is not too bad. Thank you, I'm going with :in-place because :destructive puts emphasis = on the wrong aspect. Sorting in-place has predictable and useful = side-effects, in contrast to the old (pre-timsort) implementation that = garbled the input list. But non-destructive should definitely be the default. All my own = experience (and from observations, that of other people) shows that it's = far less error-prone. This applies to other languages as well, even very = imperative ones like Python. The branch scratch/sort-key has been updated with polished changes, = including updates of the Lisp manual. `value-less-p` is now called `value<`. (We could still unify it with = `<`, perhaps.) A small tweak to the implementation of non-destructive list sorting gave = a speed-up of 1.1x-1.5x, which was surprisingly good. The old code just = called copy-sequence on the input. An even bigger boost was gained from special-casing the ordering = predicate `value<`: 1.5x-2x speed-up on practically all input. This = alone could be worth all the trouble with the patch series. We could do = even better by special-casing on common key types, such as fixnums.