From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Dmitry Gutov <dmitry@gutov.dev>,
theo@thornhill.no, marius.kjeldahl@gmail.com,
74386@debbugs.gnu.org
Subject: bug#74386: Tree-sitter javascript indentation
Date: Sat, 30 Nov 2024 21:23:22 -0800 [thread overview]
Message-ID: <4B4B99E7-C4A1-4124-BC85-2AD66EF0871B@gmail.com> (raw)
In-Reply-To: <86r06t82gl.fsf@gnu.org>
> On Nov 30, 2024, at 2:01 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Cc: 74386@debbugs.gnu.org, Theodor Thornhill <theo@thornhill.no>
>> Date: Mon, 18 Nov 2024 17:29:18 +0200
>> From: Dmitry Gutov <dmitry@gutov.dev>
>>
>> On 18/11/2024 10:35, Marius Kjeldahl wrote:
>>> Can confirm your patch solves both the variants I showed. This will
>>> also help me to dig into and understand more of what is going on, and
>>> allows me to experiment more with my preferences (and tree-sitter in
>>> general). So thank you very much.
>>
>> Great!
>>
>> For more experimenting, also check out 'M-x treesit-explore-mode'.
>>
>> And here's how to immediately find out which indentation rule was used:
>>
>> (setq treesit--indent-verbose t)
>
> Theo, please chime in. Should Dmitry install his changes?
The standalone-parent anchor is designed specifically to solve the bug described here, and changing parent-bol to standalone-parent is very safe. So IMO we can merge this (either to emacs-30 or master).
Yuan
next prev parent reply other threads:[~2024-12-01 5:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 23:26 bug#74386: Tree-sitter javascript indentation Marius Kjeldahl
2024-11-17 19:18 ` Dmitry Gutov
2024-11-17 19:21 ` Marius Kjeldahl
2024-11-17 22:12 ` Dmitry Gutov
2024-11-17 22:21 ` Marius Kjeldahl
2024-11-17 22:41 ` Dmitry Gutov
2024-11-18 8:35 ` Marius Kjeldahl
2024-11-18 15:29 ` Dmitry Gutov
2024-11-30 10:01 ` Eli Zaretskii
2024-12-01 5:23 ` Yuan Fu [this message]
2024-12-01 13:11 ` Dmitry Gutov
2024-12-01 19:10 ` Yuan Fu
2024-12-01 22:33 ` Dmitry Gutov
2024-12-02 2:31 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4B99E7-C4A1-4124-BC85-2AD66EF0871B@gmail.com \
--to=casouri@gmail.com \
--cc=74386@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=marius.kjeldahl@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).