From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#4543: window-full-height-p Date: Sat, 26 Sep 2009 11:45:41 +0200 Message-ID: <4ABDE2C5.2070808@gmx.at> References: <4ABB19F5.50908@gmx.at> <4ABC73DB.1060308@gmx.at> <83vdj7tlup.fsf@gnu.org> <4ABCBEC7.70901@gmx.at> Reply-To: martin rudalics , 4543@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1253959650 5359 80.91.229.12 (26 Sep 2009 10:07:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Sep 2009 10:07:30 +0000 (UTC) Cc: 4543@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 26 12:07:22 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MrUBV-0004L2-36 for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Sep 2009 12:07:22 +0200 Original-Received: from localhost ([127.0.0.1]:36885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrUBU-0008Iw-73 for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Sep 2009 06:07:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MrUBO-0008Im-Iv for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 06:07:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MrUBJ-0008IR-KJ for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 06:07:13 -0400 Original-Received: from [199.232.76.173] (port=59464 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrUBJ-0008IO-B8 for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 06:07:09 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:55435) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MrUBI-0004fX-Nr for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 06:07:09 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8QA750R008820; Sat, 26 Sep 2009 03:07:06 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8Q9o5aw005136; Sat, 26 Sep 2009 02:50:05 -0700 Resent-Date: Sat, 26 Sep 2009 02:50:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 26 Sep 2009 09:50:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4543 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4543-submit@emacsbugs.donarmstrong.com id=B4543.12539583504577 (code B ref 4543); Sat, 26 Sep 2009 09:50:05 +0000 Original-Received: (at 4543) by emacsbugs.donarmstrong.com; 26 Sep 2009 09:45:50 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8Q9jmf6004574 for <4543@emacsbugs.donarmstrong.com>; Sat, 26 Sep 2009 02:45:50 -0700 Original-Received: (qmail invoked by alias); 26 Sep 2009 09:45:42 -0000 Original-Received: from 62-47-36-64.adsl.highway.telekom.at (EHLO [62.47.36.64]) [62.47.36.64] by mail.gmx.net (mp069) with SMTP; 26 Sep 2009 11:45:42 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1981G0R3eV8rAfHJ39dhMiUizHLT8pFwy/aUVtWMC eybViFxUJ/8Ee2 User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 26 Sep 2009 06:07:13 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31529 Archived-At: Stefan Monnier schrieb: >> #define FRAME_TOTAL_COLS_ARG(f, width) \ >> ((width) \ >> + FRAME_SCROLL_BAR_COLS (f) \ >> + FRAME_FRINGE_COLS (f)) >> and > >> #define FRAME_SCROLL_BAR_COLS(f) \ >> (FRAME_HAS_VERTICAL_SCROLL_BARS (f) \ >> ? FRAME_CONFIG_SCROLL_BAR_COLS (f) \ >> : 0) > >> etc ... What are the scrollbars of a frame, I'm asking myself. > > I agree it's rather odd to see such window properties counted > for frames. There's probably some ugly counter-balancing calculations > in the window-size code. I doubt that. The window-size code handles scroll bars and fringes on a per window/buffer basis and fits them (recursively) within the size it's given by change_frame_size_1 as set_window_width (FRAME_ROOT_WINDOW (f), new_frame_total_cols, 2); So whether and how scroll bars and/or fringes are displayed ignores anything done in change_frame_size_1. The problem I see is that the value for new_frame_total_cols calculated by change_frame_size_1 as /* Compute width of windows in F. This is the width of the frame without vertical scroll bars. */ new_frame_total_cols = FRAME_TOTAL_COLS_ARG (f, newwidth); /* Round up to the smallest acceptable size. */ check_frame_size (f, &newheight, &newwidth); doesn't make sense for more complex window configurations. I'm not sure, however, whether text-only terminals inherently rely on these calculations. So the question I essentially ask is whether the number of total columns of a frame's root-window invariantly equals the width of that frame over all possible terminals. martin