From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#4543: window-full-height-p Date: Fri, 25 Sep 2009 14:59:51 +0200 Message-ID: <4ABCBEC7.70901@gmx.at> References: <4ABB19F5.50908@gmx.at> <4ABC73DB.1060308@gmx.at> <83vdj7tlup.fsf@gnu.org> Reply-To: martin rudalics , 4543@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1253884130 10425 80.91.229.12 (25 Sep 2009 13:08:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Sep 2009 13:08:50 +0000 (UTC) Cc: 4543@emacsbugs.donarmstrong.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 25 15:08:42 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MrAWK-00085y-42 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Sep 2009 15:07:32 +0200 Original-Received: from localhost ([127.0.0.1]:38057 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrAWJ-00069P-JK for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Sep 2009 09:07:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MrAW2-00069I-Kx for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2009 09:07:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MrAVx-00068e-Du for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2009 09:07:13 -0400 Original-Received: from [199.232.76.173] (port=58099 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrAVv-00068X-Tw for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2009 09:07:08 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37811) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MrAVv-00087z-A3 for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2009 09:07:07 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PD74kU023030; Fri, 25 Sep 2009 06:07:05 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8PD547g021989; Fri, 25 Sep 2009 06:05:04 -0700 Resent-Date: Fri, 25 Sep 2009 06:05:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 25 Sep 2009 13:05:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4543 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4543-submit@emacsbugs.donarmstrong.com id=B4543.125388360020932 (code B ref 4543); Fri, 25 Sep 2009 13:05:04 +0000 Original-Received: (at 4543) by emacsbugs.donarmstrong.com; 25 Sep 2009 13:00:00 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8PCxwnE020906 for <4543@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 06:00:00 -0700 Original-Received: (qmail invoked by alias); 25 Sep 2009 12:59:52 -0000 Original-Received: from 62-47-44-18.adsl.highway.telekom.at (EHLO [62.47.44.18]) [62.47.44.18] by mail.gmx.net (mp041) with SMTP; 25 Sep 2009 14:59:52 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX185auIyR+s5QlVbEotaQm9O4GmvlPylZ4HCa7Etf3 qwYZVjJKTN5DDM User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <83vdj7tlup.fsf@gnu.org> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.57 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 25 Sep 2009 09:07:13 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31499 Archived-At: >> `window-full-width-p' is based on the definition >> >> /* Total width of frame F, in columns (characters), >> including the width used by scroll bars if any. */ >> >> #define FRAME_TOTAL_COLS(f) ((f)->total_cols) >> >> from frame.h whose semantics I don't understand. Not really simple. > > Maybe I can help. What is the difficulty with the semantics of this > attribute of a frame? It's merely how this is set in `change_frame_size_1' which does SET_FRAME_COLS (f, newwidth); where #define SET_FRAME_COLS(f, val) \ (FRAME_COLS (f) = (val), \ (f)->total_cols = FRAME_TOTAL_COLS_ARG (f, FRAME_COLS (f))) and #define FRAME_TOTAL_COLS_ARG(f, width) \ ((width) \ + FRAME_SCROLL_BAR_COLS (f) \ + FRAME_FRINGE_COLS (f)) and #define FRAME_SCROLL_BAR_COLS(f) \ (FRAME_HAS_VERTICAL_SCROLL_BARS (f) \ ? FRAME_CONFIG_SCROLL_BAR_COLS (f) \ : 0) etc ... What are the scrollbars of a frame, I'm asking myself. If we define a frame as a collection of windows and frame-width as the width of the widest window in that frame, things are deceptively simple. But the calculations sketched above are a little over my head. > What's wrong with this (taken from frame.c:frame-parameters) as the > frame height: > > height = (f->new_text_lines ? f->new_text_lines : FRAME_LINES (f)); new_text_lines is for a pending size change and zero otherwise. You probably mean text_lines whose precise semantics I don't know - what are canonical characters? > and then subtract from it the height of the minibuffer window? > > The C variable `minibuf_window' should give you the Lisp object that > holds the minibuffer window, and its `total_lines' attribute should > give you the height of that window. Or am I missing something? Then why not use the height of the frame-root-window directly? No need to subtract one value from the other. martin