From: martin rudalics <rudalics@gmx.at>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 4534@emacsbugs.donarmstrong.com
Subject: bug#4534: assertion failure at window.c:grow_mini_window
Date: Wed, 23 Sep 2009 14:21:39 +0200 [thread overview]
Message-ID: <4ABA12D3.3060507@gmx.at> (raw)
In-Reply-To: <f7ccd24b0909230351q611f2ea6m75a11b0513846ca2@mail.gmail.com>
> FWIW, commenting out this chunk from shrink_mini_window, it works as expected.
>
> Juanma
>
>
>
> diff --git a/src/window.c b/src/window.c
> index 08fd8c8..c892436 100644
> --- a/src/window.c
> +++ b/src/window.c
> @@ -4677,17 +4677,18 @@ void
> shrink_mini_window (w)
> struct window *w;
> {
> - struct frame *f = XFRAME (w->frame);
> - struct window *root = XWINDOW (FRAME_ROOT_WINDOW (f));
> -
> - if (save_restore_orig_size (root, CHECK_ORIG_SIZES))
> - {
> - save_restore_orig_size (root, RESTORE_ORIG_SIZES);
> - adjust_glyphs (f);
> - FRAME_WINDOW_SIZES_CHANGED (f) = 1;
> - windows_or_buffers_changed = 1;
> - }
> - else if (XFASTINT (w->total_lines) > 1)
This would make the whole save/restore code obsolete. Unfortunately,
the resulting alternative (enlarge_window) is even worse because it
might delete windows (when it tries to enlarge them) :-(
martin
next prev parent reply other threads:[~2009-09-23 12:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7ccd24b0910260305i10204d17hbdbfe72251d740f1@mail.gmail.com>
2009-09-23 3:02 ` bug#4534: assertion failure at window.c:grow_mini_window Juanma Barranquero
2009-09-23 7:28 ` martin rudalics
2009-09-23 9:50 ` Juanma Barranquero
2009-09-23 10:51 ` Juanma Barranquero
2009-09-23 12:21 ` martin rudalics [this message]
2009-09-23 13:42 ` Juanma Barranquero
2009-09-24 6:49 ` martin rudalics
2009-09-23 12:21 ` martin rudalics
2009-09-23 13:41 ` Juanma Barranquero
2009-09-24 6:49 ` martin rudalics
2009-09-24 12:58 ` Juanma Barranquero
2009-09-24 15:32 ` martin rudalics
2009-09-24 15:53 ` Juanma Barranquero
2009-09-24 16:10 ` martin rudalics
2009-09-24 16:22 ` Juanma Barranquero
2009-09-24 17:35 ` martin rudalics
2009-09-24 17:45 ` Juanma Barranquero
2009-09-24 22:03 ` Stefan Monnier
2009-09-25 18:02 ` Juanma Barranquero
2009-10-16 8:32 ` Juanma Barranquero
2009-10-24 15:37 ` Juanma Barranquero
2009-09-24 17:36 ` Stefan Monnier
2009-09-25 8:35 ` Eli Zaretskii
2009-09-25 11:30 ` Juanma Barranquero
2009-09-25 13:14 ` Eli Zaretskii
2009-09-25 14:08 ` Juanma Barranquero
2009-10-26 10:10 ` bug#4534: marked as done (assertion failure at window.c:grow_mini_window) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABA12D3.3060507@gmx.at \
--to=rudalics@gmx.at \
--cc=4534@emacsbugs.donarmstrong.com \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).