From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#3949: 23.1.50; C-x 0 should go to a sister window if possible Date: Sat, 01 Aug 2009 15:12:28 +0200 Message-ID: <4A743F3C.10507@gmx.at> References: <4A6DEC54.9070406@gmx.at> <4A6EAB48.2030309@gmx.at> Reply-To: martin rudalics , 3949@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050601020206000505070802" X-Trace: ger.gmane.org 1249133252 22073 80.91.229.12 (1 Aug 2009 13:27:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Aug 2009 13:27:32 +0000 (UTC) To: martin rudalics , 3949@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 01 15:27:25 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MXEcO-0003E0-BB for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Aug 2009 15:27:25 +0200 Original-Received: from localhost ([127.0.0.1]:55654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXEcN-0000Ry-0s for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Aug 2009 09:27:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXEcE-0000Rl-A2 for bug-gnu-emacs@gnu.org; Sat, 01 Aug 2009 09:27:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXEc9-0000QC-Nq for bug-gnu-emacs@gnu.org; Sat, 01 Aug 2009 09:27:13 -0400 Original-Received: from [199.232.76.173] (port=54924 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXEc9-0000Q9-Hg for bug-gnu-emacs@gnu.org; Sat, 01 Aug 2009 09:27:09 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:52830) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MXEc9-0001uY-15 for bug-gnu-emacs@gnu.org; Sat, 01 Aug 2009 09:27:09 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n71DQjEr022899; Sat, 1 Aug 2009 06:26:46 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n71DK44a022094; Sat, 1 Aug 2009 06:20:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 01 Aug 2009 13:20:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3949 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3949-submit@emacsbugs.donarmstrong.com id=B3949.124913245721532 (code B ref 3949); Sat, 01 Aug 2009 13:20:04 +0000 Original-Received: (at 3949) by emacsbugs.donarmstrong.com; 1 Aug 2009 13:14:17 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n71DEAna021517 for <3949@emacsbugs.donarmstrong.com>; Sat, 1 Aug 2009 06:14:12 -0700 Original-Received: (qmail invoked by alias); 01 Aug 2009 13:14:04 -0000 Original-Received: from 62-47-37-58.adsl.highway.telekom.at (EHLO [62.47.37.58]) [62.47.37.58] by mail.gmx.net (mp038) with SMTP; 01 Aug 2009 15:14:04 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18XGYJYK7EXuVhf5IcNX6rrTDpQMTPNJnjE4OvvEv IPAbU6Pt7sORpC User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <4A6EAB48.2030309@gmx.at> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.64,0.57 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 01 Aug 2009 09:27:13 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29780 Archived-At: This is a multi-part message in MIME format. --------------050601020206000505070802 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > > C-x 1 > > C-x 3 > > windmove-right > > C-x 2 > > windmove-down > > C-x 0 > > > > For me it stops in the left window, not the right as I expect. > > Looks like a bug indeed. It behaves this way in the current trunk but > doesn't so in my Emacs. I'll have to look into this. OK the problem is with the following assignment in delete_window: /* Otherwise, try another window for SWINDOW. */ swindow = Fnext_window (swindow, Qlambda, Qnil); This will fail to pick a useful window when deleting the bottom-right window of a frame. I use /* Otherwise, try another window for SWINDOW. */ swindow = Fprevious_window (swindow, Qlambda, Qnil); which is better for me but fails miserably when deleting the top-left window of a frame. So maybe we need something like the attached patch. Could you try it? martin --------------050601020206000505070802 Content-Type: text/plain; name="window.c.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="window.c.diff" KioqIHdpbmRvdy5jLn4xLjYzOS5+CTIwMDktMDctMDQgMTc6MDk6MzguMjY1NjI1MDAwICsw MjAwDQotLS0gd2luZG93LmMJMjAwOS0wOC0wMSAxNTowNjo0OC45MDYyNTAwMDAgKzAyMDAN CioqKioqKioqKioqKioqKg0KKioqIDE1OTYsMTYwMiAqKioqDQogIAlpZiAoIUVRICh3aW5k b3csIHB3aW5kb3cpKQ0KICAJICBicmVhazsNCiAgCS8qIE90aGVyd2lzZSwgdHJ5IGFub3Ro ZXIgd2luZG93IGZvciBTV0lORE9XLiAgKi8NCiEgCXN3aW5kb3cgPSBGbmV4dF93aW5kb3cg KHN3aW5kb3csIFFsYW1iZGEsIFFuaWwpOw0KICANCiAgCS8qIElmIHdlIGdldCBiYWNrIHRv IHRoZSBmcmFtZSdzIHNlbGVjdGVkIHdpbmRvdywNCiAgCSAgIGl0IG1lYW5zIHRoZXJlIHdh cyBubyBhY2NlcHRhYmxlIGFsdGVybmF0aXZlLA0KLS0tIDE1OTYsMTYwNSAtLS0tDQogIAlp ZiAoIUVRICh3aW5kb3csIHB3aW5kb3cpKQ0KICAJICBicmVhazsNCiAgCS8qIE90aGVyd2lz ZSwgdHJ5IGFub3RoZXIgd2luZG93IGZvciBTV0lORE9XLiAgKi8NCiEgCWlmIChOSUxQIChY V0lORE9XIChzd2luZG93KS0+cHJldikpDQohIAkgIHN3aW5kb3cgPSBGbmV4dF93aW5kb3cg KHN3aW5kb3csIFFsYW1iZGEsIFFuaWwpOw0KISAJZWxzZQ0KISAJICBzd2luZG93ID0gRnBy ZXZpb3VzX3dpbmRvdyAoc3dpbmRvdywgUWxhbWJkYSwgUW5pbCk7DQogIA0KICAJLyogSWYg d2UgZ2V0IGJhY2sgdG8gdGhlIGZyYW1lJ3Mgc2VsZWN0ZWQgd2luZG93LA0KICAJICAgaXQg bWVhbnMgdGhlcmUgd2FzIG5vIGFjY2VwdGFibGUgYWx0ZXJuYXRpdmUsDQo= --------------050601020206000505070802--