unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: emacs-pretest-bug@gnu.org, 3811@emacsbugs.donarmstrong.com
Subject: bug#3811: 23.0.96; custom-group-members
Date: Wed, 15 Jul 2009 08:11:20 -0700	[thread overview]
Message-ID: <4A690214EF0047F4B36EE72F6A3161F8@us.oracle.com> (raw)
In-Reply-To: <jwvab36j9bh.fsf-monnier+emacsbugreports@gnu.org>

You're right; I was wrong. I think I must have tested it only on groups that
have only groups as members - group `editing', for example. Guess I didn't
realize I was doing that.

It might be useful to have another function (or perhaps another optional arg to
this function), which would act recursively to give you all members, indirect or
direct, that belong to the group - IOW, anything that belongs to the group or to
one of its subgroups (recursively).

In any case, what I said about the doc string remains true. There should be some
description of the alternative: "What should you expect if GROUPS-ONLY is nil,
other than groups? What else might be included in the list?"

Other than that, this can be closed.

> From: Stefan Monnier Sent: Wednesday, July 15, 2009 7:46 AM
> > emacs -Q
> > Dunno if this is just a doc bug or a code bug. 
> > `custom-group-members' seems to give the same result -
> > a list of groups, whether its second arg GROUPS-ONLY is nil
> > or t. I don't see any difference.
> 
> Can't reproduce it here:
>  
>    emacs -Q
>    M-x load-library RET cus-edit RET
>    M-: (custom-group-members 'custom-faces nil) RET
> 
> gives me a list of the members of that group, one of which is itself
> a group but the rest isn't:
> 
>    ((custom-magic-faces custom-group)
>     (custom-button custom-face)
>     (custom-button-mouse custom-face)
>     (custom-button-unraised custom-face)
>     (custom-button-pressed custom-face)
>     (custom-button-pressed-unraised custom-face)
>     (custom-documentation custom-face)
>     (custom-state custom-face)
>     (custom-link custom-face)
>     (custom-comment custom-face)
>     (custom-comment-tag custom-face)
>     (custom-variable-tag custom-face)
>     (custom-variable-button custom-face)
>     (custom-visibility custom-face)
>     (custom-face-tag custom-face)
>     (custom-group-tag-faces custom-variable)
>     (custom-group-tag-1 custom-face)
>     (custom-group-tag custom-face))






  reply	other threads:[~2009-07-15 15:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwvws69er36.fsf-monnier+emacsbugreports@gnu.org>
2009-07-10 17:53 ` bug#3811: 23.0.96; custom-group-members Drew Adams
2009-07-15 14:46   ` Stefan Monnier
2009-07-15 15:11     ` Drew Adams [this message]
2009-07-15 17:13     ` Drew Adams
2009-07-15 18:45   ` bug#3811: marked as done (23.0.96; custom-group-members) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A690214EF0047F4B36EE72F6A3161F8@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=3811@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).