From: Yuan Fu <casouri@gmail.com>
To: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
Cc: jostein@kjonigsen.net, 59906-done@debbugs.gnu.org,
Theodor Thornhill <theo@thornhill.no>
Subject: bug#59906: 29.0.60; typescript-ts-mode is not highlighting escape sequences
Date: Fri, 9 Dec 2022 12:41:59 -0800 [thread overview]
Message-ID: <4A5322D7-45B0-4AAC-BFD3-C2DA9ABBF904@gmail.com> (raw)
In-Reply-To: <b5b92538-5fa5-3a8d-dbe8-e0a944d0bd6b@secure.kjonigsen.net>
Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
> On 08.12.2022 16:19, Theodor Thornhill wrote:
>> Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
>>
>>> In a buffer with typescript-ts-mode activated, write the following code:
>>>
>>> const test = "quoted\"string\" contents";
>>>
>>> The entire text, include the \" is highlighted as strings, and escape sequences are not handled:
>>>
>>> This code has the following tree-sitter syntax tree:
>>>
>>> (lexical_declaration kind: const
>>> (variable_declarator name: (identifier) value: =
>>> (string " (string_fragment) (escape_sequence) (string_fragment) (escape_sequence) (string_fragment) "))
>>> ;)
>>>
>>> In typescript-ts-mode we seemingly have rules to handle fontification of escape sequences:
>>>
>>> :language language
>>> :feature 'escape-sequence
>>> :override t
>>> '((escape_sequence) @font-lock-escape-face))
>>>
>>> This feature is however not activated in the major-mode setup:
>>>
>>> (setq-local treesit-font-lock-feature-list
>>> '((comment declaration)
>>> (keyword string)
>>> (constant expression identifier number pattern property)
>>> (bracket delimiter)))
>>>
>>> Naively I assumed that simply adding this feature would activate this rule, but still \" is fontified as string.
>> Yeah, there was an error there. See below patch.
>>
>> Yuan, can you install this?
>>
>> Theo
>>
> Yeah that works for me.
>
> Yuan: another vote for installing right here :)
Yep, applied, many thanks!
Yuan
prev parent reply other threads:[~2022-12-09 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 15:04 bug#59906: 29.0.60; typescript-ts-mode is not highlighting escape sequences Jostein Kjønigsen
2022-12-08 15:19 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-08 17:23 ` Jostein Kjønigsen
2022-12-09 20:41 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5322D7-45B0-4AAC-BFD3-C2DA9ABBF904@gmail.com \
--to=casouri@gmail.com \
--cc=59906-done@debbugs.gnu.org \
--cc=jostein@kjonigsen.net \
--cc=jostein@secure.kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).