From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#1806: dired-pop-to-buffer in wrong place Date: Mon, 18 May 2009 10:11:59 +0200 Message-ID: <4A11184F.4030606@gmx.at> References: <87r63gzcap.fsf@jurta.org> <87d4ezuw6w.fsf@jurta.org> <4964CB72.1090605@gmx.at> <87aba3qb5g.fsf@jurta.org> <4965AE6B.6070802@gmx.at> <87fxjtmo4z.fsf@jurta.org> <49671922.4080609@gmx.at> <87zlhubw10.fsf@jurta.org> <496DF4B9.3080805@gmx.at> <496E5F58.7030304@gmx.at> <496F11C0.4080700@gmx.at> <87ocy8fajt.fsf@jurta.org> <4975F4D5.5030000@gmx.at> <87y6tk1j47.fsf@mail.jurta.org> <49F7FE14.8010107@gmx.at> <49FFE515.4020608@gmx.at> <87vdnzpks0.fsf@mail.jurta.org> Reply-To: martin rudalics , 1806@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020402040707080502080803" X-Trace: ger.gmane.org 1242635556 30622 80.91.229.12 (18 May 2009 08:32:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 May 2009 08:32:36 +0000 (UTC) Cc: 1806@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 18 10:32:29 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M5yGq-0005FG-IJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 May 2009 10:32:28 +0200 Original-Received: from localhost ([127.0.0.1]:40436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5yGq-00034D-0W for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 May 2009 04:32:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5yGU-0002oY-2n for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 04:32:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5yGO-0002lw-VK for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 04:32:04 -0400 Original-Received: from [199.232.76.173] (port=49554 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5yGO-0002lh-BD for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 04:32:00 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43416) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M5yGN-00025G-Kr for bug-gnu-emacs@gnu.org; Mon, 18 May 2009 04:32:00 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4I8Vuh8002763; Mon, 18 May 2009 01:31:57 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4I8K5Su031427; Mon, 18 May 2009 01:20:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 18 May 2009 08:20:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1806 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1806-submit@emacsbugs.donarmstrong.com id=B1806.124263438529879 (code B ref 1806); Mon, 18 May 2009 08:20:05 +0000 Original-Received: (at 1806) by emacsbugs.donarmstrong.com; 18 May 2009 08:13:05 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id n4I8D1Nt029858 for <1806@emacsbugs.donarmstrong.com>; Mon, 18 May 2009 01:13:02 -0700 Original-Received: (qmail invoked by alias); 18 May 2009 08:12:55 -0000 Original-Received: from 62-47-57-103.adsl.highway.telekom.at (EHLO [62.47.57.103]) [62.47.57.103] by mail.gmx.net (mp018) with SMTP; 18 May 2009 10:12:55 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18IOaRiUqMIDZ7SxYXEKDTyhRTXSVFIB6qomH40M3 XgHVmsHRUHzbs/ User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <87vdnzpks0.fsf@mail.jurta.org> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.73,0.65 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 18 May 2009 04:32:04 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27957 Archived-At: This is a multi-part message in MIME format. --------------020402040707080502080803 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > Could you also fix Proced and Calendar? I suppose you mean the call in `calendar-basic-setup' here. In this case you probably want to split the largest or LRU window vertically even if your customized settings would imply a horizontal split. But you don't insist on splitting the selected window. Right? Any opinions, Glenn? martin --------------020402040707080502080803 Content-Type: text/plain; name="calendar.el.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="calendar.el.diff" *** calendar.el.~1.281.~ 2009-03-16 07:35:28.000000000 +0100 --- calendar.el 2009-05-18 09:52:53.203125000 +0200 *************** *** 1291,1297 **** (calendar-increment-month month year (- calendar-offset)) ;; Display the buffer before calling calendar-generate-window so that it ;; can get a chance to adjust the window sizes to the frame size. ! (or nodisplay (pop-to-buffer calendar-buffer)) (calendar-generate-window month year) (if (and calendar-view-diary-initially-flag (calendar-date-is-visible-p date)) --- 1291,1301 ---- (calendar-increment-month month year (- calendar-offset)) ;; Display the buffer before calling calendar-generate-window so that it ;; can get a chance to adjust the window sizes to the frame size. ! (or nodisplay ! (let ((split-height-threshold 0) ! split-width-threshold) ! ;; Prefer vertical splits (Bug#1806). ! (pop-to-buffer calendar-buffer))) (calendar-generate-window month year) (if (and calendar-view-diary-initially-flag (calendar-date-is-visible-p date)) --------------020402040707080502080803--