From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#60089: 29.0.60; eglot doesn't support csharp-ls language server [PATCH] Date: Thu, 15 Dec 2022 22:49:39 +0100 Message-ID: <49A0AC5D-0191-4D92-9B29-06BB086725AE@secure.kjonigsen.net> References: Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32620"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60089@debbugs.gnu.org, joaotavora@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 22:50:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5w7Q-0008GS-Qn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 22:50:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5w7A-00078z-Bx; Thu, 15 Dec 2022 16:50:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5w79-00078m-0a for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 16:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5w78-0006qy-Mp for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 16:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5w78-0004F0-AQ for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 16:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 21:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60089 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60089-submit@debbugs.gnu.org id=B60089.167114100016292 (code B ref 60089); Thu, 15 Dec 2022 21:50:02 +0000 Original-Received: (at 60089) by debbugs.gnu.org; 15 Dec 2022 21:50:00 +0000 Original-Received: from localhost ([127.0.0.1]:45121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5w76-0004Ei-0T for submit@debbugs.gnu.org; Thu, 15 Dec 2022 16:50:00 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5w74-0004Ec-Bm for 60089@debbugs.gnu.org; Thu, 15 Dec 2022 16:49:59 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E9F1A5C0131; Thu, 15 Dec 2022 16:49:52 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 15 Dec 2022 16:49:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1671140992; x=1671227392; bh=nDy2a4QS4g BCHh2Ksfa7whSUYklFOMx56b6piQmWL9I=; b=CgawgalazWz42uLBQCRXzDJxLE 45VHt58MwHkkrMQvoCMQ2zFa38knldfSsNnXwQDxzgpPp0wyX6nPmuctDDBHft41 yrtkYqFQ4NVpi/fjGWW5vE6r9refEoloA4WKiIzXp6/bTP6RyxPFnrlWLfuYrBIO XAXuxs3OCjqqfD/P9Q5xxf7iK1gjR1JRyUbXd4fG9tHAl1ySe4GKGzej/eLOPEJT WAD7aF5iZ/lW/ci7+FIjoF62gEGHSlYpVvY0wR8faCg89PpQoasQ6l2ZdOR2fjdq eUrerNiMhFq7MdCTRzqdKTkRbRMkONaTidy8cxaL31JxxJfzs8JCnrtNTh2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671140992; x= 1671227392; bh=nDy2a4QS4gBCHh2Ksfa7whSUYklFOMx56b6piQmWL9I=; b=K W/ZBolPOT2UNfmT5+O9PMbirYw414uMA7jVuCebKwkQ6Tzh0fANbtNslANt2lASp ZNwWIQWauWBct5qrOadJxNqex+Te9F/JVrVCC5KqlQKl6sOxir2w1XVFsS/sa/ug vhj9lvHQqQdSh5yooKY0sYM78l6L3X9UVi+R5pxgXuD9VB7qefrb5Izs4m84rAtx SfpW4M2q917IG6ZofR36ufx/YrcuiBdrXvhTh3RDu4vPqXs5LhG8eIgHsCyO/22z IY4g1iE7gENhw66QGOY3Y1lzNvO+FXyCVJLmx+7YuBhM4ARMITRXdAWi+V2L2DPy tXOlDd0IwsyG0UjQRrDKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehgdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfghfggufffkfhfvegjvffosehtqhhmtdhhtdejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeekteegtdegjeettdehgedtieef hfegueelvdefvdfhvdfgteeuteduledthfejueenucffohhmrghinhepghhithhhuhgsrd gtohhmpdhkjhhnihhgshgvnhdrnhgvthenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgsh gvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Dec 2022 16:49:52 -0500 (EST) In-Reply-To: X-Mailer: iPhone Mail (20C65) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251153 Archived-At: On 15 Dec 2022, at 22:28, Stefan Kangas wrote: >=20 > =EF=BB=BFJostein Kj=C3=B8nigsen writes: >=20 >> Right now eglot only knows about the Omnisharp Roslyn language server >> for C#. >>=20 >> csharp-ls[1] is another popular language server and is supported by >> other LSP-clients, like lsp-mode. >>=20 >> Eglot should support it too. >>=20 >> Attached is a patch which introduces support for this language-server. >>=20 >> [1] https://github.com/razzmatazz/csharp-language-server >=20 > Could you give a rationale for why we should prefer omnisharp over > csharp-ls? Why not the other way around? >=20 > (I know nothing about C#.) As far as presedence go, I have no personal preference here.=20 I myself use csharp-ls, because it=E2=80=99s faster, but it=E2=80=99s newer w= ith less lineage and only aims to support new =E2=80=9C.net core=E2=80=9D ty= pe projects.=20 Omnisharp is not as fast, but has been around for a longer time and official= ly also supports =E2=80=9Clegacy=E2=80=9D-style .net framework projects.=20 As such it probably make sense to present Omnisharp as the default, since it= offers the highest compatibility guarantees regardless of target code-base.= =20 =E2=80=94 Jostein Kj=C3=B8nigsen https://jostein.kj=C3=B8nigsen.net=