From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#6572: 24.0.50; error string from `custom-variable-set' Date: Tue, 6 Jul 2010 08:59:19 -0700 Message-ID: <4995D102D3EE4EEF8E667EAE41D707DD@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1278433800 24219 80.91.229.12 (6 Jul 2010 16:30:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 6 Jul 2010 16:30:00 +0000 (UTC) To: 6572@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 06 18:29:58 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OWB1x-0008Hd-Dd for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Jul 2010 18:29:57 +0200 Original-Received: from localhost ([127.0.0.1]:38670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWB1w-0003Cu-IX for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Jul 2010 12:29:56 -0400 Original-Received: from [140.186.70.92] (port=49314 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWB1q-0003A1-6H for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2010 12:29:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWB1p-0001CI-03 for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2010 12:29:50 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51277) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWB1o-0001CC-Uv for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2010 12:29:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OWAaw-00013R-0a; Tue, 06 Jul 2010 12:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Jul 2010 16:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.12784320694031 (code B ref -1); Tue, 06 Jul 2010 16:02:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jul 2010 16:01:09 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWAa5-00012y-7s for submit@debbugs.gnu.org; Tue, 06 Jul 2010 12:01:09 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWAa1-00012b-Uf for submit@debbugs.gnu.org; Tue, 06 Jul 2010 12:01:07 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:51250) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OWAZw-0005MH-8B for submit@debbugs.gnu.org; Tue, 06 Jul 2010 12:01:00 -0400 Original-Received: from [140.186.70.92] (port=54807 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWAZt-0006GY-2x for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2010 12:00:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWAZk-0004mk-Oa for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2010 12:00:50 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:46856) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWAZk-0004m5-Ja for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2010 12:00:48 -0400 Original-Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o66G0dXi009641 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 6 Jul 2010 16:00:41 GMT Original-Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o66FO5wC022482 for ; Tue, 6 Jul 2010 16:00:37 GMT Original-Received: from abhmt018.oracle.com by acsmt353.oracle.com with ESMTP id 401965951278431954; Tue, 06 Jul 2010 08:59:14 -0700 Original-Received: from dradamslap1 (/141.144.80.58) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 06 Jul 2010 08:59:13 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcsdJDEVwbMQGss+S+mHRkkBCwxEYQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4C335325.0169:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 06 Jul 2010 12:02:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38263 Archived-At: If the defcustom :type is (restricted-sexp...), and you try to customize to a value that does not respect this :type, you get a generic error message: "The specified value is not valid". This message could & should be more specific, referencing the sexp that defines the restriction the value should respect. E.g. if :type is: (restricted-sexp :match-alternatives 'natnump) Then the message would be more helpful if it said something like this: "Specified value does not satisfy `natnump'" If :type is: (restricted-sexp :match-alternatives (lambda (x) (and (foop x) (not (barp x))))) Then this message is more helpful: "Specified value does not satisfy `(lambda (x) (and (foop x) (not (barp x))))'" If :type is: (restricted-sexp :match-alternatives (integerp 't 'nil)) Then this message is more helpful: "Specified value does not satisfy `(integerp 't 'nil)'" In all cases, it is better to give the user some indication of what the value should be, even if that is via a Lisp sexp. Yes, the doc string should make clear the permissible values, but this additional info in the message can also help. It is at least as helpful as the ubiquitous message "(wrong-type-argument integerp "abc")". In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-06-28 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'