From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.bugs Subject: bug#2062: PATH can contain non-expanded variables Date: Tue, 27 Jan 2009 09:56:59 +0800 Message-ID: <497E69EB.70609@f2s.com> References: Reply-To: Jason Rumney , 2062@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1233023104 11598 80.91.229.12 (27 Jan 2009 02:25:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Jan 2009 02:25:04 +0000 (UTC) Cc: Emacs Bug Tracker To: Juanma Barranquero , 2062@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 27 03:26:17 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LRdeZ-0001AY-BH for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Jan 2009 03:26:15 +0100 Original-Received: from localhost ([127.0.0.1]:48195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRddH-0004nD-FV for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2009 21:24:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRdby-0004SX-8U for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 21:23:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRdbw-0004RS-N2 for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 21:23:33 -0500 Original-Received: from [199.232.76.173] (port=51540 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRdbw-0004RJ-F9 for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 21:23:32 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37968) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRdbv-0004tQ-U6 for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 21:23:32 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0R2NTue010741; Mon, 26 Jan 2009 18:23:29 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0R255bf005496; Mon, 26 Jan 2009 18:05:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Jason Rumney Original-Sender: Jason Rumney Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Tue, 27 Jan 2009 02:05:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2062 X-Emacs-PR-Package: emacs,w32 X-Emacs-PR-Keywords: Original-Received: via spool by 2062-submit@emacsbugs.donarmstrong.com id=B2062.12330214683893 (code B ref 2062); Tue, 27 Jan 2009 02:05:05 +0000 Original-Received: (at 2062) by emacsbugs.donarmstrong.com; 27 Jan 2009 01:57:48 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-qy0-f20.google.com (mail-qy0-f20.google.com [209.85.221.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0R1vdTm003886; Mon, 26 Jan 2009 17:57:40 -0800 Original-Received: by qyk13 with SMTP id 13so23211343qyk.1 for ; Mon, 26 Jan 2009 17:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=A8Mop3XEsZSQunh7v5OjH/b6so8exgIJUd6WtxguEnM=; b=QKvBTY+6WVq8hPCHYf1ImADtb7i+F3xWRKxy7aq3fzWaNpLqQc68CT0MIFE42+4dkb AFDEIZ3z0hV0F2V4g7UMsg5aY7votEbubZcOZ49sN7TD4S9fhRriw6ne2yA0k9z/oXCi x23MVt9ouohceWgiT2YJncY7vfkUctL/VFM9U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=jkIypeAW3t6tjSPNbPLmlcdErSojvZMSYvHNUvhuGFtiOHxELt13AWCMgl4CndfQiO eGPvoLJ/8I9/IebWs0M1jrsrraKKDq7x27iTQyWpoVXywOx7KUX5N/GBUY1tR9alf44e tifP/48N2KiuqD6THiqGp39ySs1RD9sEN7rHg= Original-Received: by 10.214.148.1 with SMTP id v1mr1339076qad.194.1233021453857; Mon, 26 Jan 2009 17:57:33 -0800 (PST) Original-Received: from ?192.168.249.26? ([118.101.26.137]) by mx.google.com with ESMTPS id 6sm906069qwk.52.2009.01.26.17.57.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 26 Jan 2009 17:57:32 -0800 (PST) User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 26 Jan 2009 21:23:33 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24592 Archived-At: Juanma Barranquero wrote: > Index: emacs.c > =================================================================== > RCS file: /sources/emacs/emacs/src/emacs.c,v > retrieving revision 1.461 > diff -u -2 -r1.461 emacs.c > --- emacs.c 23 Jan 2009 14:53:11 -0000 1.461 > +++ emacs.c 26 Jan 2009 12:48:49 -0000 > @@ -2467,6 +2467,12 @@ > if (path) > { > +#ifdef WINDOWSNT > + DWORD required = ExpandEnvironmentStrings (path, NULL, 0); > + p = (char *) alloca (required); > + ExpandEnvironmentStrings (path, p, required); > +#else > p = alloca (strlen (path) + 1); > strcpy (p, path); > +#endif > path = p; > The right place to do this expansion is where the variable is read from the registry, and only when the type is REG_EXPAND_SZ.