From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.bugs Subject: bug#1952: 23.0.60[W32-Mingw]; opening etc/HELLO is slower than before Date: Tue, 20 Jan 2009 20:52:00 +0800 Message-ID: <4975C8F0.7070302@gnu.org> References: <42b562540901181840v1cfc73bbxec292b40aa4a60aa@mail.gmail.com> <49748AAE.6070509@gnu.org> Reply-To: Jason Rumney , 1952@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1232457937 22121 80.91.229.12 (20 Jan 2009 13:25:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Jan 2009 13:25:37 +0000 (UTC) Cc: Kevin Yu , 1952@emacsbugs.donarmstrong.com To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 20 14:26:49 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LPGco-0000qs-3W for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Jan 2009 14:26:38 +0100 Original-Received: from localhost ([127.0.0.1]:52565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPGbW-00028Q-Q4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Jan 2009 08:25:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPGaw-0001g6-O3 for bug-gnu-emacs@gnu.org; Tue, 20 Jan 2009 08:24:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPGau-0001dj-0Z for bug-gnu-emacs@gnu.org; Tue, 20 Jan 2009 08:24:42 -0500 Original-Received: from [199.232.76.173] (port=49284 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPGat-0001dY-PP for bug-gnu-emacs@gnu.org; Tue, 20 Jan 2009 08:24:39 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43831) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LPGGV-0005Ue-BV for bug-gnu-emacs@gnu.org; Tue, 20 Jan 2009 08:03:36 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0KD3R4g000603; Tue, 20 Jan 2009 05:03:28 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0KD03Fq031921; Tue, 20 Jan 2009 05:00:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Jason Rumney Original-Sender: Jason Rumney Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 20 Jan 2009 13:00:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1952 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1952-submit@emacsbugs.donarmstrong.com id=B1952.123245596030655 (code B ref 1952); Tue, 20 Jan 2009 13:00:02 +0000 Original-Received: (at 1952) by emacsbugs.donarmstrong.com; 20 Jan 2009 12:52:40 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.189]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0KCqWZD030649 for <1952@emacsbugs.donarmstrong.com>; Tue, 20 Jan 2009 04:52:33 -0800 Original-Received: by ti-out-0910.google.com with SMTP id b6so2900833tic.1 for <1952@emacsbugs.donarmstrong.com>; Tue, 20 Jan 2009 04:52:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=abXFmjJLrFZoVl6VYTAXGTjZEXrXXT7uWT2litJUMy8=; b=rSykZuN515jMyoPhR4Sw+lsixVkRYET8IYnH5zbPjd33Qxyz06ODKwd6dugVtR1cjw BmQH/1kJZYwzUCHEyJoS1qiXtcGUaazEBnpumZYly945U/gBdyyB4OS5xwHTlqfatmqG Y3MQ9/hiXQ5dCBurtjVGk1qAoT1LFB4WscS7o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=c2ljWxSYMp5PRg3QUnmCmWOE7WNp/PV5HxFUEpZ36Pd2mFhRKTo5/Es8AfjDXvkB1A UQiB3xbVQ7EN0MwJt1kExP45dfg16NEFUPuQSj88lHQ75Fp8WXA8O5LPkijE0iGnuPAY NBf3DFt0RD0Kpq0rDPuB24SPoWFXyIXdGm+mU= Original-Received: by 10.110.37.3 with SMTP id k3mr7823895tik.54.1232455951423; Tue, 20 Jan 2009 04:52:31 -0800 (PST) Original-Received: from ?192.168.249.26? ([124.13.220.194]) by mx.google.com with ESMTPS id b4sm1136112tic.2.2009.01.20.04.52.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 20 Jan 2009 04:52:30 -0800 (PST) User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 20 Jan 2009 08:24:42 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24311 Archived-At: Juanma Barranquero wrote: > I think Kevin Yu is right. Moving around in etc/HELLO, even with a lot > of installed fonts, was quite fast until this change: > > 2009-01-09 Jason Rumney > > * w32font.c (add_font_entity_to_list): Don't report unknown > Windows charset as any unrecognized registry. (Bug#1548) > Only report Unicode Plane 2 fonts as unicode-sip. > > Now, moving in etc/HELLO is unbearably slow. I'm talking of typing > and waiting about two seconds for the cursor to move. > I don't see any slowness when scrolling, but it may be because I do not have a lot of fonts installed compared with some people, or it may be because I have fonts installed for all the languages in HELLO, so there are no failures (which I suspect may not get cached). One of the changes made at the same time as the above (which I apparently forgot to add a ChangeLog entry for) was to fix the return value of add_one_font_entity_to_list. This function was supposed to abort the font enumeration as soon as a match was found. But previously the logic was wrong so it was aborting if the first font did not match the given font-spec. So in the majority of cases, it would only enumerate one font and return nil, only if the first font matched would it go through every font in the system and return all the fonts that matched. After the fix, it will go through all the fonts for characters that do not have a matching font installed, and will go through enough fonts to find a match for others. Since there was no visible bug previously, I wonder what use this function is, and whether it is just wasting time looking for a match that we already have.