From: Jason Rumney <jasonr@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Kevin Yu <yujie052@gmail.com>, 1952@emacsbugs.donarmstrong.com
Subject: bug#1952: 23.0.60[W32-Mingw]; opening etc/HELLO is slower than before
Date: Tue, 20 Jan 2009 20:52:00 +0800 [thread overview]
Message-ID: <4975C8F0.7070302@gnu.org> (raw)
In-Reply-To: <f7ccd24b0901190652q625a6a50t9b80f767eee3eeb7@mail.gmail.com>
Juanma Barranquero wrote:
> I think Kevin Yu is right. Moving around in etc/HELLO, even with a lot
> of installed fonts, was quite fast until this change:
>
> 2009-01-09 Jason Rumney <jasonr@gnu.org>
>
> * w32font.c (add_font_entity_to_list): Don't report unknown
> Windows charset as any unrecognized registry. (Bug#1548)
> Only report Unicode Plane 2 fonts as unicode-sip.
>
> Now, moving in etc/HELLO is unbearably slow. I'm talking of typing
> <down> and waiting about two seconds for the cursor to move.
>
I don't see any slowness when scrolling, but it may be because I do not
have a lot of fonts installed compared with some people, or it may be
because I have fonts installed for all the languages in HELLO, so there
are no failures (which I suspect may not get cached).
One of the changes made at the same time as the above (which I
apparently forgot to add a ChangeLog entry for) was to fix the return
value of add_one_font_entity_to_list. This function was supposed to
abort the font enumeration as soon as a match was found. But previously
the logic was wrong so it was aborting if the first font did not match
the given font-spec. So in the majority of cases, it would only
enumerate one font and return nil, only if the first font matched would
it go through every font in the system and return all the fonts that
matched. After the fix, it will go through all the fonts for characters
that do not have a matching font installed, and will go through enough
fonts to find a match for others.
Since there was no visible bug previously, I wonder what use this
function is, and whether it is just wasting time looking for a match
that we already have.
next prev parent reply other threads:[~2009-01-20 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <874ozowchu.fsf@cyd.mit.edu>
2009-01-19 2:40 ` bug#1952: 23.0.60[W32-Mingw]; opening etc/HELLO is slower than before Kevin Yu
2009-01-19 14:14 ` Jason Rumney
2009-01-19 14:52 ` Juanma Barranquero
2009-01-20 12:52 ` Jason Rumney [this message]
2009-01-20 15:49 ` Juanma Barranquero
2009-01-20 16:05 ` Jason Rumney
2009-01-20 16:21 ` Juanma Barranquero
2009-01-20 2:05 ` Kevin Yu
2009-01-20 12:23 ` Jason Rumney
2009-01-24 22:50 ` bug#1952: marked as done (23.0.60[W32-Mingw];opening etc/HELLO is slower than before) Emacs bug Tracking System
2009-01-22 13:22 ` bug#1990: 23.0.60; Emacs trying too hard to find fonts that don't exist Jason Rumney
2009-01-24 13:28 ` Juanma Barranquero
2009-01-24 14:02 ` Jason Rumney
2009-01-24 22:50 ` bug#1990: marked as done (23.0.60; Emacs trying too hard to find fonts that don't exist) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4975C8F0.7070302@gnu.org \
--to=jasonr@gnu.org \
--cc=1952@emacsbugs.donarmstrong.com \
--cc=lekktu@gmail.com \
--cc=yujie052@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).