From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.bugs Subject: bug#870: Repeatable instance of bug#870 Date: Mon, 05 Jan 2009 19:22:16 +0800 Message-ID: <4961ED68.1090609__17281.827730085$1231155910$gmane$org@gnu.org> References: <4961E7F7.2000509@gnu.org> Reply-To: Jason Rumney , 870@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1231155834 17952 80.91.229.12 (5 Jan 2009 11:43:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Jan 2009 11:43:54 +0000 (UTC) Cc: 870@emacsbugs.donarmstrong.com, Emacs Devel To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 05 12:45:04 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LJntF-0004CQ-9L for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jan 2009 12:45:01 +0100 Original-Received: from localhost ([127.0.0.1]:36564 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJnrz-0004ED-MP for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jan 2009 06:43:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LJnrl-0004AV-Co for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2009 06:43:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LJnrj-0004A6-IY for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2009 06:43:28 -0500 Original-Received: from [199.232.76.173] (port=48141 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJnrj-00049v-EX for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2009 06:43:27 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47666) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LJnrh-0000gM-9J for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2009 06:43:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n05BhNtu019786; Mon, 5 Jan 2009 03:43:23 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n05BU3Vx016315; Mon, 5 Jan 2009 03:30:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Jason Rumney Original-Sender: Jason Rumney Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Mon, 05 Jan 2009 11:30:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 870 X-Emacs-PR-Package: emacs,w32 X-Emacs-PR-Keywords: Original-Received: via spool by 870-submit@emacsbugs.donarmstrong.com id=B870.123115457314992 (code B ref 870); Mon, 05 Jan 2009 11:30:03 +0000 Original-Received: (at 870) by emacsbugs.donarmstrong.com; 5 Jan 2009 11:22:53 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.188]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n05BMokY014986 for <870@emacsbugs.donarmstrong.com>; Mon, 5 Jan 2009 03:22:51 -0800 Original-Received: by ti-out-0910.google.com with SMTP id b6so5477749tic.1 for <870@emacsbugs.donarmstrong.com>; Mon, 05 Jan 2009 03:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=CGwC7ZcILPZq7JlCh/r53sJkoJRkgq0WdP+hwaimc4s=; b=hCOHg67wlW7kPqkyAYVdvkHHg2KjnR6qzCqhkSsZwxqjhLnSHB6WNaQkdVIy3eNfqs mv5MjQKuKM575oW7MOXz53FDwMzuqTV4MgtSwkkjV+pCDabTLCQR8/ixeWZB2B+w3DJw 5NznEuqnPSC5JETfA8d7VfRYJ6oYXYqQSxbUI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=f/GxOqD7DURg9Z2hmpmiv4zomXFMAAn7mkVTIsPQovg7NUgFOP0POZE7dA5DcdRc87 S2otqgcq9iiuOSQqhEalXwEL8L2+G/q/ZnmG/bClaO9SKWhNH3GMi6GaT17du8SVlqn+ tN5q61gSc9VO+a8R5Uj45rkH9im4mIDY8tLtY= Original-Received: by 10.110.105.5 with SMTP id d5mr9352171tic.11.1231154569579; Mon, 05 Jan 2009 03:22:49 -0800 (PST) Original-Received: from ?192.168.249.28? ([124.13.5.7]) by mx.google.com with ESMTPS id w5sm1033353tib.14.2009.01.05.03.22.43 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 05 Jan 2009 03:22:47 -0800 (PST) User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 05 Jan 2009 06:43:28 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23788 Archived-At: Juanma Barranquero wrote: > On Mon, Jan 5, 2009 at 11:59, Jason Rumney wrote: > > >> It appears that there is a bug in all the decode_coding_* functions when a >> CR lies on a CHARBUF_SIZE (0x4000) boundary with a matching LF on the other >> side of the boundary. >> >> They all do something like: >> >> if (eol_crlf && c1 == '\r') >> ONE_MORE_BYTE (byte_after_cr); >> >> but ONE_MORE_BYTE will abort the decode if it reaches the end of the buffer, >> leaving the CR in limbo between having been read and being added to the >> buffer. Then on decoding the subsequent block, the initial LF does not trip >> the normal CRLF decoding, so it is put into the buffer. >> > > Wouldn't that mean that, on writing the buffer, the file would end > with extra CRs, instead of missing LFs? > The CRs are effectively stripped on reading, since they end up in limbo between being read and being added to the decoding buffer. I haven't tried writing the file, but I think (from memory and from the way the code looks to me) the problem is a missing CR, not a missing LF.