unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#117: bug 117: messed up frame parameters
@ 2008-12-28 19:22 grischka
  2008-12-28 19:27 ` Drew Adams
  0 siblings, 1 reply; 16+ messages in thread
From: grischka @ 2008-12-28 19:22 UTC (permalink / raw)
  To: drew.adams; +Cc: 117

As to problems with frame sizing/positioning on windows, you can
try the attached patch. It fixes some of them.

See also bug #1348
http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1348

Regards.

########################################
--- src/keyboard.c	Sun Nov 02 11:46:21 2008
+++ src/keyboard.c	Mon Dec 08 03:32:05 2008
@@ -6875,12 +6875,14 @@
       int *addr;
       int flags;
  {
+#ifndef HAVE_NTGUI
    /* First of all, have we already counted some input?  */
    *addr = (!NILP (Vquit_flag) || readable_events (flags));

    /* If input is being read as it arrives, and we have none, there is none.  */
    if (*addr > 0 || (interrupt_input && ! interrupts_deferred))
      return;
+#endif

    /* Try to read some input and see how much we get.  */
    gobble_input (0);
@@ -7283,7 +7285,7 @@
  void
  reinvoke_input_signal ()
  {
-#ifdef SIGIO
+#if defined SIGIO || defined HAVE_NTGUI
    handle_async_input ();
  #endif
  }
########################################

########################################
--- src/w32term.c	Wed Nov 12 16:51:11 2008
+++ src/w32term.c	Mon Dec 08 03:34:23 2008
@@ -4533,7 +4534,7 @@

  		case SIZE_MAXIMIZED:
  		case SIZE_RESTORED:
-		  f->async_visible = 1;
+		  f->async_visible = IsWindowVisible(msg.msg.hwnd);
  		  f->async_iconified = 0;

  		  /* wait_reading_process_output will notice this and update
########################################

########################################
--- src/w32xfns.c	Fri Jun 27 03:13:38 2008
+++ src/w32xfns.c	Sun Dec 07 21:33:07 2008
@@ -268,6 +268,8 @@

    lpTail = lpNew;
    SetEvent (input_available);
+  PulseEvent (interrupt_handle);
+  interrupt_input_pending = 1;

    leave_crit ();

########################################









^ permalink raw reply	[flat|nested] 16+ messages in thread
* bug#117: bug 117: messed up frame parameters
@ 2008-12-28  1:32 Chong Yidong
  2008-12-28  8:02 ` Drew Adams
  0 siblings, 1 reply; 16+ messages in thread
From: Chong Yidong @ 2008-12-28  1:32 UTC (permalink / raw)
  To: Drew Adams; +Cc: 117

I can't reproduce this using the recipe you gave.

Please try to reduce the size of the test case.  One way to do this is
to define a function like this:

(defun check-frame-parameters ()
  (let (params (frame-parameters))
    (while params
      (if (assq (caar params) (cdr params))
        (error "Duplicate frame parameter found"))
      (setq params (cdr params)))))

and sprinkle (check-frame-parameters) throughout your code.  Then turn
on debug-on-error, and see when the error first appears.






^ permalink raw reply	[flat|nested] 16+ messages in thread
* bug#117: bug 117: messed up frame parameters
@ 2008-07-08 15:02 Drew Adams
  2008-07-08 20:54 ` Jason Rumney
  0 siblings, 1 reply; 16+ messages in thread
From: Drew Adams @ 2008-07-08 15:02 UTC (permalink / raw)
  To: 117

This has still not changed, in a Windows build from 2008/06/29.

This bug is listed as "normal, unclassified". IMO, this is at least as important
as bugs #47 and #120, which are listed as "important". 

This concerns not only the default face but many frame properties. It concerns a
general problem that introduces duplicate frame parameter entries with different
(incorrect) values that shadow the correct values.

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-06-29 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'

------------8<-----------------------------
From: Drew Adams Sent: Friday, May 30, 2008 3:55 PM
To: emacs-pretest-bug@gnu.org
Subject: RE: 23.0.60; messed up frame parameters

This has not changed. I get the same behavior in a Windows build from yesterday:

GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-05-29 on LENNART-69DE564

The frame parameters are wrong; there are duplicates, etc., both for the first
frame and for the special *Help* and *Completions* frames. See the detailed
descriptions and the screenshot sent previously. 

This has apparently not improved at all.







^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2008-12-28 19:27 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-28 19:22 bug#117: bug 117: messed up frame parameters grischka
2008-12-28 19:27 ` Drew Adams
  -- strict thread matches above, loose matches on Subject: below --
2008-12-28  1:32 Chong Yidong
2008-12-28  8:02 ` Drew Adams
2008-12-28  9:00   ` Chong Yidong
2008-12-28 18:15     ` Drew Adams
2008-07-08 15:02 Drew Adams
2008-07-08 20:54 ` Jason Rumney
2008-07-09 15:27   ` Drew Adams
2008-08-02 20:36     ` Drew Adams
2008-08-02 21:07       ` Jason Rumney
2008-08-02 22:08         ` Drew Adams
2008-08-27 16:41           ` Drew Adams
2008-08-28 15:04             ` Drew Adams
2008-08-30 14:38               ` Drew Adams
2008-10-31 21:05                 ` Drew Adams

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).