From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ali Bahrami Newsgroups: gmane.emacs.bugs Subject: bug#1191: How to contribute back changes for Emacs on Solaris Date: Thu, 11 Dec 2008 11:10:34 -0700 Message-ID: <4941579A.9050603@emvision.com> References: <48F80A14.7010502@emvision.com> <200812111747.mBBHl5Vb000507@mothra.ics.uci.edu> Reply-To: Ali Bahrami , 1191@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1229019966 25975 80.91.229.12 (11 Dec 2008 18:26:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Dec 2008 18:26:06 +0000 (UTC) Cc: 1191@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 11 19:27:08 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LAqFb-0004Dw-12 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2008 19:27:04 +0100 Original-Received: from localhost ([127.0.0.1]:36998 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAqEP-0007nY-A7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2008 13:25:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAqD2-0007MZ-HX for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:24:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAqD0-0007Kg-2L for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:24:23 -0500 Original-Received: from [199.232.76.173] (port=38030 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAqCz-0007KF-Px for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:24:21 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43592) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAqCy-00059y-O3 for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2008 13:24:21 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBBIOIVe026910; Thu, 11 Dec 2008 10:24:18 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mBBIF3R2023721; Thu, 11 Dec 2008 10:15:03 -0800 X-Loop: don@donarmstrong.com Resent-From: Ali Bahrami Original-Sender: Ali.Bahrami@Sun.COM Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 11 Dec 2008 18:15:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1191 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1191-submit@emacsbugs.donarmstrong.com id=B1191.122901905023275 (code B ref 1191); Thu, 11 Dec 2008 18:15:02 +0000 X-Spam-Bayes: score:0.0000 Tokens: new, 41; hammy, 150; neutral, 189; spammy, 1. spammytokens:0.987-1--flagged hammytokens:0.000-+--emacs, 0.000-+--Emacs, 0.000-+--configure, 0.000-+--lists.gnu.org, 0.000-+--listsgnuorg Original-Received: (at 1191) by emacsbugs.donarmstrong.com; 11 Dec 2008 18:10:50 +0000 Original-Received: from brmea-mail-4.sun.com (brmea-mail-4.Sun.COM [192.18.98.36]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBBIAkXY023264 for <1191@emacsbugs.donarmstrong.com>; Thu, 11 Dec 2008 10:10:47 -0800 Original-Received: from fe-amer-10.sun.com ([192.18.109.80]) by brmea-mail-4.sun.com (8.13.6+Sun/8.12.9) with ESMTP id mBBIAkW7006000 for <1191@emacsbugs.donarmstrong.com>; Thu, 11 Dec 2008 18:10:46 GMT Original-Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0KBQ00C014VAE600@mail-amer.sun.com> (original mail from ali_gnu@emvision.com) for 1191@emacsbugs.donarmstrong.com; Thu, 11 Dec 2008 11:10:46 -0700 (MST) Original-Received: from [172.20.25.67] by mail-amer.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0KBQ00EOR55UBUD0@mail-amer.sun.com>; Thu, 11 Dec 2008 11:10:42 -0700 (MST) In-reply-to: <200812111747.mBBHl5Vb000507@mothra.ics.uci.edu> User-Agent: Thunderbird 2.0.0.17 (X11/20081014) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 11 Dec 2008 13:24:23 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23193 Archived-At: Dan Nicolaescu wrote: > Ali Bahrami writes: > > > This message is a follow up to one I sent to emacs-devel > > last July: > > > > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg00070.html > > > > The question had to do with why emacs wasn't using dldump() > > to produce the dumped executable under Solaris. It had been using it > > up until 2002, at which point it was commented out, and it wasn't > > clear why. No one knew the reason, and the consensus was "try it and see". > > > > Since then, I've done some work to integrate emacs with > > OpenSolaris as a standard package. I turned on dldump(), > > and have been using the emacs binaries built with it daily > > since July without issue. > > > > So now, I have some things I'd like to send back up stream > > and get integrated into the emacs distribution: > > > > - Man pages for things installed to /usr/bin that didn't > > already have a manpage: > > b2m.1 > > ebrowse.1 > > grep-changelog.1 > > rcs-checkin.1 > > - Small changes to config.guess and configure to properly > > detect amd64 hardware running Solaris. > > - Use dldump() instead of the generic ELF dump code > > under Solaris. > > - Use the system malloc under Solaris (at least with > > amd64, emacs crashes without this). > > > > The manpages can be viewed at: > > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/b2m.1 > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/ebrowse.1 > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/grep-changelog.1 > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/man/man1/rcs-checkin.1 > > > > and the patches at: > > > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/config.guess.patch > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/configure.patch > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/dldump.patch > > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/emacs/augment/patch/sysmalloc.patch > > > > The patches are for emacs 22.1. I've examined 22.3, and the > > changes are applicable there as well. If 22.1 diffs are OK, > > that's easiest for me, but if not, then please let me know what > > I need to supply. These diffs are all very short, affecting a > > small number of lines in each file. > > > > So my questions: How can I go about submitting these changes? > > Is there someone who might work with me to get this done? > > What format would you need to get them in, and where can > > I send them? > > Your patches for the Solaris configuration are now in. > config.guess has been updated from upstream with your changes. > There's a man page for ebrowse now. > Not sure what to do about the man pages for b2m, grep-changelog, and > rcs-checkin. You might want to open a separate bug for them. > > Thanks > > --dan I'm not sure what I'll do about the manpages, but I don't consider them part of this bug anymore. So, we appear to be done, except for the issue I flagged a couple of days ago. Ben made a modification to my patch for config.guess (dropping the use of a fully qualified path for 'echo') that causes emacs to not build correctly for a Solaris user using the bash shell. It does build successfully, but will always choose to build a 64-bit binary. I sent mail to Ben about it, and we'll see what he says. However, you should probably hold off on closing things out just yet. Another thing to know is that I'm going to disappear for 3 weeks starting on Dec. 19, and will only have sporadic email access. So I hope we can get this wrapped up before I go. Thanks! - Ali