From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#32462: 26.1; Can `count-lines' be rewritten to use the newline cache? Date: Sun, 19 Aug 2018 00:10:27 +1200 Message-ID: <4940f256-d5fa-fcd3-f6b7-5be72399de11@orcon.net.nz> References: <834lftgios.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1534594156 13633 195.159.176.226 (18 Aug 2018 12:09:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Aug 2018 12:09:16 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: 32462-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 18 14:09:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fr02Z-0003Rf-93 for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Aug 2018 14:09:11 +0200 Original-Received: from localhost ([::1]:38777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fr04f-0004dn-On for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Aug 2018 08:11:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fr04R-0004bz-HF for bug-gnu-emacs@gnu.org; Sat, 18 Aug 2018 08:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fr04N-0000O9-Rh for bug-gnu-emacs@gnu.org; Sat, 18 Aug 2018 08:11:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fr04N-0000Ni-JK for bug-gnu-emacs@gnu.org; Sat, 18 Aug 2018 08:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fr04N-0007DU-6T for bug-gnu-emacs@gnu.org; Sat, 18 Aug 2018 08:11:03 -0400 Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Aug 2018 12:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 32462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 32462@debbugs.gnu.org, psainty@orcon.net.nz, psainty@orcon.net.nz Original-Received: via spool by 32462-done@debbugs.gnu.org id=D32462.153459423327626 (code D ref 32462); Sat, 18 Aug 2018 12:11:02 +0000 Original-Received: (at 32462-done) by debbugs.gnu.org; 18 Aug 2018 12:10:33 +0000 Original-Received: from localhost ([127.0.0.1]:53976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fr03s-0007BW-No for submit@debbugs.gnu.org; Sat, 18 Aug 2018 08:10:32 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:37079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fr03q-0007BF-Hb for 32462-done@debbugs.gnu.org; Sat, 18 Aug 2018 08:10:31 -0400 Original-Received: from [150.107.172.63] (port=59375 helo=[192.168.20.103]) by smtp-3.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1fr03o-0004RE-2K; Sun, 19 Aug 2018 00:10:28 +1200 In-Reply-To: <834lftgios.fsf@gnu.org> Content-Language: en-GB X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149568 Archived-At: On 18/08/18 02:40, Eli Zaretskii wrote: >> From: Phil Sainty >> `count-lines' uses a regexp search to find all the newlines (and/or >> carriage returns > > It uses regexp search only when selective-display is in effect, which > means almost never. Otherwise, it uses forward-line, which uses > scan_newline_from_point, which already uses the newline cache (unless > the cache is disabled). Ah, thanks Eli; I see that now. A look at the C code suggests that the newline cache is also a more complicated arrangement than I'd imagined, so I don't think my original thoughts about this were actually viable. I'm closing this bug.