From: martin rudalics <rudalics@gmx.at>
To: Stephen Berman <Stephen.Berman@rub.de>
Cc: 1488@emacsbugs.donarmstrong.com
Subject: bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer
Date: Thu, 04 Dec 2008 18:58:55 +0100 [thread overview]
Message-ID: <49381A5F.6070902@gmx.at> (raw)
In-Reply-To: <87fxl446mr.fsf@escher.local.home>
> However, unless I'm missing something, fit-window-to-buffer does what
> dired-pop-to-buffer's shrink-to-fit code does, and moreover also handles
> header lines.
In addition we have the problem that `split-height-threshold' can be now
nil in
((and (> (window-height (setq w2 (get-largest-window)))
split-height-threshold)
> I'm not able to fix the display code to let window-height return
> fractional line numbers, so I propose the following patch:
If there are no objections, I'll commit that in a couple of days.
> (Note that if the frame is shrunk so that not all marked file names fit
> in the *Marked Files* window, then without an oversized header line as
> is my-mm, dired-pop-to-buffer fails with the error "Attempt to delete
> minibuffer or sole ordinary window"; whereas with an oversized header
> line, this error is raised only if not even one file name can be shown.
> But I see this difference in behavior whether or not the above patch is
> applied.)
I cannot reproduce that here. That is, marking in a dired buffer more
files than there fit on the frame and typing C gives me a single-window
frame here with some files not shown - no error.
martin
next prev parent reply other threads:[~2008-12-04 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4940E3E8.8050501@gmx.at>
2008-12-04 9:44 ` bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer Stephen Berman
2008-12-04 17:23 ` Drew Adams
2008-12-04 17:58 ` martin rudalics [this message]
2008-12-04 18:33 ` martin rudalics
2008-12-05 14:25 ` martin rudalics
2008-12-05 17:27 ` Stephen Berman
2008-12-05 17:37 ` martin rudalics
2008-12-05 18:17 ` Stephen Berman
2008-12-06 19:25 ` martin rudalics
2008-12-09 20:15 ` Stephen Berman
2008-12-11 17:29 ` martin rudalics
2008-12-11 10:05 ` bug#1488: marked as done (23.0.60; dired-pop-to-buffer: use fit-window-to-buffer) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49381A5F.6070902@gmx.at \
--to=rudalics@gmx.at \
--cc=1488@emacsbugs.donarmstrong.com \
--cc=Stephen.Berman@rub.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).