From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#43609: 28.0.50; eldoc-documentation-function [vs new eldoc-display-functions] Date: Thu, 22 Oct 2020 22:37:53 -0400 Message-ID: <4923EB8C-1C2F-4802-BECB-A2AAD7F1EBCA@gmail.com> References: <2e610c3f-6e5f-c7dd-af2e-aeb5e20d8664@gmx.at> <87r1qjjppu.fsf@gmail.com> <3fa6b315-7fc0-06ee-81e9-b68d164aec1b@gmx.at> <87a6x7jf9a.fsf@gmail.com> <874knbi0jc.fsf_-_@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_C84401F8-D029-4A0D-BF86-DBF39983E3C9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9157"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43609@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 23 04:39:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVmz9-0002Hz-CC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Oct 2020 04:39:19 +0200 Original-Received: from localhost ([::1]:44948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVmz8-0004aQ-Dc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Oct 2020 22:39:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVmyu-0004aH-Au for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2020 22:39:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVmys-00026W-7N for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2020 22:39:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVmys-0005bp-5I for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2020 22:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Oct 2020 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43609 X-GNU-PR-Package: emacs Original-Received: via spool by 43609-submit@debbugs.gnu.org id=B43609.160342068321490 (code B ref 43609); Fri, 23 Oct 2020 02:39:02 +0000 Original-Received: (at 43609) by debbugs.gnu.org; 23 Oct 2020 02:38:03 +0000 Original-Received: from localhost ([127.0.0.1]:54380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVmxu-0005aX-SM for submit@debbugs.gnu.org; Thu, 22 Oct 2020 22:38:03 -0400 Original-Received: from mail-qk1-f169.google.com ([209.85.222.169]:46603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVmxs-0005a2-OC for 43609@debbugs.gnu.org; Thu, 22 Oct 2020 22:38:01 -0400 Original-Received: by mail-qk1-f169.google.com with SMTP id a23so4102192qkg.13 for <43609@debbugs.gnu.org>; Thu, 22 Oct 2020 19:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=jsBK1wOwgUBwTSIxj0LJ+vv8MOsg1w3nXBQyGlB2ads=; b=eItcdaSWP8AAsqvVEUa0iT9PjiyqbJ4UOLQW0+UpIeM+494piqLJotnzZ0a7vODjON hQVgv38k9MfLCL2YCT2EmC2ejA/yOnS4jGKBLD1mofRW+wxQ/UosMRqJxPD48IVQ/Dfz rHdx5xyaAvvuJtysNZLD6RbL9rP7JXjdFhb9TO1fwcFYQMTOgpzGIXvechzM+e+L2C1T sb0zDY60KKG+h3hpU2LHKvVxY/EeEeEjVVXG/oEQd5A/nVR+iRDKFn0DJ+KOXsoAHUDI wpyR2uZZqVL+lw2voJMj43YryQ46Z30oUMkqfhvFWZPSVzNcE6rkWSEz4nj7oenkVGgX s1/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=jsBK1wOwgUBwTSIxj0LJ+vv8MOsg1w3nXBQyGlB2ads=; b=OXgCTnkrfj/H4wSSFz5CPUTFlLzFimCCxcl6UBJ2ZujiZvRbTcYvtkngGIALJRfTFG E07z0h4kCKB4f1QwvsLzR2H5UT4M1ALGHK5XwJ57Dc12ZOPGhyD5i/NmqDGwJXzqIi+v YZfn4T5JzJA8n1JTR9FM9HmrNPV93/C4oCzYzYnw/3J+VeDY0TESSfFVszskXUYTpvbB XGghMFuaYbhmdyo5EpYnTtFHzpDBa4sab078VZ0WfRGz2fVBy8grRQD+SSKou1TcOTCr Ests2x6SOB/hEs4ZFbHxMl5LT6FWlwnsFQRC8NY2CRSbx6uNsV7RDOpqd6QuNoeuryQE vReg== X-Gm-Message-State: AOAM533rtlCi/jgwef6esoFL6s6hu04l2wA0JVEMx+kVkcg0RDbOW+FK mODDXJAp+ar5EHflM6UJUJg= X-Google-Smtp-Source: ABdhPJz/j2FuMr1BkV/a3oTACqJCdTvKN33t62j8Cm+3kazfE+oFdDCLwb0TRvJ5kgtUMu+nvdzCVQ== X-Received: by 2002:a37:a943:: with SMTP id s64mr223667qke.149.1603420675198; Thu, 22 Oct 2020 19:37:55 -0700 (PDT) Original-Received: from [192.168.1.10] (c-174-60-229-153.hsd1.pa.comcast.net. [174.60.229.153]) by smtp.gmail.com with ESMTPSA id n205sm2483978qke.43.2020.10.22.19.37.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2020 19:37:54 -0700 (PDT) In-Reply-To: <874knbi0jc.fsf_-_@gmail.com> X-Mailer: Apple Mail (2.3608.120.23.2.4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191330 Archived-At: --Apple-Mail=_C84401F8-D029-4A0D-BF86-DBF39983E3C9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Joao, If there are multiple display functions, how does Emacs decide which one = to use? Do you have ideas now about what :thing should be? Yuan Some typo I spotted: --Apple-Mail=_C84401F8-D029-4A0D-BF86-DBF39983E3C9 Content-Disposition: attachment; filename=eldoc.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="eldoc.patch" Content-Transfer-Encoding: 7bit diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el index 4c8d8222ea..356092d670 100644 --- a/lisp/emacs-lisp/eldoc.el +++ b/lisp/emacs-lisp/eldoc.el @@ -110,7 +110,7 @@ eldoc-echo-area-use-multiline-p If value is nil, a doc string is always truncated to fit in a single line of display in the echo area. -Any resizing of the echo area aditionally respects +Any resizing of the echo area additionally respects `max-mini-window-height'." :type '(radio (const :tag "Always" t) (float :tag "Fraction of frame height" 0.25) @@ -426,12 +426,12 @@ eldoc-documentation-functions (defvar eldoc-display-functions '(eldoc-display-in-echo-area eldoc-display-in-buffer) "Hook of functions tasked with displaying ElDoc results. -Each function is passed two arguments: DOCS and INTERACTIVE. DOCS -is a list (DOC ...) where DOC looks like (STRING :KEY VALUE :KEY2 -VALUE2 ...). STRING is a string containing the documentation's -text and the remainder of DOC is an optional list of -keyword-value pairs denoting additional properties of that -documention. For commonly recognized properties, see +Each function is passed two arguments: DOCS and INTERACTIVE. +DOCS is a list (DOC ...) where DOC looks like (STRING :KEY VALUE +:KEY2 VALUE2 ...). STRING is a string containing the +documentation's text and the remainder of DOC is an optional list +of keyword-value pairs denoting additional properties of that +documentation. For commonly recognized properties, see `eldoc-documentation-functions'. INTERACTIVE says if the request to display doc strings came @@ -442,9 +442,9 @@ eldoc--doc-buffer (defvar eldoc--doc-buffer-docs nil "Documentation items in `eldoc--doc-buffer'.") (defun eldoc-doc-buffer (&optional interactive) - (interactive (list t)) "Display ElDoc documentation buffer. This holds the results of the last documentation request." + (interactive (list t)) (unless (buffer-live-p eldoc--doc-buffer) (setq eldoc--doc-buffer (get-buffer-create "*eldoc*"))) (when interactive --Apple-Mail=_C84401F8-D029-4A0D-BF86-DBF39983E3C9 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_C84401F8-D029-4A0D-BF86-DBF39983E3C9--