From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#789: find-function fails on advised subrs Date: Sat, 08 Nov 2008 22:54:18 +0100 Message-ID: <49160A8A.4080406@gmx.at> References: <48B6C55F.8080104@gmx.at> Reply-To: martin rudalics , 789@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1226182227 21404 80.91.229.12 (8 Nov 2008 22:10:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Nov 2008 22:10:27 +0000 (UTC) Cc: 789@emacsbugs.donarmstrong.com To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 08 23:11:29 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kyw1g-0002dN-Rk for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Nov 2008 23:11:29 +0100 Original-Received: from localhost ([127.0.0.1]:50023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kyw0Z-0000dP-7U for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Nov 2008 17:10:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kyw0U-0000an-LO for bug-gnu-emacs@gnu.org; Sat, 08 Nov 2008 17:10:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kyw0S-0000Xh-9E for bug-gnu-emacs@gnu.org; Sat, 08 Nov 2008 17:10:13 -0500 Original-Received: from [199.232.76.173] (port=59677 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kyw0S-0000Xe-47 for bug-gnu-emacs@gnu.org; Sat, 08 Nov 2008 17:10:12 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47835) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kyw0R-0004ie-Nh for bug-gnu-emacs@gnu.org; Sat, 08 Nov 2008 17:10:12 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA8MA6EV001651; Sat, 8 Nov 2008 14:10:06 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mA8M550A000380; Sat, 8 Nov 2008 14:05:05 -0800 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 08 Nov 2008 22:05:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 789 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Original-Received: via spool by 789-submit@emacsbugs.donarmstrong.com id=B789.122618135230741 (code B ref 789); Sat, 08 Nov 2008 22:05:05 +0000 Original-Received: (at 789) by emacsbugs.donarmstrong.com; 8 Nov 2008 21:55:52 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mA8Ltmh4030735 for <789@emacsbugs.donarmstrong.com>; Sat, 8 Nov 2008 13:55:49 -0800 Original-Received: (qmail invoked by alias); 08 Nov 2008 21:55:41 -0000 Original-Received: from 62-47-59-70.adsl.highway.telekom.at (EHLO [62.47.59.70]) [62.47.59.70] by mail.gmx.net (mp008) with SMTP; 08 Nov 2008 22:55:41 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX199JQkaICJ9UStK76xck3AuKjmKdoL/6R2VthsPKn RKGrojug9Dr1Kk User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.72 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 08 Nov 2008 17:10:13 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22232 Archived-At: > Hi martin, I finally tried this... ... and I've forgotten all about it ;-) > >> ! (cond >> ! ((and (symbolp fun-or-var) (featurep 'advice) >> ! (ad-get-advice-info fun-or-var)) >> ! (setq advised t)) >> ! ((not type) >> ! (setq fun-or-var (indirect-function fun-or-var)))) > > This fails if I have an alias to an advised function. > >> ! ;; Get the real definition. >> ! (def (if (symbolp real-function) >> ! (symbol-function real-function) >> ! function)) >> ! file-name string aliases) > > file-name and string seem unused. > >> ! (cond >> ! (advised >> ! (message "This function is advised")) > > Should this function be printing if something is advised? > Again, what about aliases to advised functions? If you can think of an easy fix for these, please go ahead. Otherwise, I'll look into this next week. martin