From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#1237: 23.0.60; `switch-to-buffer-other-window' sometimes uses selected window Date: Sat, 25 Oct 2008 15:28:12 +0200 Message-ID: <49031EEC.7020809@gmx.at> References: <20081024102730.972E2B43B34@mt-computer.local> <4901BF54.6020908@gmx.at> <4901DFA1.2010503@gmx.at> <490207D7.3010100@gmx.at> Reply-To: martin rudalics , 1237@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1224942760 20411 80.91.229.12 (25 Oct 2008 13:52:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Oct 2008 13:52:40 +0000 (UTC) Cc: Markus Triska To: 1237@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 25 15:53:42 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KtjaG-0006Rs-05 for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Oct 2008 15:53:40 +0200 Original-Received: from localhost ([127.0.0.1]:51868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KtjZ8-0004M8-Pd for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Oct 2008 09:52:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KtjWp-0003p5-Ry for bug-gnu-emacs@gnu.org; Sat, 25 Oct 2008 09:50:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KtjWn-0003oh-NF for bug-gnu-emacs@gnu.org; Sat, 25 Oct 2008 09:50:07 -0400 Original-Received: from [199.232.76.173] (port=40331 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KtjWn-0003oe-If for bug-gnu-emacs@gnu.org; Sat, 25 Oct 2008 09:50:05 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47868) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KtjWm-0001pU-Ts for bug-gnu-emacs@gnu.org; Sat, 25 Oct 2008 09:50:05 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9PDo2rN013608; Sat, 25 Oct 2008 06:50:02 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9PDZ4RO009997; Sat, 25 Oct 2008 06:35:04 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 25 Oct 2008 13:35:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1237 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1237-submit@emacsbugs.donarmstrong.com id=B1237.12249413918652 (code B ref 1237); Sat, 25 Oct 2008 13:35:04 +0000 Original-Received: (at 1237) by emacsbugs.donarmstrong.com; 25 Oct 2008 13:29:51 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m9PDTksg008646 for <1237@emacsbugs.donarmstrong.com>; Sat, 25 Oct 2008 06:29:48 -0700 Original-Received: (qmail invoked by alias); 25 Oct 2008 13:29:41 -0000 Original-Received: from 62-47-38-115.adsl.highway.telekom.at (EHLO [62.47.38.115]) [62.47.38.115] by mail.gmx.net (mp028) with SMTP; 25 Oct 2008 15:29:41 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/gdZpjqO/gVdyCHweOM5t2wFz7fcrBOyABR4YnWK nfUJj2o5Xn92Ez User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: <490207D7.3010100@gmx.at> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.76 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 25 Oct 2008 09:50:07 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21890 Archived-At: > run_window_configuration_change_hook selects each window before running > the hook buffer-locally which makes any reasoning (within the function > run by the hook) about which window will be selected when the command > completes void. In addition it unwinds with select_window_norecord > which won't restore the current buffer when the selected window gets > reselected. Both of these don't explain the problem that somewhere > `select-window' must get called with norecord nil :-( OK. The reason may be twofold: `save-selected-window' may twice select a window with norecord nil: (set-frame-selected-window (car elt) (cdr elt)))) ; <--- here (if (window-live-p save-selected-window-window) (select-window save-selected-window-window)))))) <--- and here Fixing these two fixes the bug. I have to find out how to do this in an unobtrusive way though. martin, who'd never ever run `window-configuration-change-hook' buffer-locally in the first place ;-)