From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#1237: 23.0.60; `switch-to-buffer-other-window' sometimes uses selected window Date: Fri, 24 Oct 2008 19:37:27 +0200 Message-ID: <490207D7.3010100@gmx.at> References: <20081024102730.972E2B43B34@mt-computer.local> <4901BF54.6020908@gmx.at> <4901DFA1.2010503@gmx.at> Reply-To: martin rudalics , 1237@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1224870628 9346 80.91.229.12 (24 Oct 2008 17:50:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Oct 2008 17:50:28 +0000 (UTC) Cc: 1237@emacsbugs.donarmstrong.com To: Markus Triska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 24 19:51:28 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KtQol-0005o3-2u for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Oct 2008 19:51:23 +0200 Original-Received: from localhost ([127.0.0.1]:34908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KtQnf-0001eA-6k for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Oct 2008 13:50:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KtQnb-0001di-Ld for bug-gnu-emacs@gnu.org; Fri, 24 Oct 2008 13:50:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KtQnX-0001bn-DP for bug-gnu-emacs@gnu.org; Fri, 24 Oct 2008 13:50:11 -0400 Original-Received: from [199.232.76.173] (port=36162 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KtQnW-0001bg-Qq for bug-gnu-emacs@gnu.org; Fri, 24 Oct 2008 13:50:06 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:56883) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KtQnV-00066Y-TO for bug-gnu-emacs@gnu.org; Fri, 24 Oct 2008 13:50:06 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9OHo2UO005915; Fri, 24 Oct 2008 10:50:02 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9OHj3Y1004832; Fri, 24 Oct 2008 10:45:03 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 24 Oct 2008 17:45:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1237 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1237-submit@emacsbugs.donarmstrong.com id=B1237.12248699353522 (code B ref 1237); Fri, 24 Oct 2008 17:45:03 +0000 Original-Received: (at 1237) by emacsbugs.donarmstrong.com; 24 Oct 2008 17:38:55 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m9OHcpYZ003516 for <1237@emacsbugs.donarmstrong.com>; Fri, 24 Oct 2008 10:38:52 -0700 Original-Received: (qmail invoked by alias); 24 Oct 2008 17:38:45 -0000 Original-Received: from 88-117-43-164.adsl.highway.telekom.at (EHLO [88.117.43.164]) [88.117.43.164] by mail.gmx.net (mp014) with SMTP; 24 Oct 2008 19:38:45 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+ABWBfCBaAPbksrFyH8X1GP8yNDHDJGc1V7QAH0L 7AwRYKBUq1Pzb6 User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.71 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 24 Oct 2008 13:50:11 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21870 Archived-At: > (defun my-walk () (walk-windows 'identity)) > > (add-hook 'window-configuration-change-hook 'my-walk nil t) > > (split-window) > > (switch-to-buffer-other-window "test") > > If you put these forms in the *scratch* buffer of "emacs -Q" and then > evaluate them one after another, you should be able to see the problem. > The problem does not occur if the hook is NOT made buffer-local. Yes. Replacing `split-window' by (progn (split-window) (message "sel %s .. lru %s" (selected-window) (get-lru-window))) shows the problem immediately. Everything seems alright when you put that message into my-walk. run_window_configuration_change_hook selects each window before running the hook buffer-locally which makes any reasoning (within the function run by the hook) about which window will be selected when the command completes void. In addition it unwinds with select_window_norecord which won't restore the current buffer when the selected window gets reselected. Both of these don't explain the problem that somewhere `select-window' must get called with norecord nil :-( martin