From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#72404: 30.0.60; Customization of options is broken Date: Wed, 1 Jan 2025 08:31:14 -0300 Message-ID: <48d661cd-a77f-4974-95d8-0672cc1c73e2@gmail.com> References: <86a5hxv6cp.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------qYDWOXk9a5a0FUngty9ZQpji" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14488"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , Stephen Berman , jm@pub.pink, juri@linkov.net To: 72404@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 01 12:32:34 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSwxl-0003dD-Gj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Jan 2025 12:32:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSwxK-0005rg-9H; Wed, 01 Jan 2025 06:32:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSwxG-0005rS-Oe for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 06:32:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSwxG-0000Px-D7 for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 06:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=From:MIME-Version:Date:To:In-Reply-To:References:Subject; bh=3GBguq4ORPlRgv6hy3v8IaqxxoJGhO7i8hGZFy5HrbI=; b=JTujzo3aKpMTOjfzlvctRyDUKOJcKZvjN/JIA19RuSgkyPPZc9BoJ8XfEZCywjxCuWloeFdEoniCIAXtuLVTVBa0edz115nWjqkM9IWRctpaNb9MqVz7Nu36PKD/9sF8yp/3wY+py6MBiKUxkrb2lsssY125VP11F+C5I2MmkjmJE6Vy4w/xZoFH3iMlm86AjZDTjY5KScOGkVKpjN48TrM/Nb1aVwNFL9zGNblhkHfWQnFr7f91LAkfXOlGzXUOe1uNIMQVO7Z6Sgo6CfQz8G84GMa8BHYv7jKDUPB3JFKsH1FYenJCAqLrSPLSUvCpinHu9MvHGyfnJFcaNoEwRg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tSwxG-0000C9-83 for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 06:32:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <86a5hxv6cp.fsf@mail.linkov.net> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Jan 2025 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72404 X-GNU-PR-Package: emacs Original-Received: via spool by 72404-submit@debbugs.gnu.org id=B72404.1735731087699 (code B ref 72404); Wed, 01 Jan 2025 11:32:02 +0000 Original-Received: (at 72404) by debbugs.gnu.org; 1 Jan 2025 11:31:27 +0000 Original-Received: from localhost ([127.0.0.1]:37888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSwwh-0000BD-56 for submit@debbugs.gnu.org; Wed, 01 Jan 2025 06:31:27 -0500 Original-Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:48492) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tSwwe-0000Az-PX for 72404@debbugs.gnu.org; Wed, 01 Jan 2025 06:31:26 -0500 Original-Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-21a1e6fd923so94963105ad.1 for <72404@debbugs.gnu.org>; Wed, 01 Jan 2025 03:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735731078; x=1736335878; darn=debbugs.gnu.org; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3GBguq4ORPlRgv6hy3v8IaqxxoJGhO7i8hGZFy5HrbI=; b=dHGhn5U1v25ReMDgI8l+hTR6Awgx5OhbrR3L4de3dGGcGaO4qviYR34ALol/LnrAy3 beew1oXUEBfiXMRFBB9bzcXkgmJRdXg/DatuNmOq3ARRMTfZJeVFe9dXc6CLpaCkWwi8 UUDfjmWH7eE5b22TT6WQHen3mOC0Ohfhozyd8NeVnwrWCflFP/zkG84fw10W8HWIn43U sfn/RQhw4wAJv+mt/fRBz8WVWikkoUshcsU74K54glRlXZDBeHZ3FE/s41lq8LPhF8Ww FaBtUhGzmDAPhas8OOBYhiEWrLmaY6G51t5UiZZe14SCeL5mkHEkGkXb3arlvU66wHId gTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735731078; x=1736335878; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3GBguq4ORPlRgv6hy3v8IaqxxoJGhO7i8hGZFy5HrbI=; b=EFcBCjYv4D/9GpeQ1TIdM9XR/JPjB8RvCjyXTISjqWVf6qDl0OL64VxwGwz7JuFS8H CDhvvvXYvgv2w52iRx7Kvr6XQayd/eSTnTXIiw0nRDbUj2J+ulB5oafl+xy9EUTwEGQR yTy37TWkx7dOG+fKCMB/bkK1Ap3b5jmPdagMGd/av5+Ou+SozLHprDl0mpMMOQCz1K5C noYZqes/rRVjB0TYOnBe/bT/xmyHa0Bv5Ou1xjW92oueDAqhcNvecMCwpmoXRNiJdYeO XeIRMFEYt7ejprXdWFFoJOHBCusXMbhdDKlof4omLLF3OZVPQwLKd1oPwC1l7GREzRxg ZSRA== X-Gm-Message-State: AOJu0Yy1aFMUHmjaSccYGyWfDa4dePZ75CFNci1smxFmhpL/10jj79dL 6iZhBoOD3vL9Gc+UMD6i8IElgKy1wJL4qaxGcfvQIWsy6jn70fY4e8qRnDxoQgc= X-Gm-Gg: ASbGncsN886ssv0A1faCX8akIPXRgjT//xhDqODZNP0eNn5IsnMJQin1FLhHOKA5Ikz AZccB16bbsUSduuWd5DukTq5FgEO6HVQGhEKkTnKAXmBuJ+uEizqR9rCjd7G+NXuIQ94n1XnaX4 mNRDvBbP5CA+iZ92WISZlrPLo45csj/T7p66JoVX36iNJ1KpDmsfuCwCLz366A1itE4ofN1gpH6 /7dj/tSFETXELVMlnzeMnIu+zrTRMq/SreR6r2KstQ8KGrhb95Twgqlt9tMCw4= X-Google-Smtp-Source: AGHT+IG6xFCNW2fdXUVgvXBdOVqjQMPtq+xfY/N7danAu6V/uccuEUFI4c++UQIUpGj1o9aqwesvcA== X-Received: by 2002:a17:902:dace:b0:216:3732:ade3 with SMTP id d9443c01a7336-219e6f25fd1mr581751735ad.35.1735731078246; Wed, 01 Jan 2025 03:31:18 -0800 (PST) Original-Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02b27sm207084315ad.276.2025.01.01.03.31.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jan 2025 03:31:17 -0800 (PST) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298062 Archived-At: This is a multi-part message in MIME format. --------------qYDWOXk9a5a0FUngty9ZQpji Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Stephen Berman writes: > On Sun, 04 Aug 2024 10:49:52 +0300 Eli Zaretskii wrote: > >>> From: Stephen Berman >>> Cc: john muhl , juri@linkov.net,  maurooaranda@gmail.com, >>>   72404@debbugs.gnu.org >>> Date: Thu, 01 Aug 2024 19:28:04 +0200 >>> >>> On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman wrote: >>> >>> I did happen to have a bit more time for this problem, and I think I've >>> found the cause, a single line in commit 8d354925ddb: >>> >>> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el >>> index 693991a6f3e..aa653549dad 100644 >>> --- a/lisp/wid-edit.el >>> +++ b/lisp/wid-edit.el >>> @@ -2549,7 +2549,8 @@ widget-checklist-add-item >>>                  (t >>>                   (widget-create-child-value >>>                    widget type (car (cdr chosen))) >>> - (widget-specify-selected child))))) >>> +                             ;; (widget-specify-selected child) >>> +                             )))) >>>             (t >>>          (error "Unknown escape `%c'" escape))))) >>>       ;; Update properties. >>> >>> With this line commented out as in the above patch, I get the expected >>> value when carrying out Juri's recipe.  Moreover, after making that >>> change, I then briefly tested customizing the face widget-unselected >>> (which the problematic commit added) to inherit from the default face >>> and it shows the labels of unselected check boxes in the default face, >>> as it should.  So maybe deleting the commented out line above and >>> leaving the rest of the change is a sufficient fix.  But I have to admit >>> I don't know why that line causes the problem, and I haven't done enough >>> testing of this change to the widget-unselected face feature, so this is >>> just a status report. >> >> Thanks, I installed the above fix. > > Thanks, this seems at least a plausible stopgap. > >> It turns out the same problem also caused bug#72156, so I've now >> merged them. >> >> I'm leaving this bug open, in the hope that you or someone else will >> find the root cause for the regression and fix it. > > I will try to debug it further, but I do hope Mauro or someone else more > familiar with the widget and custom code than I am will look into it. > > Steve Berman Looks to me that it's a matter of order of function calls.  The return value of widget-create-child-value was used for setting child. I found this by using widget-browse-at at the checkbox.  I navigated to the checkbox parent, the set widget, and saw that only the unselected children were specified as children of the set widget. The attached patch should fix it. --------------qYDWOXk9a5a0FUngty9ZQpji Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-checkbox-s-child-creation.patch" Content-Disposition: attachment; filename="0001-Fix-checkbox-s-child-creation.patch" Content-Transfer-Encoding: base64 RnJvbSA4YjFjMTk1NDBjNWVmODczMDYyZTkzODlhY2IxNTZkYWZjNGY4NzVjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFdlZCwgMSBKYW4gMjAyNSAwODoyMjo0NSAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIEZpeCBjaGVja2JveCdzIGNoaWxkIGNyZWF0aW9uCgoqIGxpc3Avd2lkLWVkaXQu ZWwgKHdpZGdldC1jaGVja2xpc3QtYWRkLWl0ZW0pOiBTd2FwIGZ1bmN0aW9uCmNhbGxzIHNv IHRoYXQgY2hpbGQgaXMgYWN0dWFsbHkgYSB3aWRnZXQuICAoQnVnIzcyMTU2KQotLS0KIGxp c3Avd2lkLWVkaXQuZWwgfCA5ICsrKy0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3dpZC1lZGl0LmVs IGIvbGlzcC93aWQtZWRpdC5lbAppbmRleCBiZjNhMTE0MWJhZi4uM2FjYjc3ZGQ3ZGIgMTAw NjQ0Ci0tLSBhL2xpc3Avd2lkLWVkaXQuZWwKKysrIGIvbGlzcC93aWQtZWRpdC5lbApAQCAt MjU0OSwxMiArMjU0OSw5IEBAIHdpZGdldC1jaGVja2xpc3QtYWRkLWl0ZW0KIAkJCSAgICAg KHdpZGdldC1jcmVhdGUtY2hpbGQtdmFsdWUKIAkJCSAgICAgIHdpZGdldCB0eXBlIChjZHIg Y2hvc2VuKSkpCiAJCQkgICAgKHQKLQkJCSAgICAgKHdpZGdldC1jcmVhdGUtY2hpbGQtdmFs dWUKLQkJCSAgICAgIHdpZGdldCB0eXBlIChjYXIgKGNkciBjaG9zZW4pKSkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgOzsgVGhpcyBzb21laG93IGJyZWFrcyA6b3B0aW9ucyBh bmQgb3RoZXIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgQ3VzdG9tIGZlYXR1 cmVzLgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyAod2lkZ2V0LXNwZWNpZnkt c2VsZWN0ZWQgY2hpbGQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICkpKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1zcGVjaWZ5LXNlbGVjdGVkIGNo aWxkKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LWNyZWF0ZS1jaGls ZC12YWx1ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd2lkZ2V0IHR5cGUgKGNh ciAoY2RyIGNob3NlbikpKSkpKSkKIAkgICAgICAgKHQKIAkJKGVycm9yICJVbmtub3duIGVz Y2FwZSBgJWMnIiBlc2NhcGUpKSkpKQogICAgICA7OyBVcGRhdGUgcHJvcGVydGllcy4KLS0g CjIuMzQuMQoK --------------qYDWOXk9a5a0FUngty9ZQpji--