bug#598: 23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

[martin rudalics <rudalics@gmx.at>]

 > Unfortunately, even after a maintainer-clean + make bootstrap, the issue is not
 > resolved for me.  In fact, the very first run of the new emacs
 > resulted in a frame that
 > was 168x61 instead of 132x57 (is that 132x60->132x57 as a result of
 > menu/toolbars
 > considered a bug or a feature?).

Could you try commenting out the code below from x_figure_window_size in
frame.c and tell whether and how the behavior changes?

   if (toolbar_p && FRAME_TOOL_BAR_LINES (f))
     {
       int margin, relief, bar_height;

       relief = (tool_bar_button_relief >= 0
		? tool_bar_button_relief
		: DEFAULT_TOOL_BAR_BUTTON_RELIEF);

       if (INTEGERP (Vtool_bar_button_margin)
	  && XINT (Vtool_bar_button_margin) > 0)
	margin = XFASTINT (Vtool_bar_button_margin);
       else if (CONSP (Vtool_bar_button_margin)
	       && INTEGERP (XCDR (Vtool_bar_button_margin))
	       && XINT (XCDR (Vtool_bar_button_margin)) > 0)
	margin = XFASTINT (XCDR (Vtool_bar_button_margin));
       else
	margin = 0;

       bar_height = DEFAULT_TOOL_BAR_IMAGE_HEIGHT + 2 * margin + 2 * relief;
       FRAME_LINES (f) += (bar_height + FRAME_LINE_HEIGHT (f) - 1) / FRAME_LINE_HEIGHT (f);
     }

martin