From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 1073@emacsbugs.donarmstrong.com, Lawrence Mitchell <wence@gmx.li>
Subject: bug#1073: 23.0.60; Bad interaction between compilation-scroll-output and dedicated windows
Date: Sun, 05 Oct 2008 20:58:09 +0200 [thread overview]
Message-ID: <48E90E41.4050502@gmx.at> (raw)
In-Reply-To: <jwvy713lv7v.fsf-monnier+emacsbugreports@gnu.org>
> I think the select-window thingy is/was needed in order to make sure we
> move point in the relevant window, rather than just moving point in the
> relevant buffer.
> So maye something like:
>
> (with-selected-window outwin
> (with-current-buffer (window-buffer outwin)
> ...))
>
> would be better.
The original code had
(goto-char (point-max))
which moves point in all windows showing the relevant buffer. In that
sense I didn't change the semantics of the original code.
IIUC you want something similar to the
;; Position point as the user will see it.
(let ((desired-visible-point
;; Put it at the end if `compilation-scroll-output' is set.
(if compilation-scroll-output
(point-max)
;; Normally put it at the top.
(point-min))))
(if (eq outwin (selected-window))
(goto-char desired-visible-point)
(set-window-point outwin desired-visible-point)))
stuff a few lines above? Or am I missing something?
martin
next prev parent reply other threads:[~2008-10-05 18:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48E74069.6000809@gmx.at>
2008-10-03 9:20 ` bug#1073: 23.0.60; Bad interaction between compilation-scroll-output and dedicated windows Lawrence Mitchell
2008-10-03 12:36 ` martin rudalics
2008-10-03 13:01 ` Lawrence Mitchell
2008-10-03 13:18 ` martin rudalics
2008-10-03 15:48 ` Lawrence Mitchell
2008-10-03 13:18 ` Lennart Borgman (gmail)
2008-10-03 13:42 ` martin rudalics
2008-10-03 13:46 ` Lennart Borgman (gmail)
2008-10-03 14:29 ` martin rudalics
2008-10-03 14:49 ` Lennart Borgman (gmail)
2008-10-05 0:54 ` Stefan Monnier
2008-10-05 18:58 ` martin rudalics [this message]
2008-10-04 10:15 ` bug#1073: marked as done (23.0.60; Bad interaction between compilation-scroll-output and dedicated windows) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E90E41.4050502@gmx.at \
--to=rudalics@gmx.at \
--cc=1073@emacsbugs.donarmstrong.com \
--cc=monnier@iro.umontreal.ca \
--cc=wence@gmx.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).