From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#1073: 23.0.60; Bad interaction between compilation-scroll-output and dedicated windows Date: Fri, 03 Oct 2008 15:18:28 +0200 Message-ID: <48E61BA4.2020509@gmx.at> References: <48E611C7.7020901@gmx.at> Reply-To: martin rudalics , 1073@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030606060209070003050209" X-Trace: ger.gmane.org 1223040684 12391 80.91.229.12 (3 Oct 2008 13:31:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Oct 2008 13:31:24 +0000 (UTC) Cc: 1073@emacsbugs.donarmstrong.com To: Lawrence Mitchell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 03 15:32:12 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KlklI-00016C-4o for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Oct 2008 15:32:04 +0200 Original-Received: from localhost ([127.0.0.1]:38555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KlkkE-0000jh-Vg for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Oct 2008 09:30:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KlkjM-0000Ok-Uy for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 09:30:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KlkjJ-0000N0-O4 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 09:30:03 -0400 Original-Received: from [199.232.76.173] (port=49813 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KlkjJ-0000MP-4X for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 09:30:01 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38085) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KlkjH-0000Ny-BZ for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2008 09:30:00 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m93DTuok021045; Fri, 3 Oct 2008 06:29:57 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m93DP6IW019977; Fri, 3 Oct 2008 06:25:06 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 03 Oct 2008 13:25:06 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1073 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1073-submit@emacsbugs.donarmstrong.com id=B1073.122304000418662 (code B ref 1073); Fri, 03 Oct 2008 13:25:06 +0000 Original-Received: (at 1073) by emacsbugs.donarmstrong.com; 3 Oct 2008 13:20:04 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m93DJtJr018520 for <1073@emacsbugs.donarmstrong.com>; Fri, 3 Oct 2008 06:19:57 -0700 Original-Received: (qmail invoked by alias); 03 Oct 2008 13:19:50 -0000 Original-Received: from 62-47-55-7.adsl.highway.telekom.at (EHLO [62.47.55.7]) [62.47.55.7] by mail.gmx.net (mp014) with SMTP; 03 Oct 2008 15:19:50 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19c7TJMzZRc1agFOE2wgldAFza2W/GhiZb18loT7N crP4kMBAPZ2/Xh User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.78,0.67 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 03 Oct 2008 09:30:03 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21037 Archived-At: This is a multi-part message in MIME format. --------------030606060209070003050209 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > The attached patch fixes the observed problem, however, I do not > think that it is entirely correct: > > [...] >> ! >> ! (with-current-buffer (window-buffer outwin) >> ! (when (local-variable-p 'compilation-scroll-output) > > local-variable-p will return t if compilation-scroll-output is > nil, but buffer-local. You're right. > I think you mean > (when (buffer-local-value 'compilation-scroll-output (current-buffer)) Not really. This would be t in *test*, I suppose. Try the attached one instead, please. Thanks, martin. --------------030606060209070003050209 Content-Type: text/plain; name="1073.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="1073.diff" *** progmodes/compile.el.~1.476.~ 2008-06-13 18:22:16.000000000 +0200 --- progmodes/compile.el 2008-10-03 15:11:15.406250000 +0200 *************** *** 1280,1289 **** (cons proc compilation-in-progress)))) ;; Now finally cd to where the shell started make/grep/... (setq default-directory thisdir)) ! (if (buffer-local-value 'compilation-scroll-output outbuf) ! (save-selected-window ! (select-window outwin) ! (goto-char (point-max)))) ;; Make it so the next C-x ` will use this buffer. (setq next-error-last-buffer outbuf))) --- 1280,1291 ---- (cons proc compilation-in-progress)))) ;; Now finally cd to where the shell started make/grep/... (setq default-directory thisdir)) ! ! (with-current-buffer (window-buffer outwin) ! (when (and (local-variable-p 'compilation-scroll-output) ! compilation-scroll-output) ! (goto-char (point-max)))) ! ;; Make it so the next C-x ` will use this buffer. (setq next-error-last-buffer outbuf))) --------------030606060209070003050209--