From: martin rudalics <rudalics@gmx.at>
To: Lawrence Mitchell <wence@gmx.li>
Cc: 1073@emacsbugs.donarmstrong.com
Subject: bug#1073: 23.0.60; Bad interaction between compilation-scroll-output and dedicated windows
Date: Fri, 03 Oct 2008 15:18:28 +0200 [thread overview]
Message-ID: <48E61BA4.2020509@gmx.at> (raw)
In-Reply-To: <?fnord?y3h6ljx596ix.fsf@ID-97657.user.individual.net>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
> The attached patch fixes the observed problem, however, I do not
> think that it is entirely correct:
>
> [...]
>> !
>> ! (with-current-buffer (window-buffer outwin)
>> ! (when (local-variable-p 'compilation-scroll-output)
>
> local-variable-p will return t if compilation-scroll-output is
> nil, but buffer-local.
You're right.
> I think you mean
> (when (buffer-local-value 'compilation-scroll-output (current-buffer))
Not really. This would be t in *test*, I suppose. Try the attached one
instead, please.
Thanks, martin.
[-- Attachment #2: 1073.diff --]
[-- Type: text/plain, Size: 1030 bytes --]
*** progmodes/compile.el.~1.476.~ 2008-06-13 18:22:16.000000000 +0200
--- progmodes/compile.el 2008-10-03 15:11:15.406250000 +0200
***************
*** 1280,1289 ****
(cons proc compilation-in-progress))))
;; Now finally cd to where the shell started make/grep/...
(setq default-directory thisdir))
! (if (buffer-local-value 'compilation-scroll-output outbuf)
! (save-selected-window
! (select-window outwin)
! (goto-char (point-max))))
;; Make it so the next C-x ` will use this buffer.
(setq next-error-last-buffer outbuf)))
--- 1280,1291 ----
(cons proc compilation-in-progress))))
;; Now finally cd to where the shell started make/grep/...
(setq default-directory thisdir))
!
! (with-current-buffer (window-buffer outwin)
! (when (and (local-variable-p 'compilation-scroll-output)
! compilation-scroll-output)
! (goto-char (point-max))))
!
;; Make it so the next C-x ` will use this buffer.
(setq next-error-last-buffer outbuf)))
next prev parent reply other threads:[~2008-10-03 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48E74069.6000809@gmx.at>
2008-10-03 9:20 ` bug#1073: 23.0.60; Bad interaction between compilation-scroll-output and dedicated windows Lawrence Mitchell
2008-10-03 12:36 ` martin rudalics
2008-10-03 13:01 ` Lawrence Mitchell
2008-10-03 13:18 ` martin rudalics [this message]
2008-10-03 15:48 ` Lawrence Mitchell
2008-10-03 13:18 ` Lennart Borgman (gmail)
2008-10-03 13:42 ` martin rudalics
2008-10-03 13:46 ` Lennart Borgman (gmail)
2008-10-03 14:29 ` martin rudalics
2008-10-03 14:49 ` Lennart Borgman (gmail)
2008-10-05 0:54 ` Stefan Monnier
2008-10-05 18:58 ` martin rudalics
2008-10-04 10:15 ` bug#1073: marked as done (23.0.60; Bad interaction between compilation-scroll-output and dedicated windows) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E61BA4.2020509@gmx.at \
--to=rudalics@gmx.at \
--cc=1073@emacsbugs.donarmstrong.com \
--cc=wence@gmx.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).