From: martin rudalics <rudalics@gmx.at>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 1032@emacsbugs.donarmstrong.com
Subject: bug#1032: foreground-color in default-frame-alist affects tooltips, while background-color does not
Date: Fri, 26 Sep 2008 17:14:28 +0200 [thread overview]
Message-ID: <48DCFC54.7060809@gmx.at> (raw)
In-Reply-To: <f7ccd24b0809260140o24250681w94a6e4dfae5d49c7@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
> With
>
> (setq default-frame-alist
> '((background-mode . dark)
> (background-color . "black")
> (foreground-color . "white")))
>
> the tooltip text foreground is white, but the background is still the
> default lightyellow, so the text is not visible.
Does the attached patch fix it?
martin
[-- Attachment #2: 1032.diff --]
[-- Type: text/plain, Size: 1423 bytes --]
*** w32fns.c.~1.347.~ 2008-09-19 23:24:49.062500000 +0200
--- w32fns.c 2008-09-26 17:10:10.953125000 +0200
***************
*** 5532,5546 ****
attribute of the frame get's set, which let's the internal border
of the tooltip frame appear in pink. Prevent this. */
{
Lisp_Object bg = Fframe_parameter (frame, Qbackground_color);
/* Set tip_frame here, so that */
tip_frame = frame;
call2 (Qface_set_after_frame_default, frame, Qnil);
! if (!EQ (bg, Fframe_parameter (frame, Qbackground_color)))
! Fmodify_frame_parameters (frame, Fcons (Fcons (Qbackground_color, bg),
! Qnil));
}
f->no_split = 1;
--- 5532,5549 ----
attribute of the frame get's set, which let's the internal border
of the tooltip frame appear in pink. Prevent this. */
{
+ Lisp_Object fg = Fframe_parameter (frame, Qforeground_color);
Lisp_Object bg = Fframe_parameter (frame, Qbackground_color);
/* Set tip_frame here, so that */
tip_frame = frame;
call2 (Qface_set_after_frame_default, frame, Qnil);
! if (!EQ (bg, Fframe_parameter (frame, Qbackground_color))
! || !EQ (fg, Fframe_parameter (frame, Qforeground_color)))
! Fmodify_frame_parameters (frame, (Fcons (Qforeground_color, fg),
! (Fcons (Qbackground_color, bg),
! Qnil)));
}
f->no_split = 1;
next prev parent reply other threads:[~2008-09-26 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7ccd24b0810291843l2edc56fbx3b275a029ba0ee81@mail.gmail.com>
2008-09-26 8:40 ` bug#1032: foreground-color in default-frame-alist affects tooltips, while background-color does not Juanma Barranquero
2008-09-26 15:14 ` martin rudalics [this message]
2008-09-26 15:34 ` Juanma Barranquero
2008-09-26 16:13 ` martin rudalics
2008-09-26 19:03 ` Juanma Barranquero
2008-10-30 1:50 ` bug#1032: marked as done (foreground-color in default-frame-alist affects tooltips, while background-color does not) Emacs bug Tracking System
2008-10-30 7:24 ` bug#1032: foreground-color in default-frame-alist affects tooltips, while background-color does not martin rudalics
2008-10-30 10:24 ` Juanma Barranquero
2008-10-30 11:40 ` martin rudalics
2008-10-30 11:55 ` Juanma Barranquero
2008-10-30 15:48 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DCFC54.7060809@gmx.at \
--to=rudalics@gmx.at \
--cc=1032@emacsbugs.donarmstrong.com \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).