From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#731: 23.0.60; Varying point position after undo Date: Mon, 22 Sep 2008 17:59:14 +0200 Message-ID: <48D7C0D2.7030804@gmx.at> References: <20080918232637.dyy4dg5nhiwgs4s4@webmail.mit.edu> <48D36604.7020702@gmx.at> <48D636ED.3020103@gmx.at> Reply-To: martin rudalics , 731@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1222149039 5399 80.91.229.12 (23 Sep 2008 05:50:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Sep 2008 05:50:39 +0000 (UTC) Cc: Markus Triska , 731@emacsbugs.donarmstrong.com, cyd@MIT.EDU To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 23 07:51:36 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ki0oB-0002rv-KT for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Sep 2008 07:51:35 +0200 Original-Received: from localhost ([127.0.0.1]:60890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ki0n9-0001aa-V9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Sep 2008 01:50:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ki0mf-0001GZ-5Z for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2008 01:50:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ki0md-0001F8-3Y for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2008 01:50:00 -0400 Original-Received: from [199.232.76.173] (port=53398 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ki0mc-0001Ew-Jo for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2008 01:49:58 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:52987) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ki0mb-0000sK-Tv for bug-gnu-emacs@gnu.org; Tue, 23 Sep 2008 01:49:58 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8N5nrDn031980; Mon, 22 Sep 2008 22:49:53 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m8N5Z3Qj028466; Mon, 22 Sep 2008 22:35:03 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 23 Sep 2008 05:35:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 731 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 731-submit@emacsbugs.donarmstrong.com id=B731.122214773127075 (code B ref 731); Tue, 23 Sep 2008 05:35:02 +0000 Original-Received: (at 731) by emacsbugs.donarmstrong.com; 23 Sep 2008 05:28:51 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m8N5Slfk027065 for <731@emacsbugs.donarmstrong.com>; Mon, 22 Sep 2008 22:28:49 -0700 Original-Received: (qmail invoked by alias); 22 Sep 2008 16:02:00 -0000 Original-Received: from 62-47-50-128.adsl.highway.telekom.at (EHLO [62.47.50.128]) [62.47.50.128] by mail.gmx.net (mp015) with SMTP; 22 Sep 2008 18:02:00 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX188sQI6txE8EbA2xBMb6VJgpjHH3oMSURB+CkJmoo PhxzUAKLl7yoEk User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.78 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 23 Sep 2008 01:50:00 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20704 Archived-At: > Hmm.. the comment seems to say that calling it is just redundant, > whereas this thread shows that it can actually be harmful. > Could you improve the comment so as to explain why it's harmful? I checked it in with a slightly more accurate comment. IMHO, however, last_boundary_buffer and last_boundary_position should be documented better. In particular, I don't understand the comment near the end of record_point saying /* If we are just after an undo boundary, and point wasn't at start of deleted range, record where it was. */ BTW, why isn't there a separate last_boundary_position for each buffer? martin