bug#867: 23.0.60; isearch string not quoted in M-s h r

bug#867: 23.0.60; isearch string not quoted in M-s h r

[Lennart Borgman (gmail)]

If you do for example

  C-s some. M-s h r

then the search string from isearch is not quoted when highlight-regexp
gets it which means it will match for example "something".



In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-09-02
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'

bug#867: 23.0.60; isearch string not quoted in M-s h r

[Chong Yidong]

> If you do for example
>
>   C-s some. M-s h r
>
> then the search string from isearch is not quoted when
> highlight-regexp gets it which means it will match for example
> "something".

I don't understand.  How is this a bug?

bug#867: 23.0.60; isearch string not quoted in M-s h r

[Lennart Borgman (gmail)]

Chong Yidong wrote:
>> If you do for example
>>
>>   C-s some. M-s h r
>>
>> then the search string from isearch is not quoted when
>> highlight-regexp gets it which means it will match for example
>> "something".
> 
> I don't understand.  How is this a bug?

C-s and then "some." just matches the string "some.". If it is converted
to a regexp without quoting it will also match "somet" and that was not
what the user wanted.

I think this worked before. Something went wrong when you (was it you?)
took care of the case insensitive problem.

bug#867: marked as done (23.0.60; isearch string not quoted in M-s h r)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]


Your message dated Tue, 02 Sep 2008 20:05:35 -0400
with message-id <877i9u14c0.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; isearch string not quoted in M-s h r
has caused the Emacs bug report #867,
regarding 23.0.60; isearch string not quoted in M-s h r
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
867: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=867
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2768 bytes --]

From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; isearch string not quoted in M-s h r
Date: Tue, 02 Sep 2008 20:57:30 +0200
Message-ID: <48BD8C9A.5040707@gmail.com>

If you do for example

  C-s some. M-s h r

then the search string from isearch is not quoted when highlight-regexp
gets it which means it will match for example "something".



In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-09-02
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'



[-- Attachment #3: Type: message/rfc822, Size: 1919 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Lennart Borgman \(gmail\)" <lennart.borgman@gmail.com>
Cc: 867-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; isearch string not quoted in M-s h r
Date: Tue, 02 Sep 2008 20:05:35 -0400
Message-ID: <877i9u14c0.fsf@cyd.mit.edu>

"Lennart Borgman (gmail)" <lennart.borgman@gmail.com> writes:

> Chong Yidong wrote:
>>> If you do for example
>>>
>>>   C-s some. M-s h r
>>>
>>> then the search string from isearch is not quoted when
>>> highlight-regexp gets it which means it will match for example
>>> "something".
>> 
>> I don't understand.  How is this a bug?
>
> C-s and then "some." just matches the string "some.". If it is
> converted to a regexp without quoting it will also match "somet" and
> that was not what the user wanted.
>
> I think this worked before. Something went wrong when you (was it
> you?)  took care of the case insensitive problem.

OK, now I understand.  I've checked in a fix.  Thanks for spotting this.