From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#810: 23.0.60; atomic-change-group narrowing problem Date: Mon, 01 Sep 2008 23:20:29 +0200 Message-ID: <48BC5C9D.9000008@gmx.at> References: <48B6F562.9060006@gmail.com> <48BC2CE6.2070108@gmx.at> Reply-To: martin rudalics , 810@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1220305747 23005 80.91.229.12 (1 Sep 2008 21:49:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Sep 2008 21:49:07 +0000 (UTC) Cc: 810@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 01 23:50:01 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KaHHT-0005t0-UO for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Sep 2008 23:49:52 +0200 Original-Received: from localhost ([127.0.0.1]:56385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaHGV-00057H-3o for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Sep 2008 17:48:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KaHFM-0004I2-1P for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 17:47:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaHFK-0004HC-Ry for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 17:47:39 -0400 Original-Received: from [199.232.76.173] (port=38880 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaHFJ-0004Go-T3 for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 17:47:37 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43368) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KaHFJ-00023v-9x for bug-gnu-emacs@gnu.org; Mon, 01 Sep 2008 17:47:37 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81LlU2T028978; Mon, 1 Sep 2008 14:47:30 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m81LU3lM022655; Mon, 1 Sep 2008 14:30:03 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 01 Sep 2008 21:30:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 810 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 810-submit@emacsbugs.donarmstrong.com id=B810.122030417220713 (code B ref 810); Mon, 01 Sep 2008 21:30:03 +0000 Original-Received: (at 810) by emacsbugs.donarmstrong.com; 1 Sep 2008 21:22:52 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m81LMmsg020707 for <810@emacsbugs.donarmstrong.com>; Mon, 1 Sep 2008 14:22:50 -0700 Original-Received: (qmail invoked by alias); 01 Sep 2008 21:22:43 -0000 Original-Received: from 62-47-37-200.adsl.highway.telekom.at (EHLO [62.47.37.200]) [62.47.37.200] by mail.gmx.net (mp063) with SMTP; 01 Sep 2008 23:22:43 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+uLm0KnrWuYu7hPJbPsR5jNtvHA7fq2PZ8b6ijFc ghlfDIUctVy2pL User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.75 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Mon, 01 Sep 2008 17:47:39 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19990 Archived-At: >>> When using atomic-change-group I got the message >>> undo-more: Changes to be undone are outside visible portion of buffer >>> The changes are also not undone. This seems wrong to me. > >> The attached patch now also tries to restore any narrowing in force >> before the atomic change. > > I'm not sure we should do that. Currently, narrowing operations are not > saved to the undo-log, so making atomic-change-group save&restore the > narrowing makes it behave differently from the undo. I know what you mean but the present case is different. When someone uses narrowing within the atomic change group and we really want to undo the changes (we still can decide that we won't fix the bug ;-)) we have to widen the buffer. If the buffer was narrowed _before_ entering the atomic change group, it would be incorrect not to restore that. Or am I missing something? martin