From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#690: 23.0.60; Function origin file misremembered Date: Mon, 11 Aug 2008 17:56:24 +0200 Message-ID: <48A06128.1010200@gmx.at> References: <20080811004345.11BDDA1B802@mt-computer.local> <489FF80C.8050209@gmx.at> <48A0098F.6090804@gmx.at> Reply-To: martin rudalics , 690@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030905000407050908020009" X-Trace: ger.gmane.org 1218472061 17693 80.91.229.12 (11 Aug 2008 16:27:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Aug 2008 16:27:41 +0000 (UTC) Cc: 690@emacsbugs.donarmstrong.com To: Markus Triska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 11 18:28:32 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KSaFz-0004Lz-Sy for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Aug 2008 18:28:32 +0200 Original-Received: from localhost ([127.0.0.1]:54608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSaF3-0003bT-SO for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Aug 2008 12:27:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSaEz-0003XK-4s for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2008 12:27:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSaEx-0003Ul-FK for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2008 12:27:28 -0400 Original-Received: from [199.232.76.173] (port=34206 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSaEx-0003UV-5R for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2008 12:27:27 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53678) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KSaEw-0008Oh-Lb for bug-gnu-emacs@gnu.org; Mon, 11 Aug 2008 12:27:27 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7BGROw1017974; Mon, 11 Aug 2008 09:27:24 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7BGA4fX012398; Mon, 11 Aug 2008 09:10:04 -0700 X-Loop: don@donarmstrong.com Resent-From: martin rudalics Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 11 Aug 2008 16:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 690 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 690-submit@emacsbugs.donarmstrong.com id=B690.12184704569749 (code B ref 690); Mon, 11 Aug 2008 16:10:04 +0000 Original-Received: (at 690) by emacsbugs.donarmstrong.com; 11 Aug 2008 16:00:56 +0000 Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m7BG0pJG009743 for <690@emacsbugs.donarmstrong.com>; Mon, 11 Aug 2008 09:00:53 -0700 Original-Received: (qmail invoked by alias); 11 Aug 2008 16:00:44 -0000 Original-Received: from 62-47-40-75.adsl.highway.telekom.at (EHLO [62.47.40.75]) [62.47.40.75] by mail.gmx.net (mp062) with SMTP; 11 Aug 2008 18:00:44 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/9K7JD++D9t2HoUHLGfSHQBNrmZlyOVs2ow0YC8O fAyc4Vz8FROaZ+ User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.8,0.66 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Mon, 11 Aug 2008 12:27:28 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19291 Archived-At: This is a multi-part message in MIME format. --------------030905000407050908020009 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > I do not see much value in abbreviating the file name at all; unless > that is important for other features to work, I find that the original > file name should be preserved in case of doubt. (symbol-file > 'prolog-mode) correctly evaluates to "/Users/mt/prolog.el", so this is > what should be shown. Otherwise, even future changes to load-path could > lead to distorted file origins of functions that are already loaded. Do people see problems if we do not simplify the filename when the libname is not a compiled file? martin --------------030905000407050908020009 Content-Type: text/plain; name="690.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="690.diff" *** help-fns.el.~1.123.~ 2008-07-28 15:19:09.000000000 +0200 --- help-fns.el 2008-08-11 17:49:09.375000000 +0200 *************** *** 225,234 **** (let ((libname (file-name-nondirectory file))) ;; Now convert that back to a file name and see if we get ;; the original one. If so, they are equivalent. ! (if (equal file (locate-file libname load-path '(""))) ! (if (string-match "[.]elc\\'" libname) ! (substring libname 0 -1) ! libname) file)))) (defun find-source-lisp-file (file-name) --- 225,233 ---- (let ((libname (file-name-nondirectory file))) ;; Now convert that back to a file name and see if we get ;; the original one. If so, they are equivalent. ! (if (and (equal file (locate-file libname load-path '(""))) ! (string-match "[.]elc\\'" libname)) ! (substring libname 0 -1) file)))) (defun find-source-lisp-file (file-name) --------------030905000407050908020009--