From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>, Drew Adams <drew.adams@oracle.com>
Cc: 35376@debbugs.gnu.org
Subject: bug#35376: 26.2; (emacs) `Xref Commands' - no mention of `mouse-1'
Date: Tue, 30 Jul 2019 17:08:04 +0300 [thread overview]
Message-ID: <48497e67-9a11-66b5-e3f6-adc1c5d7cf51@yandex.ru> (raw)
In-Reply-To: <87zhlnthxp.fsf@mouse.gnus.org>
On 09.07.2019 17:13, Lars Ingebrigtsen wrote:
> The mouse bindings are a bit confusing:
>
> (defvar xref--button-map
> (let ((map (make-sparse-keymap)))
> (define-key map [mouse-1] #'xref-goto-xref)
> (define-key map [mouse-2] #'xref--mouse-2)
> map))
>
> Why is the command called xref--mouse-2? That's a very non-descriptive
> command name.
It's been that way from the beginning. You can rename it, I think, if
you have a better name in mind.
> And... don't these two really kinda do the same thing?
> mouse-1 sets the point first and then goes to the xref, and mouse-2
> ... does the same, only in a different way?
Does the idea of "not switching windows" make sense to you?
next prev parent reply other threads:[~2019-07-30 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 12:49 bug#35376: 26.2; (emacs) `Xref Commands' - no mention of `mouse-1' Drew Adams
2019-07-09 14:13 ` Lars Ingebrigtsen
2019-07-30 14:08 ` Dmitry Gutov [this message]
2019-07-31 18:47 ` Lars Ingebrigtsen
2019-12-23 16:28 ` Dmitry Gutov
2021-08-31 2:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48497e67-9a11-66b5-e3f6-adc1c5d7cf51@yandex.ru \
--to=dgutov@yandex.ru \
--cc=35376@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).