From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Sun, 07 Jun 2020 11:04:30 +0200 Message-ID: <48285.0711954356$1591520716@news.gmane.org> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <83o8q2elja.fsf@gnu.org> <83mu5mel4o.fsf@gnu.org> <77F1DDD3-A69F-40ED-902D-74986D5E6596@acm.org> <83y2p5cumz.fsf@gnu.org> <83blm0cjlz.fsf@gnu.org> <83367ccf8w.fsf@gnu.org> <624D7FB8-A836-4A7E-8895-47E867214504@acm.org> <83o8pyc4bq.fsf@gnu.org> <55D73CA5-1EFB-4B0A-8F8B-FDA1D39F51BF@acm.org> <835zc5bsut.fsf@gnu.org> <3BBCFDD4-C14D-4628-91CB-2A0456A96FC7@acm.org> <838sh0abzz.fsf@gnu.org> <83r1us8kw6.fsf@gnu.org> <020DE875-14A8-457A-9AE4-AA0925DB8997@acm.org> <83img48ffx.fsf@gnu.org> <83bllw82xt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="104139"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: Richard Copley , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 41544@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 07 11:05:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhrEt-000Qyo-NU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jun 2020 11:05:11 +0200 Original-Received: from localhost ([::1]:44352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhrEs-0007MO-BS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jun 2020 05:05:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhrEl-0007Lw-0g for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 05:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhrEk-0000UY-Np for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 05:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhrEk-0003bI-HQ for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 05:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jun 2020 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.159152067613792 (code B ref 41544); Sun, 07 Jun 2020 09:05:02 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 7 Jun 2020 09:04:36 +0000 Original-Received: from localhost ([127.0.0.1]:53296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhrEK-0003aO-5O for submit@debbugs.gnu.org; Sun, 07 Jun 2020 05:04:36 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:38770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhrEH-0003aD-VJ for 41544@debbugs.gnu.org; Sun, 07 Jun 2020 05:04:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=i2bPAZIn58UZ7lWpLe3yIawPjlzsnUqTxJWqGncpfEI=; b=Akon/NWL9Zm8rmV2i97yIvARrc KKeyimA7T/4aQuzuc5ESG2adUnrB6Uf/ZU9uLuo4NXxd5uO5ZDi170HOEPIlQJFlqKcOPakh59BbR P/URyC48UvtX+nqWnYgPLWdbNNai2eYfifZV4xnTdHrF5za42Gcbhum8peMX4K/6udCPHm3q26jKr CnuDtOLGS6wLGeqfHYZv6+XPeybYLfcoY646KWCzUq7G9YjX4i3sVy0loKMeQbhwmfgt6at+1dG6j T/sqPFT5QsV028Ot/TdalRL9Uk7Luum8dFjF3rEWThdyqPxLo2xKbP0E0lbJ1oJL3MSswMTHckkIU oy52714A==; Original-Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jhrEF-0001PO-9l; Sun, 07 Jun 2020 11:04:31 +0200 Original-Received: by submission02.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jhrEF-0000hE-67; Sun, 07 Jun 2020 11:04:31 +0200 In-Reply-To: <83bllw82xt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jun 2020 21:27:42 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181656 Archived-At: Eli Zaretskii writes: >> -(defun css--contrasty-color (name) >> - "Return a color that contrasts with NAME. >> -NAME is of any form accepted by `color-distance'. >> -The returned color will be usable by Emacs and will contrast >> -with NAME; in particular so that if NAME is used as a background >> -color, the returned color can be used as the foreground and still >> -be readable." >> - ;; See bug#25525 for a discussion of this. >> - (if (> (color-distance name "black") 292485) >> - "black" "white")) >> - >> (defcustom css-fontify-colors t >> "Whether CSS colors should be fontified using the color as the background. >> When non-`nil', a text representing CSS color will be fontified >> @@ -1199,7 +1188,8 @@ css--fontify-region >> (add-text-properties >> start (point) >> (list 'face (list :background color >> - :foreground (css--contrasty-color color) >> + :foreground (readable-foreground-color >> + color) >> :box '(:line-width -1)))))))))))) >> extended-region)) > > Here, once again I will ask what practical problem is being fixed. I can't comment on the patch overall, but this part at least seems to address Richard Copley's complaints in bug#30295. A dark foreground is now used for #0f0/rgba(0,255,0,0.5) and #5e5 as Richard requested, which indeed looks more readable to me too. Maybe the pendulum has swung too far however. For instance, a dark foreground is now used for #ef716e, which I think was easier to read with the light foreground used before. Could that be fixed by tweaking the cut-off values in color-dark-p, perhaps? -- Simen