From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#66752: 30.0.50; [PATCH] Add support for 'thing-at-point' to 'bug-reference-mode' Date: Sat, 4 Nov 2023 13:07:38 -0700 Message-ID: <47a54242-d331-5864-7b2c-f1990034091a@gmail.com> References: <87o7g9tj79.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32424"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66752@debbugs.gnu.org, Eli Zaretskii To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 04 21:08:43 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzMwk-0008Im-Vi for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Nov 2023 21:08:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzMwV-0002Mx-Qz; Sat, 04 Nov 2023 16:08:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzMwU-0002Mk-Ka for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 16:08:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzMwU-0008Mh-8B for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 16:08:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzMx4-0005H8-Hd for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 16:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Nov 2023 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66752-submit@debbugs.gnu.org id=B66752.169912850420225 (code B ref 66752); Sat, 04 Nov 2023 20:09:02 +0000 Original-Received: (at 66752) by debbugs.gnu.org; 4 Nov 2023 20:08:24 +0000 Original-Received: from localhost ([127.0.0.1]:35806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzMwR-0005G9-MH for submit@debbugs.gnu.org; Sat, 04 Nov 2023 16:08:24 -0400 Original-Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]:56508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzMwQ-0005Fw-2t for 66752@debbugs.gnu.org; Sat, 04 Nov 2023 16:08:22 -0400 Original-Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-1eb6c559ab4so1973016fac.0 for <66752@debbugs.gnu.org>; Sat, 04 Nov 2023 13:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699128460; x=1699733260; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=DrFdfcSm+qPSX5AMdoONBxUUf7tNRD7UT5JGEarRnRY=; b=FD2YCXt4LjQTyFLHhf1sT0orMhPjR1Vz01bbup2g4kSgfLBHcohOk5GzI6xEe0I4rW KUjua+rzDFDUI2/U3SRPsct44c5AO034cxWUJK1gAUjFImWNbC+9iG4EksoPpx53uLzJ JA6vkSj3QkIhejBv/FY4IsuC1XUgG8uJq6nTTVN2wjWDI640s6XyTiDjgFKAlXiWF/7S gtmFo55E0L+TFuppA1UJnGTx6j1o3HepMWkXhBHSjgDeAQiP+lJk4w2xeL1owJIAHgQy qAcefcD+fvteDgAv2IV/6AUl13uoisnhAaYZSSUHAKaafBiMM1/gj/5dKyWfBOBL4LjK 2bHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699128460; x=1699733260; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DrFdfcSm+qPSX5AMdoONBxUUf7tNRD7UT5JGEarRnRY=; b=jk+ne7YM0dVa5xFe9C4c5zTnBrwBX/Z6M5Bv4QxZlto+FGdaZlNjeC1/cNB1h/M+Dd gf6ggX4sVyJWDLWgVKh2UPt4OqvkUqUbdZld+RDaj2vu7e2wXUMoRlWU/N6P0o1AW5Nf 4kZJq0Kz4MqZx/rkbOvop/5dImxNc9COxU3duRS6HGMuUM0Q83k2eyrqprQyTnhjAnQB Kt2PVUMF+oZgrn70cWwpQGZNMDBbXQgQV7XnJnYuDyJk6X9EPo6BW8SgJSHGysm3TaX1 odEd8QrVGbrkknAMALrCmqYmuYYIdMgUwF/xBQIZbSK/njAeO6nBSwuq0uj4SgUjxp37 Quwg== X-Gm-Message-State: AOJu0YyhL9TkemssweIif4VvnbR3jRG3o5QOLrechcwpJkVqM//dr+1U EY2itkZ0OokieWs+gpA0iDCrnseTH2M= X-Google-Smtp-Source: AGHT+IF6o9klzlO6w/9EAkIFtyqcVrVKbUCkRB+8bI6C4P9Wg+TPVYCsHoPBLz/Bw8qgUo5h/XAqQw== X-Received: by 2002:a05:6358:52cb:b0:169:7320:8265 with SMTP id z11-20020a05635852cb00b0016973208265mr23932218rwz.12.1699128459602; Sat, 04 Nov 2023 13:07:39 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 5-20020a17090a19c500b0027768125e24sm3535451pjj.39.2023.11.04.13.07.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Nov 2023 13:07:39 -0700 (PDT) Content-Language: en-US In-Reply-To: <87o7g9tj79.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273790 Archived-At: On 11/4/2023 12:24 PM, Tassilo Horn wrote: > Jim Porter writes: >> (jit-lock-unregister #'bug-reference-fontify) >> + (setq thing-at-point-provider-alist >> + (delete '((url . bug-reference--url-at-point)) >> + thing-at-point-provider-alist)) >> + (when (equal thing-at-point-provider-alist >> + (default-value 'thing-at-point-provider-alist)) >> + (kill-local-variable 'thing-at-point-provider-alist)) > > Is that conventional, nuking a buffer-local value once it's back to its > default value. Just asking out of curiosity. I'm not sure. The only example I saw for adding to 'thing-at-provider-alist' was for EWW (a major mode). I thought, "What if someone activated and deactivated 'bug-reference-mode' and then later added something to the default value of 'thing-at-provider-alist'?" I don't know if that's a case we want to support; maybe I'm just being overly cautious. (Or maybe there should be - or already is - some utility function that does this for us.) Eli, do you have any thoughts on this part?