Re: find-library-name perhaps should try .emacs

Re: find-library-name perhaps should try .emacs

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

 >   C-h k runs the command describe-key
 > which showed me
 >   C-x t runs the command jidanni-tidy-buffer
 >   which is an interactive compiled Lisp function in `/home/jidanni/.emacs.elc'.
 > But when I clicked that filename, I got
 >   find-library-name: Can't find library /home/jidanni/.emacs.el
 > Why of course. It's in .emacs, not .emacs.el.

Could you please test the attached patch (it should work regardless of
whether your dot-emacs file is called .emacs or .emacs.el).

[-- Attachment #2: find-func.patch --]
[-- Type: text/plain, Size: 1228 bytes --]

*** emacs-lisp/find-func.el.~1.87.~	Fri Jan 25 18:39:20 2008
--- emacs-lisp/find-func.el	Sat Jan 26 19:14:00 2008
***************
*** 239,246 ****
      (setq symbol (get symbol 'definition-name)))
    (if (string-match "\\`src/\\(.*\\.c\\)\\'" library)
        (find-function-C-source symbol (match-string 1 library) type)
!     (if (string-match "\\.el\\(c\\)\\'" library)
! 	(setq library (substring library 0 (match-beginning 1))))
      (let* ((filename (find-library-name library))
  	   (regexp-symbol (cdr (assq type find-function-regexp-alist))))
        (with-current-buffer (find-file-noselect filename)
--- 239,248 ----
      (setq symbol (get symbol 'definition-name)))
    (if (string-match "\\`src/\\(.*\\.c\\)\\'" library)
        (find-function-C-source symbol (match-string 1 library) type)
!     (when (string-match "\\.el\\(c\\)\\'" library)
!       (setq library (substring library 0 (match-beginning 1))))
!     (when (string-match "\\.emacs\\(.el\\)" library)
!       (setq library (substring library 0 (match-beginning 1))))
      (let* ((filename (find-library-name library))
  	   (regexp-symbol (cdr (assq type find-function-regexp-alist))))
        (with-current-buffer (find-file-noselect filename)

emacs -l should put "Loading..." into *Messages* perhaps

[jidanni]

mr> Could you please test the attached patch
Works.  By the way I notice
$ k=find-func.el; stat $k;emacs -Q -l $k; stat $k
is needed to confirm -l worked, as C-h e just gives
("emacs" "-Q" "-l" "find-func.el")
Loading subst-jis...done
Loading subst-ksc...done
Loading subst-gb2312...done
Loading subst-big5...done

I.e., no "Loading find-func.el...done" message.

Re: emacs -l should put "Loading..." into *Messages* perhaps

[martin rudalics]

> Works.  By the way I notice

Installed in the trunk.

> $ k=find-func.el; stat $k;emacs -Q -l $k; stat $k
> is needed to confirm -l worked, as C-h e just gives
> ("emacs" "-Q" "-l" "find-func.el")
> Loading subst-jis...done
> Loading subst-ksc...done
> Loading subst-gb2312...done
> Loading subst-big5...done
> 
> I.e., no "Loading find-func.el...done" message.

`command-line-1' does (load file nil t) where the last ("t") argument
suppresses the "Loading ..." messages.  The "nil" argument, should take
care of warning you when FILE doesn't exist.

find-library-name perhaps should try .emacs

[jidanni]

  C-h k runs the command describe-key
which showed me
  C-x t runs the command jidanni-tidy-buffer
  which is an interactive compiled Lisp function in `/home/jidanni/.emacs.elc'.
But when I clicked that filename, I got
  find-library-name: Can't find library /home/jidanni/.emacs.el
Why of course. It's in .emacs, not .emacs.el.

(I use (add-hook 'emacs-lisp-mode-hook '(lambda () (add-hook
 'after-save-hook '(lambda () (byte-compile-file buffer-file-name) )
 nil t))) to make it.) emacs-version "22.1.1"