unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Christoph Arenz <tiga.arenz@web.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 54800@debbugs.gnu.org
Subject: bug#54800: 28.1; calc: Cursor positioned at weird position in calc stack
Date: Mon, 11 Apr 2022 12:25:24 +0200	[thread overview]
Message-ID: <4792caf2-0ef7-d768-6b0a-c87f38cde558@web.de> (raw)
In-Reply-To: <83k0by8js0.fsf@gnu.org>

On 09.04.22 15:32, Eli Zaretskii wrote:
>> Date: Sat, 9 Apr 2022 14:31:06 +0200
>> Cc: 54800@debbugs.gnu.org
>> From: Christoph Arenz <tiga.arenz@web.de>
>>
>>> I think the bug is actually off-by-one error, because the
>>> vertical-motion call doesn't take the header-line into account.  So I
>>> suggest the following patch instead, please see if it solves the
>>> problem:
>> Your patch solves the problem and shows maximum content of the stack
>> in the window.
> Thanks, I installed the fix on the emacs-28 branch.
>
I noticed that while the patch fixes the problem in most cases,
depending on the height of the calc stack window, there can be the case
that the cursor is not positioned on the top-of-stack symbol `.' but one
line
above, at the beginning of the line with the first stack entry.

This can be changed by using the number 4 instead of 3 in the patch.
Not sure if this is the best fix.

(vertical-motion (- 4 (window-height win)))






  reply	other threads:[~2022-04-11 10:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08 19:44 bug#54800: 28.1; calc: Cursor positioned at weird position in calc stack Christoph Arenz
2022-04-09  7:34 ` Eli Zaretskii
2022-04-09 12:31   ` Christoph Arenz
2022-04-09 13:32     ` Eli Zaretskii
2022-04-11 10:25       ` Christoph Arenz [this message]
2022-04-11 11:27         ` Eli Zaretskii
2022-04-11 11:45           ` Eli Zaretskii
2022-04-11 14:53             ` Christoph Arenz
2022-04-12 15:45               ` Christoph Arenz
2022-04-12 20:44                 ` Christoph Arenz
2022-04-13 13:11                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4792caf2-0ef7-d768-6b0a-c87f38cde558@web.de \
    --to=tiga.arenz@web.de \
    --cc=54800@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).